[LARTC] patch for "diff in charge" errors

[LARTC] patch for "diff in charge" errors

[Martin Devera]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 520 bytes --]

Hi All,

in htb 3.3 I turned on more debugs for bad timestamps. As result
we found another bug in all 2.4 (and probably 2.2) kernels.
Because the bug is from today I attached patch. It is no harm
to apply it in every case.
It will get rid of these:
May 14 09:31:00 kernel: HTB: bad diff in charge, diff=1310000
  now=6873088 then=4281851904 j=525127
May 14 09:31:00 kernel: HTB: bad diff in charge, diff=1310000
  now=6873088 then=4281851904 j=525127

(hopefuly). I'll probably make it part of future HTB patches.
devik

[-- Attachment #2: patch --]
[-- Type: TEXT/PLAIN, Size: 282 bytes --]

--- linux-2.4orig/include/net/pkt_sched.h	Sun Dec  9 21:15:25 2001
+++ oldlin/include/net/pkt_sched.h	Thu May 16 16:45:00 2002
@@ -221,7 +221,7 @@
 
 #define PSCHED_EXPORTLIST_2
 
-#if ~0UL == 0xFFFFFFFF
+#if BITS_PER_LONG <= 32
 
 #define PSCHED_WATCHER unsigned long
 

Re: [LARTC] patch for "diff in charge" errors

[Nils Lichtenfeld]

Hi Devik!

Martin Devera wrote:
> in htb 3.3 I turned on more debugs for bad timestamps. As result
> we found another bug in all 2.4 (and probably 2.2) kernels.

Great to hear that. Just curious, what effect could this bug have (e.g.
htb not measuring right, performance, etc.)?

Could this bug have an impact on systems running HTB2 & SFQ?

Thank you!
Greetings, Nils

_______________________________________________
LARTC mailing list / LARTC@mailman.ds9a.nl
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

Re: [LARTC] patch for "diff in charge" errors

[Martin Devera]

Its effect is periodic rate error each 40 minutes.
In 2.4.19preX it cause total instability of CBQ,
HTB and TBF.
devik

On Thu, 16 May 2002, Nils Lichtenfeld wrote:

> Hi Devik!
>
> Martin Devera wrote:
> > in htb 3.3 I turned on more debugs for bad timestamps. As result
> > we found another bug in all 2.4 (and probably 2.2) kernels.
>
> Great to hear that. Just curious, what effect could this bug have (e.g.
> htb not measuring right, performance, etc.)?
>
> Could this bug have an impact on systems running HTB2 & SFQ?
>
> Thank you!
> Greetings, Nils
>
>
>

_______________________________________________
LARTC mailing list / LARTC@mailman.ds9a.nl
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/