All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Van Maren, Kevin" <kevin.vanmaren@unisys.com>
To: linux-ia64@vger.kernel.org
Subject: RE: [Linux-ia64] spin_unlock() problem
Date: Fri, 04 Apr 2003 14:49:09 +0000	[thread overview]
Message-ID: <marc-linux-ia64-105590723705418@msgid-missing> (raw)
In-Reply-To: <marc-linux-ia64-105590723705414@msgid-missing>

Bleh.  I should have _looked at_ the code:

=
Consider the following example:

cpu1()
{
   spin_lock(&bleh);
   *a = foo;
   *b = bar;
   spin_unlock(&bleh);
}

cpu2()
{
   if (*b = bar)
      boink(*a);
}

=
No, this will not work: if you need it to work, you need to add a wmb
between the store to a and the store to b -- because cpu2 is NOT
acquiring "bleh", so it CAN see the writes out of order.  If you
were using "bleh" "properly" (ie, always acquiring it to access a/b)
then yes, it should work because the lock/unlock enforce memory
consistency.

Kevin


  parent reply	other threads:[~2003-04-04 14:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-04  4:51 [Linux-ia64] spin_unlock() problem Jes Sorensen
2003-04-04  5:04 ` Jes Sorensen
2003-04-04 14:43 ` Van Maren, Kevin
2003-04-04 14:49 ` Van Maren, Kevin [this message]
2003-04-04 15:13 ` Jes Sorensen
2003-04-07 21:09 ` David Mosberger
2003-04-07 21:14 ` David Mosberger
2003-04-07 22:09 ` Jes Sorensen
2003-04-07 22:18 ` Luck, Tony
2003-04-07 22:58 ` David Mosberger
2003-04-07 23:13 ` Jes Sorensen
2003-04-07 23:30 ` Jim Hull
2003-04-07 23:38 ` Chen, Kenneth W
2003-04-08  0:14 ` David Mosberger
2003-04-08  0:15 ` David Mosberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=marc-linux-ia64-105590723705418@msgid-missing \
    --to=kevin.vanmaren@unisys.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.