From: Alex Williamson <alex.williamson@hp.com>
To: linux-ia64@vger.kernel.org
Subject: [PATCH] UP cmc/cpe polling fix
Date: Mon, 25 Aug 2003 18:36:56 +0000 [thread overview]
Message-ID: <marc-linux-ia64-106183667010615@msgid-missing> (raw)
[-- Attachment #1: Type: text/plain, Size: 295 bytes --]
Oops, I must have only tested the UP polling on a 2.4 kernel. On
2.6, I hit the BUG_ON calling cpu_online(1). Simply swapping the
order of the test fixes it. This should be applied for 2.6 and 2.4.
Thanks,
Alex
--
Alex Williamson HP Linux & Open Source Lab
[-- Attachment #2: mca_cpu_online_fixup.diff --]
[-- Type: text/plain, Size: 777 bytes --]
--- linux-2.6.0-test3.orig/arch/ia64/kernel/mca.c 2003-08-25 09:04:18.000000000 -0600
+++ linux-2.6.0-test3/arch/ia64/kernel/mca.c 2003-08-25 11:16:23.000000000 -0600
@@ -1145,7 +1145,7 @@
ia64_mca_cmc_int_handler(cpe_irq, arg, ptregs);
- for (++cpuid ; !cpu_online(cpuid) && cpuid < NR_CPUS ; cpuid++);
+ for (++cpuid ; cpuid < NR_CPUS && !cpu_online(cpuid) ; cpuid++);
if (cpuid < NR_CPUS) {
platform_send_ipi(cpuid, IA64_CMCP_VECTOR, IA64_IPI_DM_INT, 0);
@@ -1225,7 +1225,7 @@
ia64_mca_cpe_int_handler(cpe_irq, arg, ptregs);
- for (++cpuid ; !cpu_online(cpuid) && cpuid < NR_CPUS ; cpuid++);
+ for (++cpuid ; cpuid < NR_CPUS && !cpu_online(cpuid) ; cpuid++);
if (cpuid < NR_CPUS) {
platform_send_ipi(cpuid, IA64_CPEP_VECTOR, IA64_IPI_DM_INT, 0);
next reply other threads:[~2003-08-25 18:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-25 18:36 Alex Williamson [this message]
2003-08-26 20:49 ` [PATCH] UP cmc/cpe polling fix Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ia64-106183667010615@msgid-missing \
--to=alex.williamson@hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.