From: "Aurélien Aptel" <aaptel@suse.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, trivial@kernel.org
Subject: Re: [PATCH 1/1] fs/inode.c: spelling in inode_owner_or_capable doc
Date: Fri, 21 Apr 2017 15:36:37 +0200 [thread overview]
Message-ID: <mpsshl1yja2.fsf@aaptelpc.suse.de> (raw)
In-Reply-To: <20170421122138.GD27790@bombadil.infradead.org>
Matthew Wilcox <willy@infradead.org> writes:
> This is wrong. "if the current task has either FOO or owns the file".
> It's also unnecessarily complex. Try this:
>
> * Return true if the current task owns the file or has CAP_FOWNER in a
> * namespace with the inode owner uid mapped
>
> ("either" in this context would imply exclusive-or, which isn't the intended
> meaning).
Sounds good, I'll send an updated patch.
--
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
prev parent reply other threads:[~2017-04-21 13:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 11:37 [PATCH 1/1] fs/inode.c: spelling in inode_owner_or_capable doc Aurelien Aptel
2017-04-21 12:21 ` Matthew Wilcox
2017-04-21 13:36 ` Aurélien Aptel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mpsshl1yja2.fsf@aaptelpc.suse.de \
--to=aaptel@suse.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=trivial@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.