From: Johannes Thumshirn <jthumshirn@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
Benjamin Block <bblock@linux.vnet.ibm.com>
Subject: Re: [PATCH 9/9] bsg: split handling of SCSI CDBs vs transport requeues
Date: Wed, 04 Oct 2017 09:18:11 +0200 [thread overview]
Message-ID: <mqd7ewbidos.fsf@linux-x5ow.site> (raw)
In-Reply-To: <20171003104845.10417-10-hch@lst.de> (Christoph Hellwig's message of "Tue, 3 Oct 2017 12:48:45 +0200")
Christoph Hellwig <hch@lst.de> writes:
[...]
> @@ -965,7 +932,8 @@ void bsg_unregister_queue(struct request_queue *q)
> EXPORT_SYMBOL_GPL(bsg_unregister_queue);
>
> int bsg_register_queue(struct request_queue *q, struct device *parent,
> - const char *name, void (*release)(struct device *))
> + const char *name, const struct bsg_ops *ops,
> + void (*release)(struct device *))
Wouldn't it make sense to put the ->release() method into bsg_ops as
well? The current prototype of bsg_register_queue isn't exactly what I
would call a sane API.
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2017-10-04 7:18 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 10:48 [RFC] bsg-lib interface cleanup Christoph Hellwig
2017-10-03 10:48 ` [PATCH 1/9] bsg-lib: fix use-after-free under memory-pressure Christoph Hellwig
2017-10-04 6:16 ` Hannes Reinecke
2017-10-04 8:54 ` Johannes Thumshirn
2017-10-04 8:54 ` Johannes Thumshirn
2017-10-03 10:48 ` [PATCH 2/9] bfa: don't reset max_segments for every bsg request Christoph Hellwig
2017-10-04 6:16 ` Hannes Reinecke
2017-10-04 8:54 ` Johannes Thumshirn
2017-10-04 8:54 ` Johannes Thumshirn
2017-10-03 10:48 ` [PATCH 3/9] libfc: don't assign resid_len in fc_lport_bsg_request Christoph Hellwig
2017-10-04 6:17 ` Hannes Reinecke
2017-10-04 8:54 ` Johannes Thumshirn
2017-10-04 8:54 ` Johannes Thumshirn
2017-10-03 10:48 ` [PATCH 4/9] qla2xxx: don't break the bsg-lib abstractions Christoph Hellwig
2017-10-04 6:20 ` Hannes Reinecke
2017-10-04 8:54 ` Johannes Thumshirn
2017-10-04 8:54 ` Johannes Thumshirn
2017-10-05 16:58 ` Madhani, Himanshu
2017-10-05 16:58 ` Madhani, Himanshu
2017-10-03 10:48 ` [PATCH 5/9] scsi_transport_sas: check reply payload length instead of bidi request Christoph Hellwig
2017-10-04 6:21 ` Hannes Reinecke
2017-10-04 8:53 ` Johannes Thumshirn
2017-10-04 8:53 ` Johannes Thumshirn
2017-10-03 10:48 ` [PATCH 6/9] bsg-lib: introduce a timeout field in struct bsg_job Christoph Hellwig
2017-10-04 6:21 ` Hannes Reinecke
2017-10-04 8:53 ` Johannes Thumshirn
2017-10-04 8:53 ` Johannes Thumshirn
2017-10-16 16:30 ` Benjamin Block
2017-10-16 16:30 ` Benjamin Block
2017-10-03 10:48 ` [PATCH 7/9] bsg-lib: remove bsg_job.req Christoph Hellwig
2017-10-04 6:22 ` Hannes Reinecke
2017-10-04 8:52 ` Johannes Thumshirn
2017-10-04 8:52 ` Johannes Thumshirn
2017-10-16 16:36 ` Benjamin Block
2017-10-16 16:36 ` Benjamin Block
2017-10-03 10:48 ` [PATCH 8/9] block: pass full fmode_t to blk_verify_command Christoph Hellwig
2017-10-04 6:23 ` Hannes Reinecke
2017-10-04 8:52 ` Johannes Thumshirn
2017-10-04 8:52 ` Johannes Thumshirn
2017-10-16 16:50 ` Benjamin Block
2017-10-16 16:50 ` Benjamin Block
2017-10-03 10:48 ` [PATCH 9/9] bsg: split handling of SCSI CDBs vs transport requeues Christoph Hellwig
2017-10-04 6:26 ` Hannes Reinecke
2017-10-04 7:18 ` Johannes Thumshirn [this message]
2017-10-04 7:20 ` Christoph Hellwig
2017-10-04 8:52 ` Johannes Thumshirn
2017-10-04 8:52 ` Johannes Thumshirn
2017-10-04 7:18 ` Johannes Thumshirn
2017-10-19 15:59 ` Benjamin Block
2017-10-19 15:59 ` Benjamin Block
2017-10-20 16:26 ` Christoph Hellwig
2017-10-20 16:47 ` Benjamin Block
2017-10-20 16:47 ` Benjamin Block
2017-10-23 6:16 ` Martin K. Petersen
2017-10-23 6:29 ` Christoph Hellwig
2017-10-23 7:17 ` Martin K. Petersen
2017-10-24 17:46 ` Jens Axboe
2017-10-24 16:58 ` Benjamin Block
2017-10-24 16:58 ` Benjamin Block
2017-10-04 14:35 ` [RFC] bsg-lib interface cleanup Jens Axboe
2017-10-17 3:50 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mqd7ewbidos.fsf@linux-x5ow.site \
--to=jthumshirn@suse.de \
--cc=bblock@linux.vnet.ibm.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.