All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Thumshirn <jthumshirn@suse.de>
To: Elena Reshetova <elena.reshetova@intel.com>
Cc: axboe@kernel.dk,  james.bottomley@hansenpartnership.com,
	 linux-kernel@vger.kernel.org,  linux-block@vger.kernel.org,
	 linux-scsi@vger.kernel.org,  linux-btrfs@vger.kernel.org,
	 peterz@infradead.org,  gregkh@linuxfoundation.org,
	 fujita.tomonori@lab.ntt.co.jp,  mingo@redhat.com,  clm@fb.com,
	 jbacik@fb.com,  dsterba@suse.com,  keescook@chromium.org
Subject: Re: [PATCH 0/6] v4 block refcount conversion patches
Date: Fri, 20 Oct 2017 10:43:03 +0200	[thread overview]
Message-ID: <mqdr2typ5uw.fsf@linux-x5ow.site> (raw)
In-Reply-To: <1508487362-26663-1-git-send-email-elena.reshetova@intel.com> (Elena Reshetova's message of "Fri, 20 Oct 2017 11:15:56 +0300")

Elena Reshetova <elena.reshetova@intel.com> writes:
> Elena Reshetova (6):
>   block: convert bio.__bi_cnt from atomic_t to refcount_t
>   block: convert blk_queue_tag.refcnt from atomic_t to refcount_t
>   block: convert blkcg_gq.refcnt from atomic_t to refcount_t
>   block: convert io_context.active_ref from atomic_t to refcount_t
>   block: convert bsg_device.ref_count from atomic_t to refcount_t
>   drivers, block: convert xen_blkif.refcnt from atomic_t to refcount_t

Hi Elena,

While the bsg ref_count is cheap, do you have any numbers how the other
conversions compare in performance (throughput and latency) vs atomics?

It should be quite easy to measure against a null_blk device.

Thanks a lot,
       Johannes

--=20
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg
GF: Felix Imend=C3=B6rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N=C3=BCrnberg)
Key fingerprint =3D EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

WARNING: multiple messages have this Message-ID (diff)
From: Johannes Thumshirn <jthumshirn@suse.de>
To: Elena Reshetova <elena.reshetova@intel.com>
Cc: axboe@kernel.dk, james.bottomley@hansenpartnership.com,
	linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
	linux-scsi@vger.kernel.org, linux-btrfs@vger.kernel.org,
	peterz@infradead.org, gregkh@linuxfoundation.org,
	fujita.tomonori@lab.ntt.co.jp, mingo@redhat.com, clm@fb.com,
	jbacik@fb.com, dsterba@suse.com, keescook@chromium.org
Subject: Re: [PATCH 0/6] v4 block refcount conversion patches
Date: Fri, 20 Oct 2017 10:43:03 +0200	[thread overview]
Message-ID: <mqdr2typ5uw.fsf@linux-x5ow.site> (raw)
In-Reply-To: <1508487362-26663-1-git-send-email-elena.reshetova@intel.com> (Elena Reshetova's message of "Fri, 20 Oct 2017 11:15:56 +0300")

Elena Reshetova <elena.reshetova@intel.com> writes:
> Elena Reshetova (6):
>   block: convert bio.__bi_cnt from atomic_t to refcount_t
>   block: convert blk_queue_tag.refcnt from atomic_t to refcount_t
>   block: convert blkcg_gq.refcnt from atomic_t to refcount_t
>   block: convert io_context.active_ref from atomic_t to refcount_t
>   block: convert bsg_device.ref_count from atomic_t to refcount_t
>   drivers, block: convert xen_blkif.refcnt from atomic_t to refcount_t

Hi Elena,

While the bsg ref_count is cheap, do you have any numbers how the other
conversions compare in performance (throughput and latency) vs atomics?

It should be quite easy to measure against a null_blk device.

Thanks a lot,
       Johannes

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

  parent reply	other threads:[~2017-10-20  8:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-20  8:15 [PATCH 0/6] v4 block refcount conversion patches Elena Reshetova
2017-10-20  8:15 ` [PATCH 1/6] block: convert bio.__bi_cnt from atomic_t to refcount_t Elena Reshetova
2017-10-20  8:15 ` [PATCH 2/6] block: convert blk_queue_tag.refcnt " Elena Reshetova
2017-10-20  8:15 ` [PATCH 3/6] block: convert blkcg_gq.refcnt " Elena Reshetova
2017-10-20  8:16 ` [PATCH 4/6] block: convert io_context.active_ref " Elena Reshetova
2017-10-20  8:16 ` [PATCH 5/6] block: convert bsg_device.ref_count " Elena Reshetova
2017-10-20  8:16 ` [PATCH 6/6] drivers, block: convert xen_blkif.refcnt " Elena Reshetova
2017-10-20  8:43 ` Johannes Thumshirn [this message]
2017-10-20  8:43   ` [PATCH 0/6] v4 block refcount conversion patches Johannes Thumshirn
2017-10-20 10:25   ` Reshetova, Elena
2017-10-20 10:25     ` Reshetova, Elena
2017-10-20 10:25     ` Reshetova, Elena

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mqdr2typ5uw.fsf@linux-x5ow.site \
    --to=jthumshirn@suse.de \
    --cc=axboe@kernel.dk \
    --cc=clm@fb.com \
    --cc=dsterba@suse.com \
    --cc=elena.reshetova@intel.com \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=gregkh@linuxfoundation.org \
    --cc=james.bottomley@hansenpartnership.com \
    --cc=jbacik@fb.com \
    --cc=keescook@chromium.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.