From: Andreas Schwab <schwab@suse.de>
To: Sagar Shrikant Kadam <sagar.kadam@sifive.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, peter@korsgaard.com,
andrew@lunn.ch, palmer@sifive.com, paul.walmsley@sifive.com,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 3/3] i2c-ocores: sifive: add polling mode workaround for FU540-C000 SoC.
Date: Tue, 21 May 2019 10:33:48 +0200 [thread overview]
Message-ID: <mvm7eakjjf7.fsf@suse.de> (raw)
In-Reply-To: <1558361478-4381-4-git-send-email-sagar.kadam@sifive.com> (Sagar Shrikant Kadam's message of "Mon, 20 May 2019 19:41:18 +0530")
On Mai 20 2019, Sagar Shrikant Kadam <sagar.kadam@sifive.com> wrote:
> The i2c-ocore driver already has a polling mode interface.But it needs
> a workaround for FU540 Chipset on HiFive unleashed board (RevA00).
> There is an erratum in FU540 chip that prevents interrupt driven i2c
> transfers from working, and also the I2C controller's interrupt bit
> cannot be cleared if set, due to this the existing i2c polling mode
> interface added in mainline earlier doesn't work, and CPU stall's
> infinitely, when-ever i2c transfer is initiated.
>
> Ref:previous polling mode support in mainline
>
> commit 69c8c0c0efa8 ("i2c: ocores: add polling interface")
>
> The workaround / fix under OCORES_FLAG_BROKEN_IRQ is particularly for
> FU540-COOO SoC.
After commit dd7dbf0eb090 this no longer fits.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
WARNING: multiple messages have this Message-ID (diff)
From: Andreas Schwab <schwab@suse.de>
To: Sagar Shrikant Kadam <sagar.kadam@sifive.com>
Cc: mark.rutland@arm.com, andrew@lunn.ch, peter@korsgaard.com,
devicetree@vger.kernel.org, palmer@sifive.com,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
linux-i2c@vger.kernel.org, paul.walmsley@sifive.com,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v5 3/3] i2c-ocores: sifive: add polling mode workaround for FU540-C000 SoC.
Date: Tue, 21 May 2019 10:33:48 +0200 [thread overview]
Message-ID: <mvm7eakjjf7.fsf@suse.de> (raw)
In-Reply-To: <1558361478-4381-4-git-send-email-sagar.kadam@sifive.com> (Sagar Shrikant Kadam's message of "Mon, 20 May 2019 19:41:18 +0530")
On Mai 20 2019, Sagar Shrikant Kadam <sagar.kadam@sifive.com> wrote:
> The i2c-ocore driver already has a polling mode interface.But it needs
> a workaround for FU540 Chipset on HiFive unleashed board (RevA00).
> There is an erratum in FU540 chip that prevents interrupt driven i2c
> transfers from working, and also the I2C controller's interrupt bit
> cannot be cleared if set, due to this the existing i2c polling mode
> interface added in mainline earlier doesn't work, and CPU stall's
> infinitely, when-ever i2c transfer is initiated.
>
> Ref:previous polling mode support in mainline
>
> commit 69c8c0c0efa8 ("i2c: ocores: add polling interface")
>
> The workaround / fix under OCORES_FLAG_BROKEN_IRQ is particularly for
> FU540-COOO SoC.
After commit dd7dbf0eb090 this no longer fits.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-05-21 8:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 14:11 [PATCH v5 0/3] Extend dt bindings to support I2C on sifive devices and a fix broken IRQ in polling mode Sagar Shrikant Kadam
2019-05-20 14:11 ` Sagar Shrikant Kadam
2019-05-20 14:11 ` [PATCH v5 1/3] dt-bindings: i2c: extend existing opencore bindings Sagar Shrikant Kadam
2019-05-20 14:11 ` Sagar Shrikant Kadam
2019-05-20 14:36 ` Rob Herring
2019-05-20 14:36 ` Rob Herring
2019-05-21 3:48 ` Sagar Kadam
2019-05-21 3:48 ` Sagar Kadam
2019-05-20 14:11 ` [PATCH v5 2/3] i2c-ocores: sifive: add support for i2c device on FU540-c000 SoC Sagar Shrikant Kadam
2019-05-20 14:11 ` Sagar Shrikant Kadam
2019-05-20 14:11 ` [PATCH v5 3/3] i2c-ocores: sifive: add polling mode workaround for FU540-C000 SoC Sagar Shrikant Kadam
2019-05-20 14:11 ` Sagar Shrikant Kadam
2019-05-20 14:52 ` Andrew Lunn
2019-05-20 14:52 ` Andrew Lunn
2019-05-20 14:52 ` Andrew Lunn
2019-05-20 15:20 ` Sagar Kadam
2019-05-20 15:20 ` Sagar Kadam
2019-05-21 8:33 ` Andreas Schwab [this message]
2019-05-21 8:33 ` Andreas Schwab
2019-05-21 8:57 ` Sagar Kadam
2019-05-21 8:57 ` Sagar Kadam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvm7eakjjf7.fsf@suse.de \
--to=schwab@suse.de \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=peter@korsgaard.com \
--cc=robh+dt@kernel.org \
--cc=sagar.kadam@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.