* Working device tree for the HifiveU @ 2019-06-17 10:14 Andreas Schwab 2019-06-17 10:58 ` Paul Walmsley 0 siblings, 1 reply; 14+ messages in thread From: Andreas Schwab @ 2019-06-17 10:14 UTC (permalink / raw) To: linux-riscv What is the correct device tree for the HifiveU that works both with 5.2+ and U-Boot? Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Working device tree for the HifiveU 2019-06-17 10:14 Working device tree for the HifiveU Andreas Schwab @ 2019-06-17 10:58 ` Paul Walmsley 2019-06-17 12:11 ` Andreas Schwab 2019-06-17 12:19 ` Andreas Schwab 0 siblings, 2 replies; 14+ messages in thread From: Paul Walmsley @ 2019-06-17 10:58 UTC (permalink / raw) To: Andreas Schwab; +Cc: linux-riscv On Mon, 17 Jun 2019, Andreas Schwab wrote: > What is the correct device tree for the HifiveU that works both with > 5.2+ and U-Boot? U-Boot should follow the kernel's DT data: http://git.denx.de/?p=u-boot.git;a=blob;f=doc/device-tree-bindings/README;h=2ea3439a170236bd912930991ad70ee7289dcd29;hb=HEAD Thus the upstream-bound data is currently here: https://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git/log/?h=fixes However, since some FU540 U-Boot drivers were upstreamed before the kernel DT data was posted and reviewed, it's necessary to patch upstream U-Boot to use the upstream-bound DT data format. One of the patches required can be found here: https://lists.denx.de/pipermail/u-boot/2019-May/370814.html - Paul _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Working device tree for the HifiveU 2019-06-17 10:58 ` Paul Walmsley @ 2019-06-17 12:11 ` Andreas Schwab 2019-06-17 12:19 ` Andreas Schwab 1 sibling, 0 replies; 14+ messages in thread From: Andreas Schwab @ 2019-06-17 12:11 UTC (permalink / raw) To: Paul Walmsley; +Cc: linux-riscv On Jun 17 2019, Paul Walmsley <paul.walmsley@sifive.com> wrote: > On Mon, 17 Jun 2019, Andreas Schwab wrote: > >> What is the correct device tree for the HifiveU that works both with >> 5.2+ and U-Boot? > > U-Boot should follow the kernel's DT data: > > http://git.denx.de/?p=u-boot.git;a=blob;f=doc/device-tree-bindings/README;h=2ea3439a170236bd912930991ad70ee7289dcd29;hb=HEAD > > Thus the upstream-bound data is currently here: > > https://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git/log/?h=fixes > > However, since some FU540 U-Boot drivers were upstreamed before the kernel > DT data was posted and reviewed, it's necessary to patch upstream U-Boot > to use the upstream-bound DT data format. One of the patches required can > be found here: > > https://lists.denx.de/pipermail/u-boot/2019-May/370814.html Any patch to make serial work again? Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Working device tree for the HifiveU 2019-06-17 10:58 ` Paul Walmsley 2019-06-17 12:11 ` Andreas Schwab @ 2019-06-17 12:19 ` Andreas Schwab 2019-06-17 12:47 ` Paul Walmsley 1 sibling, 1 reply; 14+ messages in thread From: Andreas Schwab @ 2019-06-17 12:19 UTC (permalink / raw) To: Paul Walmsley; +Cc: linux-riscv On Jun 17 2019, Paul Walmsley <paul.walmsley@sifive.com> wrote: > On Mon, 17 Jun 2019, Andreas Schwab wrote: > >> What is the correct device tree for the HifiveU that works both with >> 5.2+ and U-Boot? > > U-Boot should follow the kernel's DT data: > > http://git.denx.de/?p=u-boot.git;a=blob;f=doc/device-tree-bindings/README;h=2ea3439a170236bd912930991ad70ee7289dcd29;hb=HEAD > > Thus the upstream-bound data is currently here: > > https://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git/log/?h=fixes That is completely useless. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Working device tree for the HifiveU 2019-06-17 12:19 ` Andreas Schwab @ 2019-06-17 12:47 ` Paul Walmsley 2019-06-17 12:49 ` Andreas Schwab 0 siblings, 1 reply; 14+ messages in thread From: Paul Walmsley @ 2019-06-17 12:47 UTC (permalink / raw) To: Andreas Schwab; +Cc: linux-riscv On Mon, 17 Jun 2019, Andreas Schwab wrote: > On Jun 17 2019, Paul Walmsley <paul.walmsley@sifive.com> wrote: > > > On Mon, 17 Jun 2019, Andreas Schwab wrote: > > > >> What is the correct device tree for the HifiveU that works both with > >> 5.2+ and U-Boot? > > > > U-Boot should follow the kernel's DT data: > > > > http://git.denx.de/?p=u-boot.git;a=blob;f=doc/device-tree-bindings/README;h=2ea3439a170236bd912930991ad70ee7289dcd29;hb=HEAD > > > > Thus the upstream-bound data is currently here: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git/log/?h=fixes > > That is completely useless. If you have specific questions or comments, I or someone else would be happy to try to help you out. Otherwise, there's not much that we can do. - Paul _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Working device tree for the HifiveU 2019-06-17 12:47 ` Paul Walmsley @ 2019-06-17 12:49 ` Andreas Schwab 2019-06-17 13:21 ` Troy Benjegerdes 2019-06-17 13:26 ` Paul Walmsley 0 siblings, 2 replies; 14+ messages in thread From: Andreas Schwab @ 2019-06-17 12:49 UTC (permalink / raw) To: Paul Walmsley; +Cc: linux-riscv On Jun 17 2019, Paul Walmsley <paul.walmsley@sifive.com> wrote: > On Mon, 17 Jun 2019, Andreas Schwab wrote: > >> On Jun 17 2019, Paul Walmsley <paul.walmsley@sifive.com> wrote: >> >> > On Mon, 17 Jun 2019, Andreas Schwab wrote: >> > >> >> What is the correct device tree for the HifiveU that works both with >> >> 5.2+ and U-Boot? >> > >> > U-Boot should follow the kernel's DT data: >> > >> > http://git.denx.de/?p=u-boot.git;a=blob;f=doc/device-tree-bindings/README;h=2ea3439a170236bd912930991ad70ee7289dcd29;hb=HEAD >> > >> > Thus the upstream-bound data is currently here: >> > >> > https://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git/log/?h=fixes >> >> That is completely useless. > > If you have specific questions or comments, I or someone else would be > happy to try to help you out. Otherwise, there's not much that we can do. It doesn't even have ethernet, so how can it be of any use? Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Working device tree for the HifiveU 2019-06-17 12:49 ` Andreas Schwab @ 2019-06-17 13:21 ` Troy Benjegerdes 2019-06-17 13:31 ` Paul Walmsley 2019-06-17 13:26 ` Paul Walmsley 1 sibling, 1 reply; 14+ messages in thread From: Troy Benjegerdes @ 2019-06-17 13:21 UTC (permalink / raw) To: Andreas Schwab, Paul Walmsley, Yash Shah; +Cc: linux-riscv > On Jun 17, 2019, at 7:49 AM, Andreas Schwab <schwab@suse.de> wrote: > > On Jun 17 2019, Paul Walmsley <paul.walmsley@sifive.com> wrote: > >> On Mon, 17 Jun 2019, Andreas Schwab wrote: >> >>> On Jun 17 2019, Paul Walmsley <paul.walmsley@sifive.com> wrote: >>> >>>> On Mon, 17 Jun 2019, Andreas Schwab wrote: >>>> >>>>> What is the correct device tree for the HifiveU that works both with >>>>> 5.2+ and U-Boot? >>>> >>>> U-Boot should follow the kernel's DT data: >>>> >>>> http://git.denx.de/?p=u-boot.git;a=blob;f=doc/device-tree-bindings/README;h=2ea3439a170236bd912930991ad70ee7289dcd29;hb=HEAD >>>> >>>> Thus the upstream-bound data is currently here: >>>> >>>> https://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git/log/?h=fixes >>> >>> That is completely useless. >> >> If you have specific questions or comments, I or someone else would be >> happy to try to help you out. Otherwise, there's not much that we can do. > > It doesn't even have ethernet, so how can it be of any use? > > Andreas. > Could we please include Yash’s macb patches (and associated device tree changes) in the ‘fixes’ branch on https://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Working device tree for the HifiveU 2019-06-17 13:21 ` Troy Benjegerdes @ 2019-06-17 13:31 ` Paul Walmsley 2019-06-17 13:35 ` Troy Benjegerdes 0 siblings, 1 reply; 14+ messages in thread From: Paul Walmsley @ 2019-06-17 13:31 UTC (permalink / raw) To: Troy Benjegerdes; +Cc: Andreas Schwab, Yash Shah, linux-riscv [-- Attachment #1: Type: text/plain, Size: 1664 bytes --] On Mon, 17 Jun 2019, Troy Benjegerdes wrote: > > On Jun 17, 2019, at 7:49 AM, Andreas Schwab <schwab@suse.de> wrote: > > > > On Jun 17 2019, Paul Walmsley <paul.walmsley@sifive.com> wrote: > > > >> On Mon, 17 Jun 2019, Andreas Schwab wrote: > >> > >>> On Jun 17 2019, Paul Walmsley <paul.walmsley@sifive.com> wrote: > >>> > >>>> On Mon, 17 Jun 2019, Andreas Schwab wrote: > >>>> > >>>>> What is the correct device tree for the HifiveU that works both with > >>>>> 5.2+ and U-Boot? > >>>> > >>>> U-Boot should follow the kernel's DT data: > >>>> > >>>> http://git.denx.de/?p=u-boot.git;a=blob;f=doc/device-tree-bindings/README;h=2ea3439a170236bd912930991ad70ee7289dcd29;hb=HEAD > >>>> > >>>> Thus the upstream-bound data is currently here: > >>>> > >>>> https://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git/log/?h=fixes > >>> > >>> That is completely useless. > >> > >> If you have specific questions or comments, I or someone else would be > >> happy to try to help you out. Otherwise, there's not much that we can do. > > > > It doesn't even have ethernet, so how can it be of any use? > > > > Andreas. > > > > Could we please include Yash’s macb patches (and > associated device tree changes) in the ‘fixes’ branch on > https://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git Yash's DT binding need to be approved by the DT maintainers first. And ideally, his MACB driver change needs to be merged first by the networking maintainers. Once that happens, we'll be able to add Ethernet support to the upstream FU540 and HiFive Unleashed device tree data files. - Paul [-- Attachment #2: Type: text/plain, Size: 161 bytes --] _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Working device tree for the HifiveU 2019-06-17 13:31 ` Paul Walmsley @ 2019-06-17 13:35 ` Troy Benjegerdes 2019-06-17 13:41 ` Paul Walmsley 0 siblings, 1 reply; 14+ messages in thread From: Troy Benjegerdes @ 2019-06-17 13:35 UTC (permalink / raw) To: Paul Walmsley; +Cc: Andreas Schwab, Yash Shah, linux-riscv > On Jun 17, 2019, at 8:31 AM, Paul Walmsley <paul.walmsley@sifive.com> wrote: > > On Mon, 17 Jun 2019, Troy Benjegerdes wrote: > >>> On Jun 17, 2019, at 7:49 AM, Andreas Schwab <schwab@suse.de> wrote: >>> >>> On Jun 17 2019, Paul Walmsley <paul.walmsley@sifive.com> wrote: >>> >>>> On Mon, 17 Jun 2019, Andreas Schwab wrote: >>>> >>>>> On Jun 17 2019, Paul Walmsley <paul.walmsley@sifive.com> wrote: >>>>> >>>>>> On Mon, 17 Jun 2019, Andreas Schwab wrote: >>>>>> >>>>>>> What is the correct device tree for the HifiveU that works both with >>>>>>> 5.2+ and U-Boot? >>>>>> >>>>>> U-Boot should follow the kernel's DT data: >>>>>> >>>>>> http://git.denx.de/?p=u-boot.git;a=blob;f=doc/device-tree-bindings/README;h=2ea3439a170236bd912930991ad70ee7289dcd29;hb=HEAD >>>>>> >>>>>> Thus the upstream-bound data is currently here: >>>>>> >>>>>> https://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git/log/?h=fixes >>>>> >>>>> That is completely useless. >>>> >>>> If you have specific questions or comments, I or someone else would be >>>> happy to try to help you out. Otherwise, there's not much that we can do. >>> >>> It doesn't even have ethernet, so how can it be of any use? >>> >>> Andreas. >>> >> >> Could we please include Yash’s macb patches (and >> associated device tree changes) in the ‘fixes’ branch on >> https://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git > > Yash's DT binding need to be approved by the DT maintainers first. And > ideally, his MACB driver change needs to be merged first by the networking > maintainers. > > Once that happens, we'll be able to add Ethernet support to the upstream > FU540 and HiFive Unleashed device tree data files. > > > - Paul Can we at least put it in some kind of ‘under review’ branch on the shared git tree so everything we need (including other stuff like GPIO drivers) is all in one place? We used to do this with some of the github riscv-linux trees. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Working device tree for the HifiveU 2019-06-17 13:35 ` Troy Benjegerdes @ 2019-06-17 13:41 ` Paul Walmsley 2019-06-17 13:50 ` Andreas Schwab 0 siblings, 1 reply; 14+ messages in thread From: Paul Walmsley @ 2019-06-17 13:41 UTC (permalink / raw) To: Troy Benjegerdes; +Cc: Andreas Schwab, Yash Shah, linux-riscv [-- Attachment #1: Type: text/plain, Size: 694 bytes --] On Mon, 17 Jun 2019, Troy Benjegerdes wrote: > Can we at least put it in some kind of ‘under review’ branch on the shared git > tree so everything we need (including other stuff like GPIO drivers) is all in one > place? > > We used to do this with some of the github riscv-linux trees. Yash has already been kind enough to post his own test branch for these patches, along with dependencies: https://github.com/yashshah7/riscv-linux/commits/dev/yashs/ethernet_v2 If you want something more, you're of course welcome to maintain such an unofficial branch on one of your personal git trees, or in a personal branch of one of SiFive's git trees, if you wish. - Paul [-- Attachment #2: Type: text/plain, Size: 161 bytes --] _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Working device tree for the HifiveU 2019-06-17 13:41 ` Paul Walmsley @ 2019-06-17 13:50 ` Andreas Schwab 0 siblings, 0 replies; 14+ messages in thread From: Andreas Schwab @ 2019-06-17 13:50 UTC (permalink / raw) To: Paul Walmsley; +Cc: Troy Benjegerdes, Yash Shah, linux-riscv On Jun 17 2019, Paul Walmsley <paul.walmsley@sifive.com> wrote: > Yash has already been kind enough to post his own test branch for these > patches, along with dependencies: > > https://github.com/yashshah7/riscv-linux/commits/dev/yashs/ethernet_v2 That doesn't work with U-Boot. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Working device tree for the HifiveU 2019-06-17 12:49 ` Andreas Schwab 2019-06-17 13:21 ` Troy Benjegerdes @ 2019-06-17 13:26 ` Paul Walmsley 2019-06-17 13:28 ` Andreas Schwab 1 sibling, 1 reply; 14+ messages in thread From: Paul Walmsley @ 2019-06-17 13:26 UTC (permalink / raw) To: Andreas Schwab; +Cc: linux-riscv On Mon, 17 Jun 2019, Andreas Schwab wrote: > On Jun 17 2019, Paul Walmsley <paul.walmsley@sifive.com> wrote: > > > On Mon, 17 Jun 2019, Andreas Schwab wrote: > > > >> On Jun 17 2019, Paul Walmsley <paul.walmsley@sifive.com> wrote: > >> > >> > On Mon, 17 Jun 2019, Andreas Schwab wrote: > >> > > >> >> What is the correct device tree for the HifiveU that works both with > >> >> 5.2+ and U-Boot? > >> > > >> > U-Boot should follow the kernel's DT data: > >> > > >> > http://git.denx.de/?p=u-boot.git;a=blob;f=doc/device-tree-bindings/README;h=2ea3439a170236bd912930991ad70ee7289dcd29;hb=HEAD > >> > > >> > Thus the upstream-bound data is currently here: > >> > > >> > https://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git/log/?h=fixes > >> > >> That is completely useless. > > > > If you have specific questions or comments, I or someone else would be > > happy to try to help you out. Otherwise, there's not much that we can do. > > It doesn't even have ethernet, so how can it be of any use? We can't add the Ethernet data yet, since it hasn't been approved by the DT maintainers. But of course you can always add it yourself to your own kernel branch, along with the driver. - Paul _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Working device tree for the HifiveU 2019-06-17 13:26 ` Paul Walmsley @ 2019-06-17 13:28 ` Andreas Schwab 2019-06-17 13:34 ` Paul Walmsley 0 siblings, 1 reply; 14+ messages in thread From: Andreas Schwab @ 2019-06-17 13:28 UTC (permalink / raw) To: Paul Walmsley; +Cc: linux-riscv On Jun 17 2019, Paul Walmsley <paul.walmsley@sifive.com> wrote: > We can't add the Ethernet data yet, since it hasn't been approved by the > DT maintainers. But of course you can always add it yourself to your own > kernel branch, along with the driver. Which driver? Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Working device tree for the HifiveU 2019-06-17 13:28 ` Andreas Schwab @ 2019-06-17 13:34 ` Paul Walmsley 0 siblings, 0 replies; 14+ messages in thread From: Paul Walmsley @ 2019-06-17 13:34 UTC (permalink / raw) To: Andreas Schwab; +Cc: linux-riscv On Mon, 17 Jun 2019, Andreas Schwab wrote: > On Jun 17 2019, Paul Walmsley <paul.walmsley@sifive.com> wrote: > > > We can't add the Ethernet data yet, since it hasn't been approved by the > > DT maintainers. But of course you can always add it yourself to your own > > kernel branch, along with the driver. > > Which driver? This one: https://lore.kernel.org/linux-riscv/1560745167-9866-3-git-send-email-yash.shah@sifive.com/T/#u Note that Yash is planning to post a v3 with the CONFIG_MACB_SIFIVE_FU540 conditional removed. - Paul _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2019-06-17 13:50 UTC | newest] Thread overview: 14+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-06-17 10:14 Working device tree for the HifiveU Andreas Schwab 2019-06-17 10:58 ` Paul Walmsley 2019-06-17 12:11 ` Andreas Schwab 2019-06-17 12:19 ` Andreas Schwab 2019-06-17 12:47 ` Paul Walmsley 2019-06-17 12:49 ` Andreas Schwab 2019-06-17 13:21 ` Troy Benjegerdes 2019-06-17 13:31 ` Paul Walmsley 2019-06-17 13:35 ` Troy Benjegerdes 2019-06-17 13:41 ` Paul Walmsley 2019-06-17 13:50 ` Andreas Schwab 2019-06-17 13:26 ` Paul Walmsley 2019-06-17 13:28 ` Andreas Schwab 2019-06-17 13:34 ` Paul Walmsley
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.