All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] grub-install: Define default platform for RISC-V
@ 2019-08-15 14:55 Andreas Schwab
  2019-09-19 10:06 ` Daniel Kiper
  0 siblings, 1 reply; 3+ messages in thread
From: Andreas Schwab @ 2019-08-15 14:55 UTC (permalink / raw)
  To: grub-devel

Signed-off-by: Andreas Schwab <schwab@suse.de>
---
 util/grub-install.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/util/grub-install.c b/util/grub-install.c
index 8a55ad4b8..8970b73aa 100644
--- a/util/grub-install.c
+++ b/util/grub-install.c
@@ -324,6 +324,14 @@ get_default_platform (void)
    return "arm64-efi";
 #elif defined (__amd64__) || defined (__x86_64__) || defined (__i386__)
    return grub_install_get_default_x86_platform ();
+#elif defined (__riscv)
+#if __riscv_xlen == 32
+   return "riscv32-efi";
+#elif __riscv_xlen == 64
+   return "riscv64-efi";
+#else
+   return NULL;
+#endif
 #else
    return NULL;
 #endif
-- 
2.22.1

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] grub-install: Define default platform for RISC-V
  2019-08-15 14:55 [PATCH] grub-install: Define default platform for RISC-V Andreas Schwab
@ 2019-09-19 10:06 ` Daniel Kiper
  2019-09-19 10:21   ` Alexander Graf
  0 siblings, 1 reply; 3+ messages in thread
From: Daniel Kiper @ 2019-09-19 10:06 UTC (permalink / raw)
  To: Andreas Schwab, agraf; +Cc: grub-devel

Adding Alex...

In general "Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>"
but I would to hear Alex's opinion here too...

Daniel

On Thu, Aug 15, 2019 at 04:55:13PM +0200, Andreas Schwab wrote:
> Signed-off-by: Andreas Schwab <schwab@suse.de>
> ---
>  util/grub-install.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/util/grub-install.c b/util/grub-install.c
> index 8a55ad4b8..8970b73aa 100644
> --- a/util/grub-install.c
> +++ b/util/grub-install.c
> @@ -324,6 +324,14 @@ get_default_platform (void)
>     return "arm64-efi";
>  #elif defined (__amd64__) || defined (__x86_64__) || defined (__i386__)
>     return grub_install_get_default_x86_platform ();
> +#elif defined (__riscv)
> +#if __riscv_xlen == 32
> +   return "riscv32-efi";
> +#elif __riscv_xlen == 64
> +   return "riscv64-efi";
> +#else
> +   return NULL;
> +#endif
>  #else
>     return NULL;
>  #endif
> --
> 2.22.1
>
> --
> Andreas Schwab, SUSE Labs, schwab@suse.de
> GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
> "And now for something completely different."
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] grub-install: Define default platform for RISC-V
  2019-09-19 10:06 ` Daniel Kiper
@ 2019-09-19 10:21   ` Alexander Graf
  0 siblings, 0 replies; 3+ messages in thread
From: Alexander Graf @ 2019-09-19 10:21 UTC (permalink / raw)
  To: Daniel Kiper, Andreas Schwab; +Cc: grub-devel

I guess that one must have slipped through the cracks :)

Reviewed-by: Alexander Graf <agraf@csgraf.de>


Alex

On 19.09.19 12:06, Daniel Kiper wrote:
> Adding Alex...
>
> In general "Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>"
> but I would to hear Alex's opinion here too...
>
> Daniel
>
> On Thu, Aug 15, 2019 at 04:55:13PM +0200, Andreas Schwab wrote:
>> Signed-off-by: Andreas Schwab <schwab@suse.de>
>> ---
>>   util/grub-install.c | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/util/grub-install.c b/util/grub-install.c
>> index 8a55ad4b8..8970b73aa 100644
>> --- a/util/grub-install.c
>> +++ b/util/grub-install.c
>> @@ -324,6 +324,14 @@ get_default_platform (void)
>>      return "arm64-efi";
>>   #elif defined (__amd64__) || defined (__x86_64__) || defined (__i386__)
>>      return grub_install_get_default_x86_platform ();
>> +#elif defined (__riscv)
>> +#if __riscv_xlen == 32
>> +   return "riscv32-efi";
>> +#elif __riscv_xlen == 64
>> +   return "riscv64-efi";
>> +#else
>> +   return NULL;
>> +#endif
>>   #else
>>      return NULL;
>>   #endif
>> --
>> 2.22.1
>>
>> --
>> Andreas Schwab, SUSE Labs, schwab@suse.de
>> GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
>> "And now for something completely different."
>>
>> _______________________________________________
>> Grub-devel mailing list
>> Grub-devel@gnu.org
>> https://lists.gnu.org/mailman/listinfo/grub-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-09-19 10:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-15 14:55 [PATCH] grub-install: Define default platform for RISC-V Andreas Schwab
2019-09-19 10:06 ` Daniel Kiper
2019-09-19 10:21   ` Alexander Graf

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.