From: Andreas Schwab <schwab@suse.de>
To: Michael Neuling <mikey@neuling.org>
Cc: pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu,
alex@ghiti.fr, debug@rivosinc.com, thecharlesjenkins@gmail.com,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: ptrace: avoid BIT() in UAPI header
Date: Mon, 30 Mar 2026 10:16:09 +0200 [thread overview]
Message-ID: <mvmjyutivg6.fsf@suse.de> (raw)
In-Reply-To: <20260330024248.449292-1-mikey@neuling.org> (Michael Neuling's message of "Mon, 30 Mar 2026 02:42:48 +0000")
On Mär 30 2026, Michael Neuling wrote:
> BIT() is not available in UAPI headers — the installed linux/bits.h
> (UAPI version) does not define it. Replace BIT() with open-coded
> (1UL << x) which is the standard practice for UAPI headers, and drop
> the linux/bits.h include that was added by commit 98545620b0 ("riscv:
> ptrace: Fix BIT() compilation issues").
There is also the _BITUL macro, which may be preferable.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Andreas Schwab <schwab@suse.de>
To: Michael Neuling <mikey@neuling.org>
Cc: pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu,
alex@ghiti.fr, debug@rivosinc.com, thecharlesjenkins@gmail.com,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: ptrace: avoid BIT() in UAPI header
Date: Mon, 30 Mar 2026 10:16:09 +0200 [thread overview]
Message-ID: <mvmjyutivg6.fsf@suse.de> (raw)
In-Reply-To: <20260330024248.449292-1-mikey@neuling.org> (Michael Neuling's message of "Mon, 30 Mar 2026 02:42:48 +0000")
On Mär 30 2026, Michael Neuling wrote:
> BIT() is not available in UAPI headers — the installed linux/bits.h
> (UAPI version) does not define it. Replace BIT() with open-coded
> (1UL << x) which is the standard practice for UAPI headers, and drop
> the linux/bits.h include that was added by commit 98545620b0 ("riscv:
> ptrace: Fix BIT() compilation issues").
There is also the _BITUL macro, which may be preferable.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next prev parent reply other threads:[~2026-03-31 0:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 2:42 [PATCH] riscv: ptrace: avoid BIT() in UAPI header Michael Neuling
2026-03-30 2:42 ` Michael Neuling
2026-03-30 3:05 ` Michael Neuling
2026-03-30 3:05 ` Michael Neuling
2026-03-30 8:16 ` Andreas Schwab [this message]
2026-03-30 8:16 ` Andreas Schwab
2026-04-03 7:56 ` Paul Walmsley
2026-04-03 7:56 ` Paul Walmsley
2026-04-03 8:06 ` patchwork-bot+linux-riscv
2026-04-03 8:06 ` patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvmjyutivg6.fsf@suse.de \
--to=schwab@suse.de \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=debug@rivosinc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mikey@neuling.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=thecharlesjenkins@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.