All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@suse.de>
To: Nick Kossifidis <mick@ics.forth.gr>
Cc: linux-riscv@lists.infradead.org,  palmer@dabbelt.com,
	paul.walmsley@sifive.com,  linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 5/5] RISC-V: Add crash kernel support
Date: Mon, 30 Oct 2023 11:44:56 +0100	[thread overview]
Message-ID: <mvmjzr475jr.fsf@suse.de> (raw)
In-Reply-To: <20210419005539.22729-6-mick@ics.forth.gr> (Nick Kossifidis's message of "Mon, 19 Apr 2021 03:55:39 +0300")

On Apr 19 2021, Nick Kossifidis wrote:

> @@ -605,6 +606,18 @@ static void __init reserve_crashkernel(void)
>  
>  	int ret = 0;
>  
> +	/*
> +	 * Don't reserve a region for a crash kernel on a crash kernel
> +	 * since it doesn't make much sense and we have limited memory
> +	 * resources.
> +	 */
> +#ifdef CONFIG_CRASH_DUMP
> +	if (is_kdump_kernel()) {
> +		pr_info("crashkernel: ignoring reservation request\n");
> +		return;
> +	}
> +#endif
> +

Why is this necessary?  It breaks
https://github.com/openSUSE/kdump/tree/master/calibrate which wants to
run the kernel with both elfcorehdr and crashkernel.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Andreas Schwab <schwab@suse.de>
To: Nick Kossifidis <mick@ics.forth.gr>
Cc: linux-riscv@lists.infradead.org, palmer@dabbelt.com,
	paul.walmsley@sifive.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 5/5] RISC-V: Add crash kernel support
Date: Mon, 30 Oct 2023 11:44:56 +0100	[thread overview]
Message-ID: <mvmjzr475jr.fsf@suse.de> (raw)
In-Reply-To: <20210419005539.22729-6-mick@ics.forth.gr> (Nick Kossifidis's message of "Mon, 19 Apr 2021 03:55:39 +0300")

On Apr 19 2021, Nick Kossifidis wrote:

> @@ -605,6 +606,18 @@ static void __init reserve_crashkernel(void)
>  
>  	int ret = 0;
>  
> +	/*
> +	 * Don't reserve a region for a crash kernel on a crash kernel
> +	 * since it doesn't make much sense and we have limited memory
> +	 * resources.
> +	 */
> +#ifdef CONFIG_CRASH_DUMP
> +	if (is_kdump_kernel()) {
> +		pr_info("crashkernel: ignoring reservation request\n");
> +		return;
> +	}
> +#endif
> +

Why is this necessary?  It breaks
https://github.com/openSUSE/kdump/tree/master/calibrate which wants to
run the kernel with both elfcorehdr and crashkernel.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

  parent reply	other threads:[~2023-10-30 10:45 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-19  0:55 [PATCH v4 0/5] RISC-V: Add kexec/kdump support Nick Kossifidis
2021-04-19  0:55 ` Nick Kossifidis
2021-04-19  0:55 ` [PATCH v4 1/5] RISC-V: Add EM_RISCV to kexec UAPI header Nick Kossifidis
2021-04-19  0:55   ` Nick Kossifidis
2021-04-19  0:55 ` [PATCH v4 2/5] RISC-V: Add kexec support Nick Kossifidis
2021-04-19  0:55   ` Nick Kossifidis
2021-04-19  0:55 ` [PATCH v4 3/5] RISC-V: Improve init_resources Nick Kossifidis
2021-04-19  0:55   ` Nick Kossifidis
2021-04-19  0:55 ` [PATCH v4 4/5] RISC-V: Add kdump support Nick Kossifidis
2021-04-19  0:55   ` Nick Kossifidis
2021-04-19  0:55 ` [PATCH v4 5/5] RISC-V: Add crash kernel support Nick Kossifidis
2021-04-19  0:55   ` Nick Kossifidis
2021-06-15 13:19   ` Geert Uytterhoeven
2021-06-15 13:19     ` Geert Uytterhoeven
2021-06-15 18:29     ` Nick Kossifidis
2021-06-15 18:29       ` Nick Kossifidis
2021-06-15 18:48       ` Geert Uytterhoeven
2021-06-15 18:48         ` Geert Uytterhoeven
2021-06-15 19:21         ` Rob Herring
2021-06-15 19:21           ` Rob Herring
2021-06-15 23:29           ` Nick Kossifidis
2021-06-15 23:29             ` Nick Kossifidis
2021-06-16 14:55             ` Rob Herring
2021-06-16 14:55               ` Rob Herring
2021-06-16 16:30               ` Ard Biesheuvel
2021-06-16 16:30                 ` Ard Biesheuvel
2023-10-30 10:44   ` Andreas Schwab [this message]
2023-10-30 10:44     ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mvmjzr475jr.fsf@suse.de \
    --to=schwab@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=mick@ics.forth.gr \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.