* [PATCH] riscv64-emu: add __clzdi2 symbol
@ 2019-09-09 12:34 Andreas Schwab
2019-09-18 18:23 ` Daniel Kiper
0 siblings, 1 reply; 5+ messages in thread
From: Andreas Schwab @ 2019-09-09 12:34 UTC (permalink / raw)
To: grub-devel
This is needed for the zstd module.
Signed-off-by: Andreas Schwab <schwab@suse.de>
---
configure.ac | 2 +-
include/grub/compiler-rt-emu.h | 5 +++++
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index e07ba4b56..7d74eba66 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1370,7 +1370,7 @@ fi
# Check for libgcc symbols
if test x"$platform" = xemu; then
-AC_CHECK_FUNCS(__udivsi3 __umodsi3 __divsi3 __modsi3 __divdi3 __moddi3 __udivdi3 __umoddi3 __ctzdi2 __ctzsi2 __aeabi_uidiv __aeabi_uidivmod __aeabi_idiv __aeabi_idivmod __aeabi_ulcmp __muldi3 __aeabi_lmul __aeabi_memcpy __aeabi_memcpy4 __aeabi_memcpy8 __aeabi_memclr __aeabi_memclr4 __aeabi_memclr8 __aeabi_memset __aeabi_lasr __aeabi_llsl __aeabi_llsr _restgpr_14_x __ucmpdi2 __ashldi3 __ashrdi3 __lshrdi3 __bswapsi2 __bswapdi2 __bzero __register_frame_info __deregister_frame_info ___chkstk_ms __chkstk_ms)
+AC_CHECK_FUNCS(__udivsi3 __umodsi3 __divsi3 __modsi3 __divdi3 __moddi3 __udivdi3 __umoddi3 __ctzdi2 __ctzsi2 __clzdi2 __aeabi_uidiv __aeabi_uidivmod __aeabi_idiv __aeabi_idivmod __aeabi_ulcmp __muldi3 __aeabi_lmul __aeabi_memcpy __aeabi_memcpy4 __aeabi_memcpy8 __aeabi_memclr __aeabi_memclr4 __aeabi_memclr8 __aeabi_memset __aeabi_lasr __aeabi_llsl __aeabi_llsr _restgpr_14_x __ucmpdi2 __ashldi3 __ashrdi3 __lshrdi3 __bswapsi2 __bswapdi2 __bzero __register_frame_info __deregister_frame_info ___chkstk_ms __chkstk_ms)
fi
if test "x$TARGET_APPLE_LINKER" = x1 ; then
diff --git a/include/grub/compiler-rt-emu.h b/include/grub/compiler-rt-emu.h
index b21425d9e..661f9876f 100644
--- a/include/grub/compiler-rt-emu.h
+++ b/include/grub/compiler-rt-emu.h
@@ -74,6 +74,11 @@ unsigned
EXPORT_FUNC (__ctzsi2) (grub_uint32_t x);
#endif
+#ifdef HAVE___CLZDI2
+unsigned
+EXPORT_FUNC (__clzdi2) (grub_uint64_t x);
+#endif
+
#ifdef HAVE___AEABI_UIDIV
grub_uint32_t
EXPORT_FUNC (__aeabi_uidiv) (grub_uint32_t a, grub_uint32_t b);
--
2.23.0
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] riscv64-emu: add __clzdi2 symbol
2019-09-09 12:34 [PATCH] riscv64-emu: add __clzdi2 symbol Andreas Schwab
@ 2019-09-18 18:23 ` Daniel Kiper
2019-09-19 7:38 ` Andreas Schwab
2019-09-19 7:39 ` [PATCH v2] " Andreas Schwab
0 siblings, 2 replies; 5+ messages in thread
From: Daniel Kiper @ 2019-09-18 18:23 UTC (permalink / raw)
To: schwab, agraf, eric.snowberg; +Cc: grub-devel
Adding Alex and Eric...
On Mon, Sep 09, 2019 at 02:34:25PM +0200, Andreas Schwab wrote:
> This is needed for the zstd module.
>
> Signed-off-by: Andreas Schwab <schwab@suse.de>
> ---
> configure.ac | 2 +-
> include/grub/compiler-rt-emu.h | 5 +++++
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index e07ba4b56..7d74eba66 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1370,7 +1370,7 @@ fi
>
> # Check for libgcc symbols
> if test x"$platform" = xemu; then
> -AC_CHECK_FUNCS(__udivsi3 __umodsi3 __divsi3 __modsi3 __divdi3 __moddi3 __udivdi3 __umoddi3 __ctzdi2 __ctzsi2 __aeabi_uidiv __aeabi_uidivmod __aeabi_idiv __aeabi_idivmod __aeabi_ulcmp __muldi3 __aeabi_lmul __aeabi_memcpy __aeabi_memcpy4 __aeabi_memcpy8 __aeabi_memclr __aeabi_memclr4 __aeabi_memclr8 __aeabi_memset __aeabi_lasr __aeabi_llsl __aeabi_llsr _restgpr_14_x __ucmpdi2 __ashldi3 __ashrdi3 __lshrdi3 __bswapsi2 __bswapdi2 __bzero __register_frame_info __deregister_frame_info ___chkstk_ms __chkstk_ms)
> +AC_CHECK_FUNCS(__udivsi3 __umodsi3 __divsi3 __modsi3 __divdi3 __moddi3 __udivdi3 __umoddi3 __ctzdi2 __ctzsi2 __clzdi2 __aeabi_uidiv __aeabi_uidivmod __aeabi_idiv __aeabi_idivmod __aeabi_ulcmp __muldi3 __aeabi_lmul __aeabi_memcpy __aeabi_memcpy4 __aeabi_memcpy8 __aeabi_memclr __aeabi_memclr4 __aeabi_memclr8 __aeabi_memset __aeabi_lasr __aeabi_llsl __aeabi_llsr _restgpr_14_x __ucmpdi2 __ashldi3 __ashrdi3 __lshrdi3 __bswapsi2 __bswapdi2 __bzero __register_frame_info __deregister_frame_info ___chkstk_ms __chkstk_ms)
> fi
>
> if test "x$TARGET_APPLE_LINKER" = x1 ; then
> diff --git a/include/grub/compiler-rt-emu.h b/include/grub/compiler-rt-emu.h
> index b21425d9e..661f9876f 100644
> --- a/include/grub/compiler-rt-emu.h
> +++ b/include/grub/compiler-rt-emu.h
> @@ -74,6 +74,11 @@ unsigned
> EXPORT_FUNC (__ctzsi2) (grub_uint32_t x);
> #endif
>
> +#ifdef HAVE___CLZDI2
> +unsigned
> +EXPORT_FUNC (__clzdi2) (grub_uint64_t x);
> +#endif
> +
Hmmm... Is __clzdi2() declaration correct? Please take a look at
grub-core/kern/compiler-rt.c. __clzdi2() returns int instead of
unsigned there. Hence, it should be fixed here or there.
Daniel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] riscv64-emu: add __clzdi2 symbol
2019-09-18 18:23 ` Daniel Kiper
@ 2019-09-19 7:38 ` Andreas Schwab
2019-09-19 7:39 ` [PATCH v2] " Andreas Schwab
1 sibling, 0 replies; 5+ messages in thread
From: Andreas Schwab @ 2019-09-19 7:38 UTC (permalink / raw)
To: Daniel Kiper; +Cc: agraf, eric.snowberg, grub-devel
On Sep 18 2019, Daniel Kiper <dkiper@net-space.pl> wrote:
> Hmmm... Is __clzdi2() declaration correct?
It doesn't really matter, since nobody is using the prototype. It's
only used for generating the symbol list.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] riscv64-emu: add __clzdi2 symbol
2019-09-18 18:23 ` Daniel Kiper
2019-09-19 7:38 ` Andreas Schwab
@ 2019-09-19 7:39 ` Andreas Schwab
2019-09-19 9:58 ` Daniel Kiper
1 sibling, 1 reply; 5+ messages in thread
From: Andreas Schwab @ 2019-09-19 7:39 UTC (permalink / raw)
To: Daniel Kiper; +Cc: agraf, eric.snowberg, grub-devel
This is needed for the zstd module.
Signed-off-by: Andreas Schwab <schwab@suse.de>
---
configure.ac | 2 +-
include/grub/compiler-rt-emu.h | 5 +++++
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index e07ba4b56..7d74eba66 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1370,7 +1370,7 @@ fi
# Check for libgcc symbols
if test x"$platform" = xemu; then
-AC_CHECK_FUNCS(__udivsi3 __umodsi3 __divsi3 __modsi3 __divdi3 __moddi3 __udivdi3 __umoddi3 __ctzdi2 __ctzsi2 __aeabi_uidiv __aeabi_uidivmod __aeabi_idiv __aeabi_idivmod __aeabi_ulcmp __muldi3 __aeabi_lmul __aeabi_memcpy __aeabi_memcpy4 __aeabi_memcpy8 __aeabi_memclr __aeabi_memclr4 __aeabi_memclr8 __aeabi_memset __aeabi_lasr __aeabi_llsl __aeabi_llsr _restgpr_14_x __ucmpdi2 __ashldi3 __ashrdi3 __lshrdi3 __bswapsi2 __bswapdi2 __bzero __register_frame_info __deregister_frame_info ___chkstk_ms __chkstk_ms)
+AC_CHECK_FUNCS(__udivsi3 __umodsi3 __divsi3 __modsi3 __divdi3 __moddi3 __udivdi3 __umoddi3 __ctzdi2 __ctzsi2 __clzdi2 __aeabi_uidiv __aeabi_uidivmod __aeabi_idiv __aeabi_idivmod __aeabi_ulcmp __muldi3 __aeabi_lmul __aeabi_memcpy __aeabi_memcpy4 __aeabi_memcpy8 __aeabi_memclr __aeabi_memclr4 __aeabi_memclr8 __aeabi_memset __aeabi_lasr __aeabi_llsl __aeabi_llsr _restgpr_14_x __ucmpdi2 __ashldi3 __ashrdi3 __lshrdi3 __bswapsi2 __bswapdi2 __bzero __register_frame_info __deregister_frame_info ___chkstk_ms __chkstk_ms)
fi
if test "x$TARGET_APPLE_LINKER" = x1 ; then
diff --git a/include/grub/compiler-rt-emu.h b/include/grub/compiler-rt-emu.h
index b21425d9e..fde620ac1 100644
--- a/include/grub/compiler-rt-emu.h
+++ b/include/grub/compiler-rt-emu.h
@@ -74,6 +74,11 @@ unsigned
EXPORT_FUNC (__ctzsi2) (grub_uint32_t x);
#endif
+#ifdef HAVE___CLZDI2
+int
+EXPORT_FUNC (__clzdi2) (grub_uint64_t x);
+#endif
+
#ifdef HAVE___AEABI_UIDIV
grub_uint32_t
EXPORT_FUNC (__aeabi_uidiv) (grub_uint32_t a, grub_uint32_t b);
--
2.23.0
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] riscv64-emu: add __clzdi2 symbol
2019-09-19 7:39 ` [PATCH v2] " Andreas Schwab
@ 2019-09-19 9:58 ` Daniel Kiper
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Kiper @ 2019-09-19 9:58 UTC (permalink / raw)
To: Andreas Schwab; +Cc: agraf, eric.snowberg, grub-devel
On Thu, Sep 19, 2019 at 09:39:04AM +0200, Andreas Schwab wrote:
> This is needed for the zstd module.
>
> Signed-off-by: Andreas Schwab <schwab@suse.de>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Daniel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-09-19 9:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-09 12:34 [PATCH] riscv64-emu: add __clzdi2 symbol Andreas Schwab
2019-09-18 18:23 ` Daniel Kiper
2019-09-19 7:38 ` Andreas Schwab
2019-09-19 7:39 ` [PATCH v2] " Andreas Schwab
2019-09-19 9:58 ` Daniel Kiper
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.