All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@linux-m68k.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Greg Ungerer <gerg@uclinux.org>,
	Linux/m68k <linux-m68k@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/4] m68k: Wire up direct ipc calls
Date: Thu, 17 Sep 2015 17:39:59 +0200	[thread overview]
Message-ID: <mvmpp1hkqb4.fsf@hawking.suse.de> (raw)
In-Reply-To: <CAMuHMdW+An7Qa5Jt=JpHooy4Q9LopdKJWrpcJ0-0YsFi-i_FUQ@mail.gmail.com> (Geert Uytterhoeven's message of "Thu, 17 Sep 2015 17:18:53 +0200")

Geert Uytterhoeven <geert@linux-m68k.org> writes:

> Do we currently have architectures that use both sys_ipc and the direct
> syscalls, where keeping ipc_parse_version() in the direct syscalls is required?

IMHO it doesn't make sense to suport IPC_OLD via the direct syscalls,
even for those architectures that started with them in the first place.
There are quite a few architectures that define
ARCH_WANT_IPC_PARSE_VERSION even though they started life after IPC_64
was added.  They probably just forgot to adjust ipc/util.h back then.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

WARNING: multiple messages have this Message-ID (diff)
From: Andreas Schwab <schwab@linux-m68k.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Greg Ungerer <gerg@uclinux.org>,
	"Linux\/m68k" <linux-m68k@vger.kernel.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/4] m68k: Wire up direct ipc calls
Date: Thu, 17 Sep 2015 17:39:59 +0200	[thread overview]
Message-ID: <mvmpp1hkqb4.fsf@hawking.suse.de> (raw)
In-Reply-To: <CAMuHMdW+An7Qa5Jt=JpHooy4Q9LopdKJWrpcJ0-0YsFi-i_FUQ@mail.gmail.com> (Geert Uytterhoeven's message of "Thu, 17 Sep 2015 17:18:53 +0200")

Geert Uytterhoeven <geert@linux-m68k.org> writes:

> Do we currently have architectures that use both sys_ipc and the direct
> syscalls, where keeping ipc_parse_version() in the direct syscalls is required?

IMHO it doesn't make sense to suport IPC_OLD via the direct syscalls,
even for those architectures that started with them in the first place.
There are quite a few architectures that define
ARCH_WANT_IPC_PARSE_VERSION even though they started life after IPC_64
was added.  They probably just forgot to adjust ipc/util.h back then.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

  reply	other threads:[~2015-09-17 15:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-14  8:56 [PATCH v2 0/4] m68k: System call updates Geert Uytterhoeven
2015-09-14  8:56 ` [PATCH v2 1/4] m68k: Wire up direct socket calls Geert Uytterhoeven
2015-09-14  8:56   ` Geert Uytterhoeven
2015-09-14  8:56 ` [PATCH v2 2/4] m68k: Wire up userfaultfd Geert Uytterhoeven
2015-09-14  8:56   ` Geert Uytterhoeven
2015-09-14  8:56 ` [PATCH v2 3/4] m68k: Wire up direct ipc calls Geert Uytterhoeven
2015-09-17 14:34   ` Andreas Schwab
2015-09-17 14:34     ` Andreas Schwab
     [not found]     ` <CAMuHMdUncyXjxkS99SDTjx0-sU26jtCmFuHeU1=0DoqZL2AWvQ@mail.gmail.com>
     [not found]       ` <mvmvbb9krpd.fsf@hawking.suse.de>
2015-09-17 15:18         ` Geert Uytterhoeven
2015-09-17 15:39           ` Andreas Schwab [this message]
2015-09-17 15:39             ` Andreas Schwab
2015-09-14  8:56 ` Geert Uytterhoeven
2015-09-14 12:14   ` Greg Ungerer
2015-09-14 12:14     ` Greg Ungerer
2015-09-14  8:56 ` [PATCH v2 4/4] m68k: Wire up membarrier Geert Uytterhoeven
2015-09-14  8:56   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mvmpp1hkqb4.fsf@hawking.suse.de \
    --to=schwab@linux-m68k.org \
    --cc=geert@linux-m68k.org \
    --cc=gerg@uclinux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.