All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@suse.de>
To: Paul Walmsley <paul.walmsley@sifive.com>
Cc: linux-riscv@lists.infradead.org, paul@pwsan.com,
	palmer@sifive.com, linux-kernel@vger.kernel.org,
	aou@eecs.berkeley.edu
Subject: [PATCH] arch: riscv: fix logic error in parse_dtb
Date: Thu, 07 Feb 2019 15:44:26 +0100	[thread overview]
Message-ID: <mvmr2cjy7xx.fsf@suse.de> (raw)
In-Reply-To: <alpine.DEB.2.21.9999.1812171913510.29609@viisi.sifive.com> (Paul Walmsley's message of "Mon, 17 Dec 2018 19:15:12 -0800 (PST)")

The function early_init_dt_scan returns true if a DTB was detected.

Fixes: 8fd6e05c7463 ("arch: riscv: support kernel command line forcing when no DTB passed")
Signed-off-by: Andreas Schwab <schwab@suse.de>
---
 arch/riscv/kernel/setup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/riscv/kernel/setup.c b/arch/riscv/kernel/setup.c
index 45e9a2f053dc..84f19ca6d88b 100644
--- a/arch/riscv/kernel/setup.c
+++ b/arch/riscv/kernel/setup.c
@@ -140,7 +140,7 @@ asmlinkage void __init setup_vm(void)
 
 void __init parse_dtb(unsigned int hartid, void *dtb)
 {
-	if (!early_init_dt_scan(__va(dtb)))
+	if (early_init_dt_scan(__va(dtb)))
 		return;
 
 	pr_err("No DTB passed to the kernel\n");
-- 
2.20.1

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Andreas Schwab <schwab@suse.de>
To: Paul Walmsley <paul.walmsley@sifive.com>
Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	paul@pwsan.com, palmer@sifive.com, aou@eecs.berkeley.edu
Subject: [PATCH] arch: riscv: fix logic error in parse_dtb
Date: Thu, 07 Feb 2019 15:44:26 +0100	[thread overview]
Message-ID: <mvmr2cjy7xx.fsf@suse.de> (raw)
In-Reply-To: <alpine.DEB.2.21.9999.1812171913510.29609@viisi.sifive.com> (Paul Walmsley's message of "Mon, 17 Dec 2018 19:15:12 -0800 (PST)")

The function early_init_dt_scan returns true if a DTB was detected.

Fixes: 8fd6e05c7463 ("arch: riscv: support kernel command line forcing when no DTB passed")
Signed-off-by: Andreas Schwab <schwab@suse.de>
---
 arch/riscv/kernel/setup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/riscv/kernel/setup.c b/arch/riscv/kernel/setup.c
index 45e9a2f053dc..84f19ca6d88b 100644
--- a/arch/riscv/kernel/setup.c
+++ b/arch/riscv/kernel/setup.c
@@ -140,7 +140,7 @@ asmlinkage void __init setup_vm(void)
 
 void __init parse_dtb(unsigned int hartid, void *dtb)
 {
-	if (!early_init_dt_scan(__va(dtb)))
+	if (early_init_dt_scan(__va(dtb)))
 		return;
 
 	pr_err("No DTB passed to the kernel\n");
-- 
2.20.1

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

  parent reply	other threads:[~2019-02-07 14:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-18  3:15 [PATCH] arch: riscv: support kernel command line forcing when no DTB passed Paul Walmsley
2018-12-18  3:15 ` Paul Walmsley
2019-01-15 15:44 ` Christoph Hellwig
2019-01-15 15:44   ` Christoph Hellwig
2019-02-05 17:43 ` Andreas Schwab
2019-02-05 17:43   ` Andreas Schwab
2019-02-19 21:19   ` Paul Walmsley
2019-02-19 21:19     ` Paul Walmsley
2019-02-07 14:44 ` Andreas Schwab [this message]
2019-02-07 14:44   ` [PATCH] arch: riscv: fix logic error in parse_dtb Andreas Schwab
2019-02-07 22:47   ` Atish Patra
2019-02-07 22:47     ` Atish Patra
2019-02-19 21:20   ` Paul Walmsley
2019-02-19 21:20     ` Paul Walmsley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mvmr2cjy7xx.fsf@suse.de \
    --to=schwab@suse.de \
    --cc=aou@eecs.berkeley.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@sifive.com \
    --cc=paul.walmsley@sifive.com \
    --cc=paul@pwsan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.