* [PATCH] linux-user: fix TIOCGSID ioctl
@ 2026-02-10 9:20 Andreas Schwab
2026-02-10 15:17 ` Helge Deller
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Schwab @ 2026-02-10 9:20 UTC (permalink / raw)
To: Laurent Vivier; +Cc: Pierrick Bouvier, qemu-devel
TIOCGSID is IOC_R, not IOC_W.
Signed-off-by: Andreas Schwab <schwab@suse.de>
---
linux-user/ioctls.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/ioctls.h b/linux-user/ioctls.h
index 6ecfe6306e..5b7d00e92f 100644
--- a/linux-user/ioctls.h
+++ b/linux-user/ioctls.h
@@ -26,7 +26,7 @@
IOCTL(TIOCSCTTY, 0, TYPE_INT)
IOCTL(TIOCGPGRP, IOC_R, MK_PTR(TYPE_INT))
IOCTL(TIOCSPGRP, IOC_W, MK_PTR(TYPE_INT))
- IOCTL(TIOCGSID, IOC_W, MK_PTR(TYPE_INT))
+ IOCTL(TIOCGSID, IOC_R, MK_PTR(TYPE_INT))
IOCTL(TIOCOUTQ, IOC_R, MK_PTR(TYPE_INT))
IOCTL(TIOCSTI, IOC_W, MK_PTR(TYPE_INT))
IOCTL(TIOCMGET, IOC_R, MK_PTR(TYPE_INT))
--
2.53.0
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] linux-user: fix TIOCGSID ioctl
2026-02-10 9:20 [PATCH] linux-user: fix TIOCGSID ioctl Andreas Schwab
@ 2026-02-10 15:17 ` Helge Deller
0 siblings, 0 replies; 2+ messages in thread
From: Helge Deller @ 2026-02-10 15:17 UTC (permalink / raw)
To: Andreas Schwab, Laurent Vivier; +Cc: Pierrick Bouvier, qemu-devel
On 2/10/26 10:20, Andreas Schwab wrote:
> TIOCGSID is IOC_R, not IOC_W.
>
> Signed-off-by: Andreas Schwab <schwab@suse.de>
Reviewed-by: Helge Deller <deller@gmx.de>
Helge
> ---
> linux-user/ioctls.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/ioctls.h b/linux-user/ioctls.h
> index 6ecfe6306e..5b7d00e92f 100644
> --- a/linux-user/ioctls.h
> +++ b/linux-user/ioctls.h
> @@ -26,7 +26,7 @@
> IOCTL(TIOCSCTTY, 0, TYPE_INT)
> IOCTL(TIOCGPGRP, IOC_R, MK_PTR(TYPE_INT))
> IOCTL(TIOCSPGRP, IOC_W, MK_PTR(TYPE_INT))
> - IOCTL(TIOCGSID, IOC_W, MK_PTR(TYPE_INT))
> + IOCTL(TIOCGSID, IOC_R, MK_PTR(TYPE_INT))
> IOCTL(TIOCOUTQ, IOC_R, MK_PTR(TYPE_INT))
> IOCTL(TIOCSTI, IOC_W, MK_PTR(TYPE_INT))
> IOCTL(TIOCMGET, IOC_R, MK_PTR(TYPE_INT))
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-02-10 15:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-10 9:20 [PATCH] linux-user: fix TIOCGSID ioctl Andreas Schwab
2026-02-10 15:17 ` Helge Deller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.