All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@linux-m68k.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: vincent.chen@sifive.com, linux-riscv@lists.infradead.org,
	Palmer Dabbelt <palmer@sifive.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Paul Walmsley <paul.walmsley@sifive.com>
Subject: Re: [PATCH v2 2/2] riscv: Make __fstate_clean() work correctly.
Date: Wed, 11 Sep 2019 09:31:10 +0200	[thread overview]
Message-ID: <mvmtv9ji91d.fsf@linux-m68k.org> (raw)
In-Reply-To: <CAMuHMdX9tDqN4jMwMrUc-0zhYBo5gAHTbjwORCwB=3zVi6kvgQ@mail.gmail.com> (Geert Uytterhoeven's message of "Wed, 11 Sep 2019 09:22:43 +0200")

On Sep 11 2019, Geert Uytterhoeven <geert@linux-m68k.org> wrote:

> Hi Andreas,
>
> On Thu, Aug 15, 2019 at 12:37 AM Andreas Schwab <schwab@linux-m68k.org> wrote:
>> On Aug 14 2019, Palmer Dabbelt <palmer@sifive.com> wrote:
>> > On Wed, 14 Aug 2019 13:32:50 PDT (-0700), Paul Walmsley wrote:
>> >> On Wed, 14 Aug 2019, Vincent Chen wrote:
>> >>> Make the __fstate_clean() function correctly set the
>> >>> state of sstatus.FS in pt_regs to SR_FS_CLEAN.
>> >>>
>> >>> Fixes: 7db91e5 ("RISC-V: Task implementation")
>> >>> Cc: linux-stable <stable@vger.kernel.org>
>> >>> Signed-off-by: Vincent Chen <vincent.chen@sifive.com>
>> >>> Reviewed-by: Anup Patel <anup@brainfault.org>
>> >>> Reviewed-by: Christoph Hellwig <hch@lst.de>
>> >>
>> >> Thanks, I extended the "Fixes" commit ID to 12 digits, as is the usual
>> >> practice here, and have queued the following for v5.3-rc.
>> >
>> > For reference, something like "git config core.abbrev=12" (or whatever you
>> > write to get this in your .gitconfig)
>> >
>> >    https://github.com/palmer-dabbelt/home/blob/master/.gitconfig.in#L23
>> >
>> > causes git to do the right thing.
>>
>> Actually, the right setting is core.abbrev=auto (or leaving it unset).
>> It lets git chose the appropriate length depending on the repository
>> contents.  For the linux repository it will chose 13 right now.
>
> Does that depend on the git version?
> For me (git version 2.17.1), it still uses 12 when using the auto setting.

No, 12 is the correct number.  I was miscounting.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Andreas Schwab <schwab@linux-m68k.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Palmer Dabbelt <palmer@sifive.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	vincent.chen@sifive.com, linux-riscv@lists.infradead.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] riscv: Make __fstate_clean() work correctly.
Date: Wed, 11 Sep 2019 09:31:10 +0200	[thread overview]
Message-ID: <mvmtv9ji91d.fsf@linux-m68k.org> (raw)
In-Reply-To: <CAMuHMdX9tDqN4jMwMrUc-0zhYBo5gAHTbjwORCwB=3zVi6kvgQ@mail.gmail.com> (Geert Uytterhoeven's message of "Wed, 11 Sep 2019 09:22:43 +0200")

On Sep 11 2019, Geert Uytterhoeven <geert@linux-m68k.org> wrote:

> Hi Andreas,
>
> On Thu, Aug 15, 2019 at 12:37 AM Andreas Schwab <schwab@linux-m68k.org> wrote:
>> On Aug 14 2019, Palmer Dabbelt <palmer@sifive.com> wrote:
>> > On Wed, 14 Aug 2019 13:32:50 PDT (-0700), Paul Walmsley wrote:
>> >> On Wed, 14 Aug 2019, Vincent Chen wrote:
>> >>> Make the __fstate_clean() function correctly set the
>> >>> state of sstatus.FS in pt_regs to SR_FS_CLEAN.
>> >>>
>> >>> Fixes: 7db91e5 ("RISC-V: Task implementation")
>> >>> Cc: linux-stable <stable@vger.kernel.org>
>> >>> Signed-off-by: Vincent Chen <vincent.chen@sifive.com>
>> >>> Reviewed-by: Anup Patel <anup@brainfault.org>
>> >>> Reviewed-by: Christoph Hellwig <hch@lst.de>
>> >>
>> >> Thanks, I extended the "Fixes" commit ID to 12 digits, as is the usual
>> >> practice here, and have queued the following for v5.3-rc.
>> >
>> > For reference, something like "git config core.abbrev=12" (or whatever you
>> > write to get this in your .gitconfig)
>> >
>> >    https://github.com/palmer-dabbelt/home/blob/master/.gitconfig.in#L23
>> >
>> > causes git to do the right thing.
>>
>> Actually, the right setting is core.abbrev=auto (or leaving it unset).
>> It lets git chose the appropriate length depending on the repository
>> contents.  For the linux repository it will chose 13 right now.
>
> Does that depend on the git version?
> For me (git version 2.17.1), it still uses 12 when using the auto setting.

No, 12 is the correct number.  I was miscounting.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

  reply	other threads:[~2019-09-11  7:31 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-14  8:23 [PATCH v2 0/2] riscv: Correct the initialized flow of FP and __fstate_clean() Vincent Chen
2019-08-14  8:23 ` Vincent Chen
2019-08-14  8:23 ` [PATCH v2 1/2] riscv: Correct the initialized flow of FP register Vincent Chen
2019-08-14  8:23   ` Vincent Chen
2019-08-14 20:24   ` Paul Walmsley
2019-08-14 20:24     ` Paul Walmsley
2019-08-14  8:23 ` [PATCH v2 2/2] riscv: Make __fstate_clean() work correctly Vincent Chen
2019-08-14  8:23   ` Vincent Chen
2019-08-14 20:32   ` Paul Walmsley
2019-08-14 20:32     ` Paul Walmsley
2019-08-14 21:29     ` Palmer Dabbelt
2019-08-14 21:29       ` Palmer Dabbelt
2019-08-14 22:17       ` Andreas Schwab
2019-08-14 22:17         ` Andreas Schwab
2019-08-15  1:53         ` Palmer Dabbelt
2019-08-15  1:53           ` Palmer Dabbelt
2019-08-15  2:53         ` Vincent Chen
2019-08-15  2:53           ` Vincent Chen
2019-09-11  7:22         ` Geert Uytterhoeven
2019-09-11  7:22           ` Geert Uytterhoeven
2019-09-11  7:31           ` Andreas Schwab [this message]
2019-09-11  7:31             ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mvmtv9ji91d.fsf@linux-m68k.org \
    --to=schwab@linux-m68k.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@sifive.com \
    --cc=paul.walmsley@sifive.com \
    --cc=vincent.chen@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.