All of lore.kernel.org
 help / color / mirror / Atom feed
* 15/19
From: Joe Thornber @ 2002-12-16 10:16 UTC (permalink / raw)
  To: Joe Thornber; +Cc: Linus Torvalds, Kernel Mailing List
In-Reply-To: <20021216100457.GA7407@reti>

Remove some paranoia in highmem.c
--- diff/mm/highmem.c	2002-11-11 11:09:43.000000000 +0000
+++ source/mm/highmem.c	2002-12-16 09:41:30.000000000 +0000
@@ -452,8 +452,6 @@
 	mempool_t *pool;
 	int bio_gfp;
 
-	BUG_ON((*bio_orig)->bi_idx);
-
 	/*
 	 * for non-isa bounce case, just check if the bounce pfn is equal
 	 * to or bigger than the highest pfn in the system -- in that case,

^ permalink raw reply

* 14/19
From: Joe Thornber @ 2002-12-16 10:15 UTC (permalink / raw)
  To: Joe Thornber; +Cc: Linus Torvalds, Kernel Mailing List
In-Reply-To: <20021216100457.GA7407@reti>

Some fields in the duplicated bio weren't being set up properly in
__split_page(). [Kevin Corry]
--- diff/drivers/md/dm.c	2002-12-16 09:41:21.000000000 +0000
+++ source/drivers/md/dm.c	2002-12-16 09:41:25.000000000 +0000
@@ -337,7 +337,7 @@
 {
 	struct dm_target *ti = dm_table_find_target(ci->md->map, ci->sector);
 	struct bio *clone, *bio = ci->bio;
-	struct bio_vec *bv = bio->bi_io_vec + (bio->bi_vcnt - 1);
+	struct bio_vec *bv = bio->bi_io_vec + ci->idx;
 
 	DMWARN("splitting page");
 
@@ -349,11 +349,13 @@
 
 	clone->bi_sector = ci->sector;
 	clone->bi_bdev = bio->bi_bdev;
-	clone->bi_flags = bio->bi_flags | (1 << BIO_SEG_VALID);
 	clone->bi_rw = bio->bi_rw;
+	clone->bi_vcnt = 1;
 	clone->bi_size = len << SECTOR_SHIFT;
 	clone->bi_end_io = clone_endio;
 	clone->bi_private = ci->io;
+	clone->bi_io_vec->bv_offset = bv->bv_len - clone->bi_size;
+	clone->bi_io_vec->bv_len = clone->bi_size;
 
 	ci->sector += len;
 	ci->sector_count -= len;

^ permalink raw reply

* 13/19
From: Joe Thornber @ 2002-12-16 10:14 UTC (permalink / raw)
  To: Joe Thornber; +Cc: Linus Torvalds, Kernel Mailing List
In-Reply-To: <20021216100457.GA7407@reti>

md->pending was being incremented for each clone rather than just
once. [Kevin Corry]
--- diff/drivers/md/dm.c	2002-12-16 09:41:16.000000000 +0000
+++ source/drivers/md/dm.c	2002-12-16 09:41:21.000000000 +0000
@@ -310,7 +310,6 @@
 	 * anything, the target has assumed ownership of
 	 * this io.
 	 */
-	atomic_inc(&io->md->pending);
 	atomic_inc(&io->io_count);
 	r = ti->type->map(ti, clone);
 	if (r > 0)
@@ -424,6 +423,7 @@
 	ci.sector_count = bio_sectors(bio);
 	ci.idx = 0;
 
+	atomic_inc(&md->pending);
 	while (ci.sector_count)
 		__clone_and_map(&ci);
 

^ permalink raw reply

* Re: [linux-lvm] LVM is wont restore. DESPERATE. PLEASE HELP!
From: Heinz J . Mauelshagen @ 2002-12-16 10:08 UTC (permalink / raw)
  To: linux-lvm
In-Reply-To: <20021211053254.IDFV22279.mta06.mail.mel.aone.net.au@[127.0.0.1]>

Alex,

you may want to try uuid_fixer which i've send to you in direct mail.

Run "uuid_fixer YourPV1 YourPV2" and answer yes to the update question.

The run "vgscan; vgchange -ay".

Regards,
Heinz    -- The LVM Guy --

On Wed, Dec 11, 2002 at 04:32:54PM +1100, acpretty@ozemail.com.au wrote:
> Hey all, 
>   If someone is around who could help me it would be SO appreciated. 
> 
> I have a volume group (vg00) with two physical volumes in it.     
> 
> with in about half an hour .....
>    I extended one of the logical volumes, no probs
>    I extended the file system, noprobs 
>    was doing a large-ish transfer to my enlarged fs when the machine crashed...
> 
> upon restarting the machine told me I had inconsistencies in my PV's so I did a vgcfgrestore. Now upon restarting I get no acknowledgement of the volume group at all....
> 
> SO! I thought I'd try and force a vgimport of the volume group only to find that vgimport says that the two PV's in the VG are not from the same VG. 
> 
> now I'm a bit lost, if anyone could help, PLEASE!!!! I have one last thing I think I should try but I'm uncertain. 
> 
> When I run pvdata the bit at the bottom says:
> 
>   --- List of physical volume UUIDs ---
> 
>   001: EtJbdT-qZBP-P6Bf-yRwi-I4Bn-0qzS-L13XYu
>   002: --- EMPTY ---
> 
> shouldn't each PV know about all the other PV's UUID's in this list and therefore can anyone tell me if using the UUID fixer program is the thing to do?
> 
> more importantly can anyone tell me how much of the partitions I need to dd in order to preserve the meta data in case this doesn't help
> 
> Thanks reading this far and thanks in advance to the help
> Alex
> 
> This message was sent through MyMail http://www.mymail.com.au
> 
> 
> 
> _______________________________________________
> linux-lvm mailing list
> linux-lvm@sistina.com
> http://lists.sistina.com/mailman/listinfo/linux-lvm
> read the LVM HOW-TO at http://tldp.org/HOWTO/LVM-HOWTO/

*** Software bugs are stupid.
    Nevertheless it needs not so stupid people to solve them ***

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

Heinz Mauelshagen                                 Sistina Software Inc.
Senior Consultant/Developer                       Am Sonnenhang 11
                                                  56242 Marienrachdorf
                                                  Germany
Mauelshagen@Sistina.com                           +49 2626 141200
                                                       FAX 924446
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

^ permalink raw reply

* 12/19
From: Joe Thornber @ 2002-12-16 10:14 UTC (permalink / raw)
  To: Joe Thornber; +Cc: Linus Torvalds, Kernel Mailing List
In-Reply-To: <20021216100457.GA7407@reti>

dec_pending(): only bother spin locking if io->error is going to be
updated. [Kevin Corry]
--- diff/drivers/md/dm.c	2002-12-16 09:41:12.000000000 +0000
+++ source/drivers/md/dm.c	2002-12-16 09:41:16.000000000 +0000
@@ -238,10 +238,11 @@
 	static spinlock_t _uptodate_lock = SPIN_LOCK_UNLOCKED;
 	unsigned long flags;
 
-	spin_lock_irqsave(&_uptodate_lock, flags);
-	if (error)
+	if (error) {
+		spin_lock_irqsave(&_uptodate_lock, flags);
 		io->error = error;
-	spin_unlock_irqrestore(&_uptodate_lock, flags);
+		spin_unlock_irqrestore(&_uptodate_lock, flags);
+	}
 
 	if (atomic_dec_and_test(&io->io_count)) {
 		if (atomic_dec_and_test(&io->md->pending))

^ permalink raw reply

* 11/19
From: Joe Thornber @ 2002-12-16 10:13 UTC (permalink / raw)
  To: Joe Thornber; +Cc: Linus Torvalds, Kernel Mailing List
In-Reply-To: <20021216100457.GA7407@reti>

Add a blk_run_queues() call to encourage pending io to flush
when we're doing a dm_suspend().
--- diff/drivers/md/dm.c	2002-12-16 09:41:08.000000000 +0000
+++ source/drivers/md/dm.c	2002-12-16 09:41:12.000000000 +0000
@@ -722,6 +722,7 @@
 	 * Then we wait for the already mapped ios to
 	 * complete.
 	 */
+	blk_run_queues();
 	while (1) {
 		set_current_state(TASK_INTERRUPTIBLE);
 

^ permalink raw reply

* Re: usb audio + mandrake 9.0 foobar :(
From: Thierry Vignaud @ 2002-12-16 10:06 UTC (permalink / raw)
  To: m; +Cc: alsa-devel, linux-audio-user
In-Reply-To: <3DFA4539.7050207@iriXx.org>

iriXx <m@iriXx.org> writes:

> just upgraded mandrake from 8.2 to 9.0....
> and found out that it seems to have made my alsa all foobar.... :(
> 
> i recompiled and reinstalled alsa 0.9.rc5 after upgrading... but i
> dont seem to be able to get it working.
> im running a quattro usb audio unit... modprobe snd-usb-audio,
> snd-pcm-oss, snd-mixer-oss, snd-seq-oss all goes fine... but on
> opening any sound or DVD apps i get error messages that there is no
> sound support / no sound device found....

note that usb audio devices default[1] to usb's audio.o module, as
lspcidrake -v should reports you.

classic bug sound tester (you need the ldetect, chkconfig, aumix and
psmisc packages):

"lspcidrake -v | fgrep AUDIO" will tell you which driver your card use
by default

"grep snd-slot /etc/modules.conf" will tell you what driver it
currently uses

"/sbin/lsmod" will enable you to check if its module (driver) is
loaded or not

"/sbin/chkconfig --list sound" and "/sbin/chkconfig --list alsa" will
tell you if sound and alsa services're configured to be run on
initlevel 3

"aumix -q" will tell you if the sound volume is muted or not

"/sbin/fuser -v /dev/dsp" will tell which program uses the sound card.

 
> anyone got any ideas what may have happened?... is there a problem with
> the supplied kernel perhaps ? it appears to be 2.4.19-16mdk

mdk9.0 came with alsa-0.9.0-rc2.
note than snd-usb-audio code did move a lot between the various alsa
rc.



[1] device-module association[2] being made in
    /usr/share/ldetect-lst/usbtable)

[2] you can alter it through the draksound tool



-------------------------------------------------------
This sf.net email is sponsored by:
With Great Power, Comes Great Responsibility 
Learn to use your power at OSDN's High Performance Computing Channel
http://hpc.devchannel.org/

^ permalink raw reply

* Re: how to launch downloaded files?
From: Arno Seitzinger @ 2002-12-16 10:05 UTC (permalink / raw)
  To: linux-newbie
In-Reply-To: <atk7jc$umb$1@main.gmane.org>

Arno Seitzinger wrote:

[stuff about chmod] 

> Have a look at 'man chmod'
> You can use it like 'chmod o+x yourfile' which will change permission to
> executeable for the owner of the file.

For the owner, it has to be u+x, of course...

Arno


-
To unsubscribe from this list: send the line "unsubscribe linux-newbie" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.linux-learn.org/faqs

^ permalink raw reply

* 10/19
From: Joe Thornber @ 2002-12-16 10:12 UTC (permalink / raw)
  To: Joe Thornber; +Cc: Linus Torvalds, Kernel Mailing List
In-Reply-To: <20021216100457.GA7407@reti>

dm_suspend(): Stop holding the read lock around the while loop that
waits for pending io to complete.
--- diff/drivers/md/dm.c	2002-12-16 09:41:03.000000000 +0000
+++ source/drivers/md/dm.c	2002-12-16 09:41:08.000000000 +0000
@@ -715,15 +715,13 @@
 	}
 
 	set_bit(DMF_BLOCK_IO, &md->flags);
+	add_wait_queue(&md->wait, &wait);
 	up_write(&md->lock);
 
 	/*
 	 * Then we wait for the already mapped ios to
 	 * complete.
 	 */
-	down_read(&md->lock);
-
-	add_wait_queue(&md->wait, &wait);
 	while (1) {
 		set_current_state(TASK_INTERRUPTIBLE);
 
@@ -734,11 +732,11 @@
 	}
 
 	current->state = TASK_RUNNING;
-	remove_wait_queue(&md->wait, &wait);
-	up_read(&md->lock);
 
-	/* set_bit is atomic */
+	down_write(&md->lock);
+	remove_wait_queue(&md->wait, &wait);
 	set_bit(DMF_SUSPENDED, &md->flags);
+	up_write(&md->lock);
 
 	return 0;
 }

^ permalink raw reply

* 8/19
From: Joe Thornber @ 2002-12-16 10:11 UTC (permalink / raw)
  To: Joe Thornber; +Cc: Linus Torvalds, Kernel Mailing List
In-Reply-To: <20021216100457.GA7407@reti>

Give each device its own io mempool to avoid a potential
deadlock with stacked devices.  [HM + EJT]
--- diff/drivers/md/dm.c	2002-12-16 09:40:44.000000000 +0000
+++ source/drivers/md/dm.c	2002-12-16 09:40:58.000000000 +0000
@@ -58,11 +58,15 @@
 	 * The current mapping.
 	 */
 	struct dm_table *map;
+
+	/*
+	 * io objects are allocated from here.
+	 */
+	mempool_t *io_pool;
 };
 
 #define MIN_IOS 256
 static kmem_cache_t *_io_cache;
-static mempool_t *_io_pool;
 
 static __init int local_init(void)
 {
@@ -74,18 +78,10 @@
 	if (!_io_cache)
 		return -ENOMEM;
 
-	_io_pool = mempool_create(MIN_IOS, mempool_alloc_slab,
-				  mempool_free_slab, _io_cache);
-	if (!_io_pool) {
-		kmem_cache_destroy(_io_cache);
-		return -ENOMEM;
-	}
-
 	_major = major;
 	r = register_blkdev(_major, _name, &dm_blk_dops);
 	if (r < 0) {
 		DMERR("register_blkdev failed");
-		mempool_destroy(_io_pool);
 		kmem_cache_destroy(_io_cache);
 		return r;
 	}
@@ -98,7 +94,6 @@
 
 static void local_exit(void)
 {
-	mempool_destroy(_io_pool);
 	kmem_cache_destroy(_io_cache);
 
 	if (unregister_blkdev(_major, _name) < 0)
@@ -178,14 +173,14 @@
 	return 0;
 }
 
-static inline struct dm_io *alloc_io(void)
+static inline struct dm_io *alloc_io(struct mapped_device *md)
 {
-	return mempool_alloc(_io_pool, GFP_NOIO);
+	return mempool_alloc(md->io_pool, GFP_NOIO);
 }
 
-static inline void free_io(struct dm_io *io)
+static inline void free_io(struct mapped_device *md, struct dm_io *io)
 {
-	mempool_free(io, _io_pool);
+	mempool_free(io, md->io_pool);
 }
 
 static inline struct deferred_io *alloc_deferred(void)
@@ -254,7 +249,7 @@
 			wake_up(&io->md->wait);
 
 		bio_endio(io->bio, io->error ? 0 : io->bio->bi_size, io->error);
-		free_io(io);
+		free_io(io->md, io);
 	}
 }
 
@@ -419,7 +414,7 @@
 
 	ci.md = md;
 	ci.bio = bio;
-	ci.io = alloc_io();
+	ci.io = alloc_io(md);
 	ci.io->error = 0;
 	atomic_set(&ci.io->io_count, 1);
 	ci.io->bio = bio;
@@ -558,8 +553,17 @@
 	md->queue.queuedata = md;
 	blk_queue_make_request(&md->queue, dm_request);
 
+	md->io_pool = mempool_create(MIN_IOS, mempool_alloc_slab,
+				     mempool_free_slab, _io_cache);
+	if (!md->io_pool) {
+		free_minor(md->disk->first_minor);
+		kfree(md);
+		return NULL;
+	}
+
 	md->disk = alloc_disk(1);
 	if (!md->disk) {
+		mempool_destroy(md->io_pool);
 		free_minor(md->disk->first_minor);
 		kfree(md);
 		return NULL;
@@ -581,6 +585,7 @@
 static void free_dev(struct mapped_device *md)
 {
 	free_minor(md->disk->first_minor);
+	mempool_destroy(md->io_pool);
 	del_gendisk(md->disk);
 	put_disk(md->disk);
 	kfree(md);

^ permalink raw reply

* 9/19
From: Joe Thornber @ 2002-12-16 10:11 UTC (permalink / raw)
  To: Joe Thornber; +Cc: Linus Torvalds, Kernel Mailing List
In-Reply-To: <20021216100457.GA7407@reti>

queue_io() was checking the DMF_SUSPENDED flag rather than the new
DMF_BLOCK_IO flag.  This meant suspend could deadlock under load.
--- diff/drivers/md/dm.c	2002-12-16 09:40:58.000000000 +0000
+++ source/drivers/md/dm.c	2002-12-16 09:41:03.000000000 +0000
@@ -206,7 +206,7 @@
 
 	down_write(&md->lock);
 
-	if (!test_bit(DMF_SUSPENDED, &md->flags)) {
+	if (!test_bit(DMF_BLOCK_IO, &md->flags)) {
 		up_write(&md->lock);
 		free_deferred(di);
 		return 1;

^ permalink raw reply

* Re: how to launch downloaded files?
From: Arno Seitzinger @ 2002-12-16 10:04 UTC (permalink / raw)
  To: linux-newbie
In-Reply-To: <3DFBEA9E.9000704@look.ca>

R. Bal wrote:

> Hi All,
> 
> I'm a day old Linux user, and am loving the system performance.
> Everthing is great, except that I can't seem to get the files I download
> off the net to "execute".  I know where the files are being saved.  How
> do I "run" them?  I have a Netscape installer, but can't seem to get it
> working.
> 
> Any suggestions?  I'm running Red Hat 8.0.
> 
> RB.


One thing you should keep in mind is that you may have to change the file 
attribute to executeable _if_ you downloaded an executeable file.

Have a look at 'man chmod'
You can use it like 'chmod u+x yourfile' which will change permission to 
executeable for the owner of the file.

HTH

Arno


-
To unsubscribe from this list: send the line "unsubscribe linux-newbie" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.linux-learn.org/faqs



-
To unsubscribe from this list: send the line "unsubscribe linux-newbie" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.linux-learn.org/faqs

^ permalink raw reply

* 7/19
From: Joe Thornber @ 2002-12-16 10:10 UTC (permalink / raw)
  To: Joe Thornber; +Cc: Linus Torvalds, Kernel Mailing List
In-Reply-To: <20021216100457.GA7407@reti>

There's a bug in the dm-stripe.c constructor failing top check if enough
destinations are handed in. [Heinz Mauelshagen]
--- diff/drivers/md/dm-stripe.c	2002-12-16 09:40:48.000000000 +0000
+++ source/drivers/md/dm-stripe.c	2002-12-16 09:40:53.000000000 +0000
@@ -131,6 +131,15 @@
 		return -EINVAL;
 	}
 
+	/*
+	 * Do we have enough arguments for that many stripes ?
+	 */
+	if (argc != (2 + 2 * stripes)) {
+		ti->error = "dm-stripe: Not enough destinations "
+			"specified";
+		return -EINVAL;
+	}
+
 	sc = alloc_context(stripes);
 	if (!sc) {
 		ti->error = "dm-stripe: Memory allocation for striped context "
@@ -151,13 +160,6 @@
 	 * Get the stripe destinations.
 	 */
 	for (i = 0; i < stripes; i++) {
-		if (argc < 2) {
-			ti->error = "dm-stripe: Not enough destinations "
-				"specified";
-			kfree(sc);
-			return -EINVAL;
-		}
-
 		argv += 2;
 
 		r = get_stripe(ti, sc, i, argv);

^ permalink raw reply

* 6/19
From: Joe Thornber @ 2002-12-16 10:09 UTC (permalink / raw)
  To: Joe Thornber; +Cc: Linus Torvalds, Kernel Mailing List
In-Reply-To: <20021216100457.GA7407@reti>

minor change for dm-stripe.c. Tests for correct chunksize before it allocates
the stripe context. [Heinz Mauelshagen]

--- diff/drivers/md/dm-stripe.c	2002-11-18 10:11:54.000000000 +0000
+++ source/drivers/md/dm-stripe.c	2002-12-16 09:40:48.000000000 +0000
@@ -117,6 +117,14 @@
 		return -EINVAL;
 	}
 
+	/*
+	 * chunk_size is a power of two
+	 */
+	if (!chunk_size || (chunk_size & (chunk_size - 1))) {
+		ti->error = "dm-stripe: Invalid chunk size";
+		return -EINVAL;
+	}
+
 	if (!multiple(ti->len, stripes, &width)) {
 		ti->error = "dm-stripe: Target length not divisable by "
 		    "number of stripes";
@@ -134,15 +142,6 @@
 	sc->stripe_width = width;
 	ti->split_io = chunk_size;
 
-	/*
-	 * chunk_size is a power of two
-	 */
-	if (!chunk_size || (chunk_size & (chunk_size - 1))) {
-		ti->error = "dm-stripe: Invalid chunk size";
-		kfree(sc);
-		return -EINVAL;
-	}
-
 	sc->chunk_mask = ((sector_t) chunk_size) - 1;
 	for (sc->chunk_shift = 0; chunk_size; sc->chunk_shift++)
 		chunk_size >>= 1;

^ permalink raw reply

* Re: [linux-lvm] vgcreate on md: vgcreate -- ERROR "pv_read(): read" reading physical volumes
From: Heinz J . Mauelshagen @ 2002-12-16 10:03 UTC (permalink / raw)
  To: linux-lvm
In-Reply-To: <20021212162759.36500.qmail@web40710.mail.yahoo.com>

On Thu, Dec 12, 2002 at 08:27:59AM -0800, udo wrote:
> Hello,
> 
> --- John DeFranco <defranco@cup.hp.com> wrote:
> > Did you pvcreate the /dev/md2 first? Didn't indicate
> > that below.
> 
> I didn't write that but I did, following the howto
> from http://tldp.org/HOWTO/LVM-HOWTO.
> I couldn't solve the problem so I started a wipe of
> /dev/md2 to be sure the disk was clear. (this took
> quite some time on this slow machine)
> I had to wait for that to finish so I could reboot to
> single user (init=/bin/sh) again.
> Then things worked!
> Pfew...... ;-)

A "dd if=/dev/zero of=/dev/md2 bs=1k count=1" could have done it as well :)

> 
> Thanks,
> Udo
> 
> __________________________________________________
> Do you Yahoo!?
> Yahoo! Mail Plus - Powerful. Affordable. Sign up now.
> http://mailplus.yahoo.com
> 
> _______________________________________________
> linux-lvm mailing list
> linux-lvm@sistina.com
> http://lists.sistina.com/mailman/listinfo/linux-lvm
> read the LVM HOW-TO at http://tldp.org/HOWTO/LVM-HOWTO/

-- 

Regards,
Heinz    -- The LVM Guy --

*** Software bugs are stupid.
    Nevertheless it needs not so stupid people to solve them ***

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

Heinz Mauelshagen                                 Sistina Software Inc.
Senior Consultant/Developer                       Am Sonnenhang 11
                                                  56242 Marienrachdorf
                                                  Germany
Mauelshagen@Sistina.com                           +49 2626 141200
                                                       FAX 924446
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

^ permalink raw reply

* 4/19
From: Joe Thornber @ 2002-12-16 10:08 UTC (permalink / raw)
  To: Joe Thornber; +Cc: Linus Torvalds, Kernel Mailing List
In-Reply-To: <20021216100457.GA7407@reti>

No need to validate the parameters if we are doing a
REMOVE_ALL command.
--- diff/drivers/md/dm-ioctl.c	2002-12-11 11:50:25.000000000 +0000
+++ source/drivers/md/dm-ioctl.c	2002-12-16 09:40:39.000000000 +0000
@@ -986,6 +986,10 @@
 
 static int validate_params(uint cmd, struct dm_ioctl *param)
 {
+	/* Ignores parameters */
+	if (cmd == DM_REMOVE_ALL_CMD)
+		return 0;
+
 	/* Unless creating, either name of uuid but not both */
 	if (cmd != DM_DEV_CREATE_CMD) {
 		if ((!*param->uuid && !*param->name) ||

^ permalink raw reply

* 5/19
From: Joe Thornber @ 2002-12-16 10:09 UTC (permalink / raw)
  To: Joe Thornber; +Cc: Linus Torvalds, Kernel Mailing List
In-Reply-To: <20021216100457.GA7407@reti>

check_device_area was comparing the bytes with sectors.
[Stefan Lauterbach]
--- diff/drivers/md/dm-table.c	2002-12-16 09:40:34.000000000 +0000
+++ source/drivers/md/dm-table.c	2002-12-16 09:40:44.000000000 +0000
@@ -388,7 +388,7 @@
 static int check_device_area(struct dm_dev *dd, sector_t start, sector_t len)
 {
 	sector_t dev_size;
-	dev_size = dd->bdev->bd_inode->i_size;
+	dev_size = dd->bdev->bd_inode->i_size >> SECTOR_SHIFT;
 	return ((start < dev_size) && (len <= (dev_size - start)));
 }
 
--- diff/drivers/md/dm.c	2002-11-28 11:30:39.000000000 +0000
+++ source/drivers/md/dm.c	2002-12-16 09:40:44.000000000 +0000
@@ -16,7 +16,6 @@
 
 static const char *_name = DM_NAME;
 #define MAX_DEVICES (1 << KDEV_MINOR_BITS)
-#define SECTOR_SHIFT 9
 
 static int major = 0;
 static int _major = 0;
--- diff/drivers/md/dm.h	2002-11-18 10:11:54.000000000 +0000
+++ source/drivers/md/dm.h	2002-12-16 09:40:44.000000000 +0000
@@ -29,6 +29,8 @@
 #define SECTOR_FORMAT "%lu"
 #endif
 
+#define SECTOR_SHIFT 9
+
 extern struct block_device_operations dm_blk_dops;
 
 /*

^ permalink raw reply

* 3/19
From: Joe Thornber @ 2002-12-16 10:07 UTC (permalink / raw)
  To: Joe Thornber; +Cc: Linus Torvalds, Kernel Mailing List
In-Reply-To: <20021216100457.GA7407@reti>

Return -ENOTBLK if lookup_device() finds the inode, but it
is not a block device. [Cristoph Hellwig]

--- diff/drivers/md/dm-table.c	2002-12-16 09:40:30.000000000 +0000
+++ source/drivers/md/dm-table.c	2002-12-16 09:40:34.000000000 +0000
@@ -312,7 +312,7 @@
 	}
 
 	if (!S_ISBLK(inode->i_mode)) {
-		r = -EINVAL;
+		r = -ENOTBLK;
 		goto out;
 	}
 

^ permalink raw reply

* 2/19
From: Joe Thornber @ 2002-12-16 10:06 UTC (permalink / raw)
  To: Joe Thornber; +Cc: Linus Torvalds, Kernel Mailing List
In-Reply-To: <20021216100457.GA7407@reti>

An error value was not being checked correctly in open_dev().
[Kevin Corry]
--- diff/drivers/md/dm-table.c	2002-11-28 11:30:39.000000000 +0000
+++ source/drivers/md/dm-table.c	2002-12-16 09:40:30.000000000 +0000
@@ -356,7 +356,7 @@
 		return -ENOMEM;
 
 	r = blkdev_get(d->bdev, d->mode, 0, BDEV_RAW);
-	if (!r)
+	if (r)
 		return r;
 
 	r = bd_claim(d->bdev, _claim_ptr);

^ permalink raw reply

* Re: Intel sez: Synchronous Flash and XIP is the future -- thought s?
From: David Woodhouse @ 2002-12-16 10:30 UTC (permalink / raw)
  To: Paul Nash; +Cc: Wolfgang Denk, Linux-MTD (E-mail)
In-Reply-To: <43CB1396676FD4119F03001083FD299401A1C8D5@neptune.kirkland.local>

paulnash@wildseed.com said:
> Actually, Intel's L18/L30 series of "wireless flash" has that feature,
> Read-while-erase-or-write as long as the reads are not to the 8MBit
> partition being dealt with in an erase or write.

1MiB is slightly saner but still not wonderful. At least I suppose it would 
allow you to have your kernel in the first MiB and hence not affected by 
changes to the file system. Doing it at an erase-block granularity would be 
better.

--
dwmw2

^ permalink raw reply

* Q: i845MP/P4-M laptop support? (specific problems listed)
From: Simon Oosthoek @ 2002-12-16 10:06 UTC (permalink / raw)
  To: linux-kernel

Hi all

I've been following kernel-traffic and sometimes the web-archives in search
for some clues about support for my laptop (jewel jade 8060, specs(in dutch):
URL:http://www.jewelnotebooks.nl/index.php?page=jade-8060)

I've noticed some problems and I've seen some proposals for patches and
fixes, but I don't have a clear picture of which is fixed and by which
patch...

The problems I have seen:
- apm doesn't seem to work 
  output: 
  APM BIOS 1.2 (kernel driver 1.16)
  AC on-line, no system battery
  
  Q: will the ACPI patches help with this?

- the -ac2 patch wasn't able to boot at all (no messages), but I haven't
tried it more than once... the intel speedstep feature would be nice to have
though...

- resource collision on PCI 00:1f.1?
  bootmessages: PCI: Device 00:1f.1 not available because of resource collisions

  Q: any fixes available for this?

- missing driver for smartmedia slot
  (I guess this is a feature request, if it's not available)
from "lspci -v":
02:06.0 System peripheral: Toshiba America Info Systems: Unknown device 0804
(rev 02)
        Subsystem: COMPAL Electronics Inc: Unknown device 0012
        Flags: slow devsel, IRQ 11
        Memory at e0000c00 (32-bit, non-prefetchable) [disabled] [size=32]
        Capabilities: <available only to root>


Otherwise I'm quite satisfied with linux on the laptop...

BTW, I'm not on the list, but I do sometimes parse the archives and
kernel-traffic. If anyone wants more details or if there's something I can
do to gather more information, please cc me or ask directly...

Cheers

Simon

-----
excerpt from the boot messages:

Kernel command line: BOOT_IMAGE=2420 ro root=301 devfs=mount pci=biosirq
No local APIC present or hardware disabled
...
apm: BIOS version 1.2 Flags 0x03 (Driver version 1.16)
Starting kswapd
Journalled Block Device driver loaded
ACPI: APM is already active, exiting
vesafb: framebuffer at 0xf0000000, mapped to 0xd0800000, size 32768k
vesafb: mode is 1024x768x32, linelength=4096, pages=1
vesafb: protected mode interface info at c000:e780
vesafb: scrolling: redraw
vesafb: directcolor: size=8:8:8:8, shift=24:16:8:0
Console: switching to colour frame buffer device 128x48
fb0: VESA VGA frame buffer device
pty: 256 Unix98 ptys configured
Serial driver version 5.05c (2001-07-08) with MANY_PORTS SHARE_IRQ
SERIAL_PCI enabled
ttyS01 at 0x02f8 (irq = 3) is a 16550A
PCI: Found IRQ 10 for device 00:1f.6
PCI: Sharing IRQ 10 with 00:1f.3
PCI: Sharing IRQ 10 with 00:1f.5
Uniform Multi-Platform E-IDE driver Revision: 6.31
ide: Assuming 33MHz system bus speed for PIO modes; override with idebus=xx
ICH3M: IDE controller on PCI bus 00 dev f9
PCI: Device 00:1f.1 not available because of resource collisions
PCI: Assigned IRQ 11 for device 00:1f.1
ICH3M: BIOS setup was incomplete.

(note: this is all before the nvidia driver is loaded into the kernel,
making it tainted...)

^ permalink raw reply

* Re: errors in symlinks in alsa-oss rc1 with mandrake 9.0
From: Thierry Vignaud @ 2002-12-16  9:58 UTC (permalink / raw)
  To: m; +Cc: alsa-devel
In-Reply-To: <3DFCBF9A.2090108@iriXx.org>

iriXx <m@iriXx.org> writes:

> just a note to say i had to modify the symlinks to 'missing',
> 'mkinstalldirs' and 'install-sh' to get alsa-oss-0.9.0rc1 to install
> under mandrake 9.0.

alsa-oss just build fine, look at myt libalsa-oss0 package in mandrake
contribs.

> it seems that from 9.0 mandrake puts automake in
> /usr/share/automake-1.4 rather than /usr/share/automake.

mdk9.0 come with both automake-1.4 and automake-1.6 since some
packages need the latter and some other the first one.

there's nothing wrong in having versionnated directories such as
/usr/share/automake.

there's nothing enforcing having /usr/share/automake.

only automake should access such files.

> i dont know if anyone wants to add a detection for this to the
> config script?

you should not have to rely on automake macros being in
/usr/share/automake and i failled to see where such  assumption is
made in alsa-oss build system in cvs.

so there's no point in such script.

if some tarball of some with a pre build configure and the like, and
if some links're broken, aclocal, libtoolize, automake and autoconf
are your friends to fix them.

anyway, generating them from cvs does works on any system having
automake & autoconf.



-------------------------------------------------------
This sf.net email is sponsored by:
With Great Power, Comes Great Responsibility 
Learn to use your power at OSDN's High Performance Computing Channel
http://hpc.devchannel.org/

^ permalink raw reply

* 1/19
From: Joe Thornber @ 2002-12-16 10:06 UTC (permalink / raw)
  To: Joe Thornber; +Cc: Linus Torvalds, Kernel Mailing List
In-Reply-To: <20021216100457.GA7407@reti>

Four constants:
   DM_DIR,
   DM_MAX_TYPE_NAME,
   DM_NAME_LEN,
   DM_UUID_LEN

Were being declared in device-mapper.h, these are all specific to 
the ioctl interface, so they've been moved to dm-ioctl.h.  Nobody
in userland should ever include <linux/device-mapper.h> so remove 
ifdef __KERNEL guards.
--- diff/include/linux/device-mapper.h	2002-11-11 11:09:38.000000000 +0000
+++ source/include/linux/device-mapper.h	2002-12-16 09:40:25.000000000 +0000
@@ -7,13 +7,6 @@
 #ifndef _LINUX_DEVICE_MAPPER_H
 #define _LINUX_DEVICE_MAPPER_H
 
-#define DM_DIR "mapper"	/* Slashes not supported */
-#define DM_MAX_TYPE_NAME 16
-#define DM_NAME_LEN 128
-#define DM_UUID_LEN 129
-
-#ifdef __KERNEL__
-
 struct dm_target;
 struct dm_table;
 struct dm_dev;
@@ -101,6 +94,4 @@
 int dm_register_target(struct target_type *t);
 int dm_unregister_target(struct target_type *t);
 
-#endif				/* __KERNEL__ */
-
 #endif				/* _LINUX_DEVICE_MAPPER_H */
--- diff/include/linux/dm-ioctl.h	2002-11-11 11:09:38.000000000 +0000
+++ source/include/linux/dm-ioctl.h	2002-12-16 09:40:25.000000000 +0000
@@ -7,9 +7,13 @@
 #ifndef _LINUX_DM_IOCTL_H
 #define _LINUX_DM_IOCTL_H
 
-#include <linux/device-mapper.h>
 #include <linux/types.h>
 
+#define DM_DIR "mapper"	/* Slashes not supported */
+#define DM_MAX_TYPE_NAME 16
+#define DM_NAME_LEN 128
+#define DM_UUID_LEN 129
+
 /*
  * Implements a traditional ioctl interface to the device mapper.
  */

^ permalink raw reply

* Re: [linux-lvm] lvm-problems. vgda inconsistency
From: Heinz J . Mauelshagen @ 2002-12-16  9:58 UTC (permalink / raw)
  To: linux-lvm
In-Reply-To: <200212160923.58295.lists@franzke-online.de>

On Mon, Dec 16, 2002 at 09:23:58AM +0100, Dieter Franzke wrote:
> Hi,
> 
> I've created a pv, vg and lv
> via pvcreate, vgcreate and lvcreate.
> Everything went well.
> But when I tried to  initialize a filesystem via mkfs.xfs I get following 
> error:
> 
> VGDA in Kernel and lvmtab are NOT consistent; please run vgscan
> 
> When I run vgscan nothing is changed.
> How can I fix this without rebooting?

Rebooting won't help this. vgscan _reads_ the LVM metadata on the PVs
and tries to update the working copies of the metadata in /etc/lvmtab*.
No change to the metadata on the PVs happens during a vgscan run.

Does vgscan display any error?
What does vgck display?

vgck should check the ondisk metadata fine or we need to restore it
from archive copies in /etc/lvmconf/ (please save those!)

> 
> any hints?
> 
> ciao
> 
> dieter
> 
> -- 
> registered linuxuser 199810
> it's time to close windows....
> 
> 
> _______________________________________________
> linux-lvm mailing list
> linux-lvm@sistina.com
> http://lists.sistina.com/mailman/listinfo/linux-lvm
> read the LVM HOW-TO at http://tldp.org/HOWTO/LVM-HOWTO/

-- 

Regards,
Heinz    -- The LVM Guy --

*** Software bugs are stupid.
    Nevertheless it needs not so stupid people to solve them ***

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

Heinz Mauelshagen                                 Sistina Software Inc.
Senior Consultant/Developer                       Am Sonnenhang 11
                                                  56242 Marienrachdorf
                                                  Germany
Mauelshagen@Sistina.com                           +49 2626 141200
                                                       FAX 924446
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

^ permalink raw reply

* Re: [PATCH] dm.c  -  device-mapper I/O path fixes
From: Joe Thornber @ 2002-12-16 10:04 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Joe Thornber, Kernel Mailing List
In-Reply-To: <Pine.LNX.4.44.0212151649180.2445-100000@home.transmeta.com>

Linus,

On Sun, Dec 15, 2002 at 04:50:16PM -0800, Linus Torvalds wrote:
> 
> Guys, can you please re-send the split-up version of these patches, I'm
> currently ignoring them simply because I don't know what the end result of
> the discussion really ended up being..

Here is the latest dm patchset (2.5.51-dm-3) that people have been
testing successfully over the weekend.  Please apply.

- Joe

^ permalink raw reply


This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.