* [U-Boot] [PATCH 2/5] net: ns9750: drop !NET_MULTI driver
From: Wolfgang Denk @ 2011-10-23 21:03 UTC (permalink / raw)
To: u-boot
In-Reply-To: <1318795453-18090-3-git-send-email-vapier@gentoo.org>
Dear Mike Frysinger,
In message <1318795453-18090-3-git-send-email-vapier@gentoo.org> you wrote:
> Only one board uses this driver (ns9750dev), but the board doesn't seem
> to have an entry to actually build it in the Makefile/boards.cfg, so just
> delete net support from its board config.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> drivers/net/Makefile | 1 -
> drivers/net/ns9750_eth.c | 789 -------------------------------------------
> include/configs/ns9750dev.h | 2 -
> include/ns9750_eth.h | 298 ----------------
> 4 files changed, 0 insertions(+), 1090 deletions(-)
> delete mode 100644 drivers/net/ns9750_eth.c
> delete mode 100644 include/ns9750_eth.h
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I'm frequently appalled by the low regard you Earthmen have for life.
-- Spock, "The Galileo Seven", stardate 2822.3
^ permalink raw reply
* [lm-sensors] New fintek f718xx driver now available, please test
From: Krys Allen @ 2011-10-23 21:02 UTC (permalink / raw)
To: lm-sensors
In-Reply-To: <4D77DAB5.6080601@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 742 bytes --]
I get a few errors when trying to make on ubuntu 10.04, any ideas?
root@mediaserver:/home/krys# make
make -C /lib/modules/2.6.32-33-generic/build M=/home/krys modules
make[1]: Entering directory `/usr/src/linux-headers-2.6.32-33-generic'
CC [M] /home/krys/f71882fg.o
/home/krys/f71882fg.c: In function âsuperio_enterâ:
/home/krys/f71882fg.c:997: error: implicit declaration of function
ârequest_muxed_regionâ
/home/krys/f71882fg.c: In function âf71882fg_findâ:
/home/krys/f71882fg.c:2425: error: implicit declaration of function
âpr_warnâ
make[2]: *** [/home/krys/f71882fg.o] Error 1
make[1]: *** [_module_/home/krys] Error 2
make[1]: Leaving directory `/usr/src/linux-headers-2.6.32-33-generic'
make: *** [all] Error 2
[-- Attachment #1.2: Type: text/html, Size: 899 bytes --]
[-- Attachment #2: Type: text/plain, Size: 153 bytes --]
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply
* [PATCH] TTY: pty, fix pty counting
From: Ilya Zykov @ 2011-10-23 21:01 UTC (permalink / raw)
To: Jiri Slaby; +Cc: Greg Kroah-Hartman, Alan Cox, linux-kernel, ilya
New version for commit: 24d406a6bf736f7aebdc8fa0f0ec86e0890c6d24
diff -uprN a/drivers/tty/pty.c b/drivers/tty/pty.c
--- a/drivers/tty/pty.c 2011-05-19 08:06:34.000000000 +0400
+++ b/drivers/tty/pty.c 2011-10-23 18:01:20.000000000 +0400
@@ -36,13 +36,15 @@
static struct tty_driver *ptm_driver;
static struct tty_driver *pts_driver;
#endif
+static int pty_count;
static void pty_close(struct tty_struct *tty, struct file *filp)
{
BUG_ON(!tty);
- if (tty->driver->subtype == PTY_TYPE_MASTER)
+ if (tty->driver->subtype == PTY_TYPE_MASTER) {
WARN_ON(tty->count > 1);
- else {
+ pty_count--;
+ } else {
if (tty->count > 2)
return;
}
@@ -446,7 +448,6 @@ static inline void legacy_pty_init(void)
int pty_limit = NR_UNIX98_PTY_DEFAULT;
static int pty_limit_min;
static int pty_limit_max = NR_UNIX98_PTY_MAX;
-static int pty_count;
static struct cdev ptmx_cdev;
@@ -599,15 +600,9 @@ free_mem_out:
return -ENOMEM;
}
-static void pty_unix98_remove(struct tty_driver *driver, struct tty_struct *tty)
-{
- pty_count--;
-}
-
static const struct tty_operations ptm_unix98_ops = {
.lookup = ptm_unix98_lookup,
.install = pty_unix98_install,
- .remove = pty_unix98_remove,
.open = pty_open,
.close = pty_close,
.write = pty_write,
@@ -624,7 +619,6 @@ static const struct tty_operations ptm_u
static const struct tty_operations pty_unix98_ops = {
.lookup = pts_unix98_lookup,
.install = pty_unix98_install,
- .remove = pty_unix98_remove,
.open = pty_open,
.close = pty_close,
.write = pty_write,
^ permalink raw reply
* [U-Boot] [PATCH 1/5] net: enc28j60_lpc2292: drop unused !NET_MULTI driver
From: Wolfgang Denk @ 2011-10-23 21:01 UTC (permalink / raw)
To: u-boot
In-Reply-To: <1318795453-18090-2-git-send-email-vapier@gentoo.org>
Dear Mike Frysinger,
In message <1318795453-18090-2-git-send-email-vapier@gentoo.org> you wrote:
> Everyone seems to have converted to the new enc28j60 driver, so drop
> this older one which isn't used and doesn't support NET_MULTI.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> drivers/net/Makefile | 1 -
> drivers/net/enc28j60_lpc2292.c | 983 ----------------------------------------
> 2 files changed, 0 insertions(+), 984 deletions(-)
> delete mode 100644 drivers/net/enc28j60_lpc2292.c
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
As a general rule, the freedom of any people can be judged by the
volume of their laughter.
^ permalink raw reply
* Re: [PATCH] mac80211: Fix TDLS support validation in add_station handler
From: Arik Nemtsov @ 2011-10-23 21:00 UTC (permalink / raw)
To: Jouni Malinen; +Cc: John W. Linville, Johannes Berg, linux-wireless
In-Reply-To: <20111023193604.GA18257@jm.kir.nu>
On Sun, Oct 23, 2011 at 21:36, Jouni Malinen <j@w1.fi> wrote:
> We need to verify whether the command is successful before allocating
> the station entry to avoid extra processing. This also fixes a memory
> leak on the error path.
Thanks. I missed that one.
Arik
^ permalink raw reply
* [U-Boot] [PATCH] powerpc/lib/board.c: Call run_post(POST_ROM) before relocating
From: Wolfgang Denk @ 2011-10-23 20:58 UTC (permalink / raw)
To: u-boot
In-Reply-To: <1318759628-10668-1-git-send-email-bernhard.kaindl@gmx.net>
Dear Bernhard Kaindl,
In message <1318759628-10668-1-git-send-email-bernhard.kaindl@gmx.net> you wrote:
> From: Bernhard Kaindl <bernhard.kaindl@thalesgroup.com>
>
> The call to run_post(POST_ROM) which can run the POST memory test
> is currently called too late when gd has already been copied to DRAM.
>
> This results in failure to boot Linux after a POST_ROM memory test
> tested all RAM while gd was already relocated to DRAM due to gd being
> overwritten by the POST_ROM memory test.
>
> Support this by moving the call to run_post(POST_ROM) to run earlier,
> before U-Boot has started to move data to DRAM (from late board_init_f
> to early board_init_f) where DRAM is initialized, but not used yet.
>
> This allows that an POST memory test can test the whole DRAM,
> including the area where the board info struct is located.
>
> Signed-off-by: Bernhard Kaindl <bernhard.kaindl@thalesgroup.com>
> Cc: Pieter Voorthuijsen <pieter.voorthuijsen@prodrive.nl>
> ---
> arch/powerpc/lib/board.c | 14 +++++++-------
> 1 files changed, 7 insertions(+), 7 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Totally illogical, there was no chance.
-- Spock, "The Galileo Seven", stardate 2822.3
^ permalink raw reply
* [Qemu-devel] Help: Email archive search broken
From: Juan Pineda @ 2011-10-23 20:57 UTC (permalink / raw)
To: qemu-devel
Hello,
Search within the qemu-devel Email archives appears broken. Articles are returned, but it seems only up to around June 2011. For example, the following query searching for "dvd":
> http://lists.nongnu.org/archive/cgi-bin/namazu.cgi?query=dvd&submit=Search%21&idxname=qemu-devel&max=20&result=normal&sort=date%3Alate
Many thanks if that could be fixed.
-Juan
^ permalink raw reply
* [U-Boot] [PATCH] net/dns.c: Fix endian conversion for big-endian in dns command
From: Wolfgang Denk @ 2011-10-23 20:57 UTC (permalink / raw)
To: u-boot
In-Reply-To: <1318759162-10523-1-git-send-email-bernhard.kaindl@gmx.net>
Dear Bernhard Kaindl,
In message <1318759162-10523-1-git-send-email-bernhard.kaindl@gmx.net> you wrote:
> From: Bernhard Kaindl <bernhard.kaindl@thalesgroup.com>
>
> net/dns.c used endian conversion macros wrongly (shorts in reply
> were put swapped into CPU, and then ntohs() was used to swap it
> back, which broke on big-endian).
>
> Fix this by using the correct linux conversion macro for reading
> a unaligned short in network byte order: get_unaligned_be16()
> Thanks to Mike Frysinger pointing at the best macro to use.
>
> Tested on big and little endian qemu boards (mips and versatile)
>
> Signed-off-by: Bernhard Kaindl <bernhard.kaindl@thalesgroup.com>
> Cc: Pieter Voorthuijsen <pieter.voorthuijsen@prodrive.nl>
> Cc: Robin Getz <rgetz@blackfin.uclinux.org>
> ---
> net/dns.c | 20 ++++++++------------
> 1 files changed, 8 insertions(+), 12 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The Wright Bothers weren't the first to fly. They were just the first
not to crash.
^ permalink raw reply
* [U-Boot] [PATCH v4 0/6] Run-time configuration of U-Boot via a flat device tree (fdt)
From: Wolfgang Denk @ 2011-10-23 20:56 UTC (permalink / raw)
To: u-boot
In-Reply-To: <1318693706-3381-1-git-send-email-sjg@chromium.org>
Dear Simon Glass,
is there going to be an updated version of this patch series?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The algorithm to do that is extremely nasty. You might want to mug
someone with it." - M. Devine, Computer Science 340
^ permalink raw reply
* [U-Boot] [PATCH 10/10] x86: Use getenv_ulong() in place of getenv(), strtoul
From: Wolfgang Denk @ 2011-10-23 20:53 UTC (permalink / raw)
To: u-boot
In-Reply-To: <1318552994-6653-11-git-send-email-sjg@chromium.org>
Dear Simon Glass,
In message <1318552994-6653-11-git-send-email-sjg@chromium.org> you wrote:
> This changes the board code to use the new getenv_ulong() function.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
> arch/x86/lib/board.c | 14 +++-----------
> 1 files changed, 3 insertions(+), 11 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Successful and fortunate crime is called virtue. - Seneca
^ permalink raw reply
* [U-Boot] [PATCH 09/10] sparc: Use getenv_ulong() in place of getenv(), strtoul
From: Wolfgang Denk @ 2011-10-23 20:53 UTC (permalink / raw)
To: u-boot
In-Reply-To: <1318552994-6653-10-git-send-email-sjg@chromium.org>
Dear Simon Glass,
In message <1318552994-6653-10-git-send-email-sjg@chromium.org> you wrote:
> This changes the board code to use the new getenv_ulong() function.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
> arch/sparc/lib/board.c | 13 +++----------
> 1 files changed, 3 insertions(+), 10 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You're dead, Jim.
-- McCoy, "Amok Time", stardate 3372.7
^ permalink raw reply
* [U-Boot] [PATCH 08/10] powerpc: Use getenv_ulong() in place of getenv(), strtoul
From: Wolfgang Denk @ 2011-10-23 20:53 UTC (permalink / raw)
To: u-boot
In-Reply-To: <1318552994-6653-9-git-send-email-sjg@chromium.org>
Dear Simon Glass,
In message <1318552994-6653-9-git-send-email-sjg@chromium.org> you wrote:
> This changes the board code to use the new getenv_ulong() function.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
> arch/powerpc/lib/board.c | 33 ++++++++-------------------------
> 1 files changed, 8 insertions(+), 25 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The universe is all a spin-off of the Big Bang.
^ permalink raw reply
* [U-Boot] [PATCH 07/10] mips: Use getenv_ulong() in place of getenv(), strtoul
From: Wolfgang Denk @ 2011-10-23 20:52 UTC (permalink / raw)
To: u-boot
In-Reply-To: <1318552994-6653-8-git-send-email-sjg@chromium.org>
Dear Simon Glass,
In message <1318552994-6653-8-git-send-email-sjg@chromium.org> you wrote:
> This changes the board code to use the new getenv_ulong() function.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
> arch/mips/lib/board.c | 14 +++-----------
> 1 files changed, 3 insertions(+), 11 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Any sufficiently advanced bug is indistinguishable from a feature.
- Rich Kulawiec
^ permalink raw reply
* [U-Boot] [PATCH 06/10] microblaze: Use getenv_ulong() in place of getenv(), strtoul
From: Wolfgang Denk @ 2011-10-23 20:52 UTC (permalink / raw)
To: u-boot
In-Reply-To: <1318552994-6653-7-git-send-email-sjg@chromium.org>
Dear Simon Glass,
In message <1318552994-6653-7-git-send-email-sjg@chromium.org> you wrote:
> This changes the board code to use the new getenv_ulong() function.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
> arch/microblaze/lib/board.c | 6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
This was an amazing creation using small squares of compressed
vegetable matter on which letters were made by means of small carbon
particles from a stylus, giving an effect similar to the traditional
word-processor screen. It seemed amazingly portable and I never once
saw him have to change the batteries.
- Terry Pratchett & Stephen Briggs, _The Discworld Companion_
^ permalink raw reply
* [U-Boot] [PATCH 05/10] m68k: Use getenv_ulong() in place of getenv(), strtoul
From: Wolfgang Denk @ 2011-10-23 20:51 UTC (permalink / raw)
To: u-boot
In-Reply-To: <1318552994-6653-6-git-send-email-sjg@chromium.org>
Dear Simon Glass,
In message <1318552994-6653-6-git-send-email-sjg@chromium.org> you wrote:
> This changes the board code to use the new getenv_ulong() function.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
> arch/m68k/lib/board.c | 33 ++++++++-------------------------
> 1 files changed, 8 insertions(+), 25 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The universe does not have laws - it has habits, and habits can be
broken.
^ permalink raw reply
* [U-Boot] [PATCH 04/10] blackfin: Use getenv_ulong() in place of getenv(), strtoul
From: Wolfgang Denk @ 2011-10-23 20:50 UTC (permalink / raw)
To: u-boot
In-Reply-To: <1318552994-6653-5-git-send-email-sjg@chromium.org>
Dear Simon Glass,
In message <1318552994-6653-5-git-send-email-sjg@chromium.org> you wrote:
> This changes the board code to use the new getenv_ulong() function.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
> arch/blackfin/lib/board.c | 9 ++-------
> 1 files changed, 2 insertions(+), 7 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
How many seconds are there in a year? If I tell you there are 3.155 x
10^7, you won't even try to remember it. On the other hand, who could
forget that, to within half a percent, pi seconds is a nanocentury.
-- Tom Duff, Bell Labs
^ permalink raw reply
* [U-Boot] [PATCH 03/10] avr32: Use getenv_ulong() in place of getenv(), strtoul
From: Wolfgang Denk @ 2011-10-23 20:50 UTC (permalink / raw)
To: u-boot
In-Reply-To: <1318552994-6653-4-git-send-email-sjg@chromium.org>
Dear Simon Glass,
In message <1318552994-6653-4-git-send-email-sjg@chromium.org> you wrote:
> This changes the board code to use the new getenv_ulong() function.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
> arch/avr32/lib/board.c | 16 +++-------------
> 1 files changed, 3 insertions(+), 13 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Here's a fish hangs in the net like a poor man's right in the law.
'Twill hardly come out." - Shakespeare, Pericles, Act II, Scene 1
^ permalink raw reply
* [U-Boot] [PATCH 02/10] arm: Use getenv_ulong() in place of getenv(), strtoul
From: Wolfgang Denk @ 2011-10-23 20:50 UTC (permalink / raw)
To: u-boot
In-Reply-To: <1318552994-6653-3-git-send-email-sjg@chromium.org>
Dear Simon Glass,
In message <1318552994-6653-3-git-send-email-sjg@chromium.org> you wrote:
> This changes the board code to use the new getenv_ulong() function.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
> arch/arm/lib/board.c | 36 +++++++++++-------------------------
> 1 files changed, 11 insertions(+), 25 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"There's only one way to have a happy marriage and as soon as I learn
what it is I'll get married again." - Clint Eastwood
^ permalink raw reply
* [U-Boot] [PATCH v4 01/10] Add getenv_ulong() to read an integer from an environment variable
From: Wolfgang Denk @ 2011-10-23 20:49 UTC (permalink / raw)
To: u-boot
In-Reply-To: <1318634718-10548-1-git-send-email-sjg@chromium.org>
Dear Simon Glass,
In message <1318634718-10548-1-git-send-email-sjg@chromium.org> you wrote:
> This is not an uncommon operation in U-Boot, so let's put it in a common
> function.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
> Changes in v2:
> - Fix commit title from getenv_int() to getenv_ulong()
>
> Changes in v3:
> - Move getenv_ulong() function comment into C file
> - Add special code for early environment access
>
> Changes in v4:
> - Change getenv_ulong() implementation back to version 2
> - Add a comment as to why this is ok
>
> common/cmd_nvedit.c | 20 ++++++++++++++++++++
> include/common.h | 1 +
> 2 files changed, 21 insertions(+), 0 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It must be remembered that there is nothing more difficult to plan,
more doubtful of success, nor more dangerous to manage, than the
creation of a new system. For the initiator has the enmity of all who
would profit by the preservation of the old institutions and merely
lukewarm defenders in those who would gain by the new ones.
- Machiavelli
^ permalink raw reply
* [U-Boot] debugX macro
From: Marek Vasut @ 2011-10-23 20:46 UTC (permalink / raw)
To: u-boot
In-Reply-To: <20111023172326.827451408771@gemini.denx.de>
On Sunday, October 23, 2011 07:23:26 PM Wolfgang Denk wrote:
> Dear Marek Vasut,
>
> In message <201110231646.59439.marek.vasut@gmail.com> you wrote:
> > I've been doing the debug() cleanup and found the debugX() macro is used
> > only in very few patches. Maybe punting it altogether won't hurt.
> >
> > The following do use it:
> > ./board/spc1920/hpi.c
> > ./drivers/mtd/nand/s3c2410_nand.c
> >
> > Opinions?
>
> Dump it!
Dumped on next iteration of the GCC4.6 cleanups!
Cheers
^ permalink raw reply
* Re: [PATCH 00/36] Staging: cx25821: Clean up patch series
From: Mauro Carvalho Chehab @ 2011-10-23 20:45 UTC (permalink / raw)
To: Leonid V. Fedorenchik
Cc: Greg KH, Namhyung Kim, Palash Bandyopadhyay, Joe Perches,
Ilia Mirkin, Youquan Song, devel, linux-kernel
In-Reply-To: <20111023232418.2d79ed12@inspire>
Em 23-10-2011 17:24, Leonid V. Fedorenchik escreveu:
> On Sun, 23 Oct 2011 07:36:45 +0200
> Mauro Carvalho Chehab <mchehab@redhat.com> wrote:
>
>> Em 22-10-2011 10:19, Greg KH escreveu:
>>> On Sat, Oct 22, 2011 at 01:43:20PM +0800, Leonid V. Fedorenchik wrote:
>>>> This patch series fixes some style issues in drivers/staging/cx25821
>>>> Mostly I was hoping to improve readability and fix some issues found by
>>>> checkpatch.pl script.
>>>
>>> These are for Mauro to take through his tree.
>>
>> Yes. I'll put them on my queue.
>
> Thank you. Should I send my future patches for this driver directly to you?
The better is if you could send them to linux-media@vger.kernel.org. Patchwork
will catch them and put on my queue automatically.
Thanks,
Mauro
>
>>
>> Thanks,
>> Mauro
>
> Leonid V. Fedorenchik
^ permalink raw reply
* [U-Boot] [PATCHv10] new tool mkenvimage: generates an env image from an arbitrary config file
From: Wolfgang Denk @ 2011-10-23 20:44 UTC (permalink / raw)
To: u-boot
In-Reply-To: <1318612616-16799-1-git-send-email-david.wagner@free-electrons.com>
Dear David Wagner,
In message <1318612616-16799-1-git-send-email-david.wagner@free-electrons.com> you wrote:
> This tool takes a key=value configuration file (same as would a `printenv' show)
> and generates the corresponding environment image, ready to be flashed.
>
> use case: flash the environment with an external tool
This patch fails to build when I try to run a plain "make
tools/mkenvimage":
tools/mkenvimage.c:35:22: fatal error: compiler.h: No such file or directory
tools/mkenvimage.c:39:24: fatal error: u-boot/crc.h: No such file or
directory
...
> + /* Parse the cmdline */
> + while ((option = getopt(argc, argv, "s:o:rbp:h")) != -1) {
> + switch (option) {
> + case 's':
> + datasize = strtol(optarg, NULL, 0);
...
> + padbyte = strtol(optarg, NULL, 0);
Please add error checking for invalid input formats here.
> + if (datasize == 0) {
> + fprintf(stderr,
> + "Please specify the size of the envrionnment "
> + "partition.\n");
Please don't split that string, and fix the "envrionment" typo.
> + dataptr = malloc(datasize * sizeof(*dataptr));
> + if (!dataptr) {
> + fprintf(stderr, "Can't alloc dataptr.\n");
It might be helpful to know how many bytes you were trying to
allocate.
> + /*
> + * envptr points to the beginning of the actual environment (after the
> + * crc and possible `redundant' bit
s/bit/byte/
> + /* Open the input file ... */
> + if (optind >= argc) {
> + fprintf(stderr, "Please specify an input filename\n");
> + return EXIT_FAILURE;
> + }
Please also allow to use stdin as input when no "<input file>" arg is
given.
> + int readlen = sizeof(*envptr) * 2048;
> + txt_fd = STDIN_FILENO;
> +
> + do {
> + filebuf = realloc(filebuf, readlen);
> + readbytes = read(txt_fd, filebuf + filesize, readlen);
> + filesize += readbytes;
> + } while (readbytes == readlen);
This is pretty much inefficient. Consider a size increment of
something like min(readlen, 4096).
Also, realloc() can fail - add error handling.
And read() can fail, too - add error handling.
> + filesize = txt_file_stat.st_size;
> + /* Read the raw input file and transform it */
Why don't you just use mmap() here?
> + if (filesize >= envsize) {
> + fprintf(stderr, "The input file is larger than the "
> + "envrionnment partition size\n");
Please don't split such strings. See CodingStyle:
"However, never break user-visible strings such as printk
messages, because that breaks the ability to grep for them."
Please fix globally.
> + } else if (filebuf[fp] == '#') {
> + if (fp != 0 && filebuf[fp-1] == '\n') {
> + /* This line is a comment, let's skip it */
> + while (fp < txt_file_stat.st_size &&
> + filebuf[fp] != '\n')
> + fp++;
> + } else {
> + envptr[ep++] = filebuf[fp];
> + }
printenv output does not contain any such "comments".
And - aren't you also catching embedded hashes here, like in "serial#"
for example?
...
> +
> + /* Computes the CRC and put it at the beginning of the data */
> + crc = crc32(0, envptr, envsize);
> + targetendian_crc = bigendian ? cpu_to_be32(crc) : cpu_to_le32(crc);
> +
> + memcpy(dataptr, &targetendian_crc, sizeof(uint32_t));
I fail to see where you set the redundant flag?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I am more bored than you could ever possibly be. Go back to work.
^ permalink raw reply
* Re: [PATCH 1/3] drm/i915: Ivybridge still has fences!
From: Kenneth Graunke @ 2011-10-23 20:45 UTC (permalink / raw)
To: Chris Wilson; +Cc: Daniel Vetter, intel-gfx
In-Reply-To: <aefc95$1v3t51@orsmga001.jf.intel.com>
On 10/23/2011 04:23 AM, Chris Wilson wrote:
> Regardless of the outcome of Jesse's request for an if-ladder, the
> substance of the patches look sound.
>
> However, I remain unconvinced that there are 32 fence registers on IVB.
> Daniel's evidence is based upon the size of the register map (and not
> on the BSPEC explicitly stating a change to 32 ;-), but most tellingly
> the bitfields for fence-number in other registers have not been updated -
> so we can only safely allocated the first 16 anyway...
> (For instance, FBC_CTL).
> -Chris
It sure looks like it has 32 fence registers: BSpec vol1g GT Interface
Register [DevIVB] / GT Interface Register DevIVB / System Agent Config
Space lists FENCE0 through FENCE31. The simulator seems to indicate
this as well.
You're right that FBC_CTL still only has 4 bits for selecting a fence,
but notably, in the latest (WIP) version of the BSpec, it says "This
field must be programmed to 0000b." I'm not sure how it's supposed to
work now, but likely something has changed.
^ permalink raw reply
* Re: Snapshot rollback
From: Goffredo Baroncelli @ 2011-10-23 20:35 UTC (permalink / raw)
To: Phillip Susi; +Cc: linux-btrfs
In-Reply-To: <4EA46E3A.9090307@cfl.rr.com>
On Sunday, 23 October, 2011 15:42:50 you wrote:
> there no way to move or hard link subvolumes to somewhere other
> than their original location?
You can use the 'mv' command.
[__active is the subvolume which I use as root]
ghigo@venice:/tmp$ btrfs sub crea a
Create subvolume './a'
ghigo@venice:/tmp$ btrfs sub crea c
Create subvolume './c'
ghigo@venice:/tmp$ btrfs sub crea a/b
Create subvolume 'a/b'
ghigo@venice:/tmp$ sudo btrfs sub list /var/btrfs/
ID 258 top level 5 path __active
ID 259 top level 5 path __active/tmp/a
ID 260 top level 5 path __active/tmp/c
ID 261 top level 5 path __active/tmp/a/b
ghigo@venice:/tmp$ mv a/b c
ghigo@venice:/tmp$ sudo btrfs sub list /var/btrfs/
ID 258 top level 5 path __active
ID 259 top level 5 path __active/tmp/a
ID 260 top level 5 path __active/tmp/c
ID 261 top level 5 path __active/tmp/c/b
--
gpg key@ keyserver.linux.it: Goffredo Baroncelli (ghigo) <kreijack@inwind.it>
Key fingerprint = 4769 7E51 5293 D36C 814E C054 BF04 F161 3DC5 0512
^ permalink raw reply
* Re: longjmp question
From: David Miller @ 2011-10-23 20:35 UTC (permalink / raw)
To: sparclinux
In-Reply-To: <20111007232209.GA11892@wooyd.org>
From: Jurij Smakov <jurij@wooyd.org>
Date: Sun, 23 Oct 2011 14:47:27 +0100
> On Sat, Oct 22, 2011 at 06:54:05PM -0400, David Miller wrote:
>>
>> Just let the compiler do it for you, please... the compiler absolutely cannot
>> optimize away a function that uses a volatile asm statement. And it absolutely
>> cannot make a function that clobbers %o7 a leaf function.
>
> That's not what I see. I tried writing up a patch for Ruby using this,
> and here's what I get:
>
> 1. Preprocessed source of cont.c contains flush_register_windows
> definition:
>
> # 219 "./include/ruby/defines.h"
> static void
> flush_register_windows(void)
> {
> asm __volatile__ ("flushw" : : : "o7");
> }
You can't put it in a header file, GCC will inline it. You have to
put it in a function in a seperate C file, and this is what I said to
do the other week in my original email.
You're only other option is to explicitly mark this
__attribute__((__noinline__))
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.