* [Buildroot] [git commit] package/haveged: fix legal-info
From: Peter Korsgaard @ 2019-06-20 11:30 UTC (permalink / raw)
To: buildroot
commit: https://git.buildroot.net/buildroot/commit/?id=0ae29b98d1293b0e89fa2f5686fe743af1f45c34
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
Add hash for COPYING file
Fixes:
$: make haveged-legal-info
>>> haveged 1.9.4 Collecting legal info
ERROR: No hash found for COPYING
Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
package/haveged/haveged.hash | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/haveged/haveged.hash b/package/haveged/haveged.hash
index d98e1d984b..048941849c 100644
--- a/package/haveged/haveged.hash
+++ b/package/haveged/haveged.hash
@@ -1,2 +1,3 @@
# Locally calculated
sha256 c4959d3cb1fa6391d16a3aa1ba4d82cd3a0d497206ae4b87d638088c0664e5aa haveged-1.9.4.tar.gz
+sha256 8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903 COPYING
^ permalink raw reply related
* Re: [Qemu-devel] [PATCH 3/4] target/mips: Fix some space checkpatch errors in translate.c
From: Philippe Mathieu-Daudé @ 2019-06-20 11:11 UTC (permalink / raw)
To: Aleksandar Markovic, qemu-devel; +Cc: arikalo, amarkovic
In-Reply-To: <1561022396-20649-4-git-send-email-aleksandar.markovic@rt-rk.com>
On 6/20/19 11:19 AM, Aleksandar Markovic wrote:
> From: Aleksandar Markovic <amarkovic@wavecomp.com>
>
> Remove some space-related checkpatch warning.
>
> Signed-off-by: Aleksandar Markovic <amarkovic@wavecomp.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> target/mips/translate.c | 126 +++++++++++++++++++++++++-----------------------
> 1 file changed, 65 insertions(+), 61 deletions(-)
>
> diff --git a/target/mips/translate.c b/target/mips/translate.c
> index a3cf976..324b32a 100644
> --- a/target/mips/translate.c
> +++ b/target/mips/translate.c
> @@ -2617,7 +2617,7 @@ static const char * const mxuregnames[] = {
> } while (0)
>
> /* General purpose registers moves. */
> -static inline void gen_load_gpr (TCGv t, int reg)
> +static inline void gen_load_gpr(TCGv t, int reg)
> {
> if (reg == 0)
> tcg_gen_movi_tl(t, 0);
> @@ -2625,14 +2625,14 @@ static inline void gen_load_gpr (TCGv t, int reg)
> tcg_gen_mov_tl(t, cpu_gpr[reg]);
> }
>
> -static inline void gen_store_gpr (TCGv t, int reg)
> +static inline void gen_store_gpr(TCGv t, int reg)
> {
> if (reg != 0)
> tcg_gen_mov_tl(cpu_gpr[reg], t);
> }
>
> /* Moves to/from shadow registers. */
> -static inline void gen_load_srsgpr (int from, int to)
> +static inline void gen_load_srsgpr(int from, int to)
> {
> TCGv t0 = tcg_temp_new();
>
> @@ -2839,7 +2839,7 @@ static void gen_store_fpr64(DisasContext *ctx, TCGv_i64 t, int reg)
> }
> }
>
> -static inline int get_fp_bit (int cc)
> +static inline int get_fp_bit(int cc)
> {
> if (cc)
> return 24 + cc;
> @@ -2848,7 +2848,8 @@ static inline int get_fp_bit (int cc)
> }
>
> /* Addresses computation */
> -static inline void gen_op_addr_add (DisasContext *ctx, TCGv ret, TCGv arg0, TCGv arg1)
> +static inline void gen_op_addr_add(DisasContext *ctx, TCGv ret, TCGv arg0,
> + TCGv arg1)
> {
> tcg_gen_add_tl(ret, arg0, arg1);
>
> @@ -3328,8 +3329,8 @@ OP_LD_ATOMIC(lld,ld64);
> #endif
> #undef OP_LD_ATOMIC
>
> -static void gen_base_offset_addr (DisasContext *ctx, TCGv addr,
> - int base, int offset)
> +static void gen_base_offset_addr(DisasContext *ctx, TCGv addr,
> + int base, int offset)
> {
> if (base == 0) {
> tcg_gen_movi_tl(addr, offset);
> @@ -3341,7 +3342,7 @@ static void gen_base_offset_addr (DisasContext *ctx, TCGv addr,
> }
> }
>
> -static target_ulong pc_relative_pc (DisasContext *ctx)
> +static target_ulong pc_relative_pc(DisasContext *ctx)
> {
> target_ulong pc = ctx->base.pc_next;
>
> @@ -3578,8 +3579,8 @@ static void gen_llwp(DisasContext *ctx, uint32_t base, int16_t offset,
> }
>
> /* Store */
> -static void gen_st (DisasContext *ctx, uint32_t opc, int rt,
> - int base, int offset)
> +static void gen_st(DisasContext *ctx, uint32_t opc, int rt,
> + int base, int offset)
> {
> TCGv t0 = tcg_temp_new();
> TCGv t1 = tcg_temp_new();
> @@ -3717,8 +3718,8 @@ static void gen_scwp(DisasContext *ctx, uint32_t base, int16_t offset,
> }
>
> /* Load and store */
> -static void gen_flt_ldst (DisasContext *ctx, uint32_t opc, int ft,
> - TCGv t0)
> +static void gen_flt_ldst(DisasContext *ctx, uint32_t opc, int ft,
> + TCGv t0)
> {
> /* Don't do NOP if destination is zero: we must perform the actual
> memory access. */
> @@ -5132,8 +5133,8 @@ static void gen_mul_txx9(DisasContext *ctx, uint32_t opc,
> tcg_temp_free(t1);
> }
>
> -static void gen_mul_vr54xx (DisasContext *ctx, uint32_t opc,
> - int rd, int rs, int rt)
> +static void gen_mul_vr54xx(DisasContext *ctx, uint32_t opc,
> + int rd, int rs, int rt)
> {
> TCGv t0 = tcg_temp_new();
> TCGv t1 = tcg_temp_new();
> @@ -5196,8 +5197,8 @@ static void gen_mul_vr54xx (DisasContext *ctx, uint32_t opc,
> tcg_temp_free(t1);
> }
>
> -static void gen_cl (DisasContext *ctx, uint32_t opc,
> - int rd, int rs)
> +static void gen_cl(DisasContext *ctx, uint32_t opc,
> + int rd, int rs)
> {
> TCGv t0;
>
> @@ -6188,8 +6189,8 @@ static void gen_compute_branch_nm(DisasContext *ctx, uint32_t opc,
>
>
> /* special3 bitfield operations */
> -static void gen_bitops (DisasContext *ctx, uint32_t opc, int rt,
> - int rs, int lsb, int msb)
> +static void gen_bitops(DisasContext *ctx, uint32_t opc, int rt,
> + int rs, int lsb, int msb)
> {
> TCGv t0 = tcg_temp_new();
> TCGv t1 = tcg_temp_new();
> @@ -6259,7 +6260,7 @@ fail:
> tcg_temp_free(t1);
> }
>
> -static void gen_bshfl (DisasContext *ctx, uint32_t op2, int rt, int rd)
> +static void gen_bshfl(DisasContext *ctx, uint32_t op2, int rt, int rd)
> {
> TCGv t0;
>
> @@ -6502,7 +6503,7 @@ static inline void gen_mfhc0_load64(TCGv arg, target_ulong off, int shift)
> tcg_temp_free_i64(t0);
> }
>
> -static inline void gen_mfc0_load32 (TCGv arg, target_ulong off)
> +static inline void gen_mfc0_load32(TCGv arg, target_ulong off)
> {
> TCGv_i32 t0 = tcg_temp_new_i32();
>
> @@ -6511,13 +6512,13 @@ static inline void gen_mfc0_load32 (TCGv arg, target_ulong off)
> tcg_temp_free_i32(t0);
> }
>
> -static inline void gen_mfc0_load64 (TCGv arg, target_ulong off)
> +static inline void gen_mfc0_load64(TCGv arg, target_ulong off)
> {
> tcg_gen_ld_tl(arg, cpu_env, off);
> tcg_gen_ext32s_tl(arg, arg);
> }
>
> -static inline void gen_mtc0_store32 (TCGv arg, target_ulong off)
> +static inline void gen_mtc0_store32(TCGv arg, target_ulong off)
> {
> TCGv_i32 t0 = tcg_temp_new_i32();
>
> @@ -10077,7 +10078,8 @@ die:
> generate_exception_end(ctx, EXCP_RI);
> }
>
> -static void gen_cp0 (CPUMIPSState *env, DisasContext *ctx, uint32_t opc, int rt, int rd)
> +static void gen_cp0(CPUMIPSState *env, DisasContext *ctx, uint32_t opc,
> + int rt, int rd)
> {
> const char *opn = "ldst";
>
> @@ -10633,7 +10635,8 @@ enum r6_f_cmp_op {
> R6_OPC_CMP_SUNE_D = FOP(26, FMT_L),
> R6_OPC_CMP_SNE_D = FOP(27, FMT_L),
> };
> -static void gen_cp1 (DisasContext *ctx, uint32_t opc, int rt, int fs)
> +
> +static void gen_cp1(DisasContext *ctx, uint32_t opc, int rt, int fs)
> {
> TCGv t0 = tcg_temp_new();
>
> @@ -10714,7 +10717,7 @@ static void gen_cp1 (DisasContext *ctx, uint32_t opc, int rt, int fs)
> tcg_temp_free(t0);
> }
>
> -static void gen_movci (DisasContext *ctx, int rd, int rs, int cc, int tf)
> +static void gen_movci(DisasContext *ctx, int rd, int rs, int cc, int tf)
> {
> TCGLabel *l1;
> TCGCond cond;
> @@ -10763,7 +10766,8 @@ static inline void gen_movcf_s(DisasContext *ctx, int fs, int fd, int cc,
> tcg_temp_free_i32(t0);
> }
>
> -static inline void gen_movcf_d (DisasContext *ctx, int fs, int fd, int cc, int tf)
> +static inline void gen_movcf_d(DisasContext *ctx, int fs, int fd, int cc,
> + int tf)
> {
> int cond;
> TCGv_i32 t0 = tcg_temp_new_i32();
> @@ -10886,8 +10890,8 @@ static void gen_sel_d(DisasContext *ctx, enum fopcode op1, int fd, int ft,
> tcg_temp_free_i64(t1);
> }
>
> -static void gen_farith (DisasContext *ctx, enum fopcode op1,
> - int ft, int fs, int fd, int cc)
> +static void gen_farith(DisasContext *ctx, enum fopcode op1,
> + int ft, int fs, int fd, int cc)
> {
> uint32_t func = ctx->opcode & 0x3f;
> switch (op1) {
> @@ -12314,8 +12318,8 @@ static void gen_farith (DisasContext *ctx, enum fopcode op1,
> }
>
> /* Coprocessor 3 (FPU) */
> -static void gen_flt3_ldst (DisasContext *ctx, uint32_t opc,
> - int fd, int fs, int base, int index)
> +static void gen_flt3_ldst(DisasContext *ctx, uint32_t opc,
> + int fd, int fs, int base, int index)
> {
> TCGv t0 = tcg_temp_new();
>
> @@ -12394,8 +12398,8 @@ static void gen_flt3_ldst (DisasContext *ctx, uint32_t opc,
> tcg_temp_free(t0);
> }
>
> -static void gen_flt3_arith (DisasContext *ctx, uint32_t opc,
> - int fd, int fr, int fs, int ft)
> +static void gen_flt3_arith(DisasContext *ctx, uint32_t opc,
> + int fd, int fr, int fs, int ft)
> {
> switch (opc) {
> case OPC_ALNV_PS:
> @@ -13157,17 +13161,17 @@ enum {
> RR_RY_CNVT_SEW = 0x6,
> };
>
> -static int xlat (int r)
> +static int xlat(int r)
> {
> static int map[] = { 16, 17, 2, 3, 4, 5, 6, 7 };
>
> return map[r];
> }
>
> -static void gen_mips16_save (DisasContext *ctx,
> - int xsregs, int aregs,
> - int do_ra, int do_s0, int do_s1,
> - int framesize)
> +static void gen_mips16_save(DisasContext *ctx,
> + int xsregs, int aregs,
> + int do_ra, int do_s0, int do_s1,
> + int framesize)
> {
> TCGv t0 = tcg_temp_new();
> TCGv t1 = tcg_temp_new();
> @@ -13322,10 +13326,10 @@ static void gen_mips16_save (DisasContext *ctx,
> tcg_temp_free(t2);
> }
>
> -static void gen_mips16_restore (DisasContext *ctx,
> - int xsregs, int aregs,
> - int do_ra, int do_s0, int do_s1,
> - int framesize)
> +static void gen_mips16_restore(DisasContext *ctx,
> + int xsregs, int aregs,
> + int do_ra, int do_s0, int do_s1,
> + int framesize)
> {
> int astatic;
> TCGv t0 = tcg_temp_new();
> @@ -13428,8 +13432,8 @@ static void gen_mips16_restore (DisasContext *ctx,
> tcg_temp_free(t2);
> }
>
> -static void gen_addiupc (DisasContext *ctx, int rx, int imm,
> - int is_64_bit, int extended)
> +static void gen_addiupc(DisasContext *ctx, int rx, int imm,
> + int is_64_bit, int extended)
> {
> TCGv t0;
>
> @@ -13459,9 +13463,9 @@ static void gen_cache_operation(DisasContext *ctx, uint32_t op, int base,
> }
>
> #if defined(TARGET_MIPS64)
> -static void decode_i64_mips16 (DisasContext *ctx,
> - int ry, int funct, int16_t offset,
> - int extended)
> +static void decode_i64_mips16(DisasContext *ctx,
> + int ry, int funct, int16_t offset,
> + int extended)
> {
> switch (funct) {
> case I64_LDSP:
> @@ -13520,7 +13524,7 @@ static void decode_i64_mips16 (DisasContext *ctx,
> }
> #endif
>
> -static int decode_extended_mips16_opc (CPUMIPSState *env, DisasContext *ctx)
> +static int decode_extended_mips16_opc(CPUMIPSState *env, DisasContext *ctx)
> {
> int extend = cpu_lduw_code(env, ctx->base.pc_next + 2);
> int op, rx, ry, funct, sa;
> @@ -13734,7 +13738,7 @@ static inline void gen_helper_do_semihosting(void *env)
> }
> #endif
>
> -static int decode_mips16_opc (CPUMIPSState *env, DisasContext *ctx)
> +static int decode_mips16_opc(CPUMIPSState *env, DisasContext *ctx)
> {
> int rx, ry;
> int sa;
> @@ -13957,7 +13961,7 @@ static int decode_mips16_opc (CPUMIPSState *env, DisasContext *ctx)
> case M16_OPC_LWPC:
> gen_ld(ctx, OPC_LWPC, rx, 0, ((uint8_t)ctx->opcode) << 2);
> break;
> -#if defined (TARGET_MIPS64)
> +#if defined(TARGET_MIPS64)
> case M16_OPC_LWU:
> check_insn(ctx, ISA_MIPS3);
> check_mips_64(ctx);
> @@ -14061,7 +14065,7 @@ static int decode_mips16_opc (CPUMIPSState *env, DisasContext *ctx)
> case RR_SRAV:
> gen_shift(ctx, OPC_SRAV, ry, rx, ry);
> break;
> -#if defined (TARGET_MIPS64)
> +#if defined(TARGET_MIPS64)
> case RR_DSRL:
> check_insn(ctx, ISA_MIPS3);
> check_mips_64(ctx);
> @@ -14124,7 +14128,7 @@ static int decode_mips16_opc (CPUMIPSState *env, DisasContext *ctx)
> case RR_MFLO:
> gen_HILO(ctx, OPC_MFLO, 0, rx);
> break;
> -#if defined (TARGET_MIPS64)
> +#if defined(TARGET_MIPS64)
> case RR_DSRA:
> check_insn(ctx, ISA_MIPS3);
> check_mips_64(ctx);
> @@ -14158,7 +14162,7 @@ static int decode_mips16_opc (CPUMIPSState *env, DisasContext *ctx)
> case RR_DIVU:
> gen_muldiv(ctx, OPC_DIVU, 0, rx, ry);
> break;
> -#if defined (TARGET_MIPS64)
> +#if defined(TARGET_MIPS64)
> case RR_DMULT:
> check_insn(ctx, ISA_MIPS3);
> check_mips_64(ctx);
> @@ -14802,7 +14806,7 @@ enum {
> ADDIUR1SP = 0x1
> };
>
> -static int mmreg (int r)
> +static int mmreg(int r)
> {
> static const int map[] = { 16, 17, 2, 3, 4, 5, 6, 7 };
>
> @@ -14810,7 +14814,7 @@ static int mmreg (int r)
> }
>
> /* Used for 16-bit store instructions. */
> -static int mmreg2 (int r)
> +static int mmreg2(int r)
> {
> static const int map[] = { 0, 17, 2, 3, 4, 5, 6, 7 };
>
> @@ -14885,8 +14889,8 @@ static void gen_andi16(DisasContext *ctx)
> gen_logic_imm(ctx, OPC_ANDI, rd, rs, decoded_imm[encoded]);
> }
>
> -static void gen_ldst_multiple (DisasContext *ctx, uint32_t opc, int reglist,
> - int base, int16_t offset)
> +static void gen_ldst_multiple(DisasContext *ctx, uint32_t opc, int reglist,
> + int base, int16_t offset)
> {
> TCGv t0, t1;
> TCGv_i32 t2;
> @@ -15159,7 +15163,7 @@ static void gen_pool16c_r6_insn(DisasContext *ctx)
> }
> }
>
> -static void gen_ldxs (DisasContext *ctx, int base, int index, int rd)
> +static void gen_ldxs(DisasContext *ctx, int base, int index, int rd)
> {
> TCGv t0 = tcg_temp_new();
> TCGv t1 = tcg_temp_new();
> @@ -15179,8 +15183,8 @@ static void gen_ldxs (DisasContext *ctx, int base, int index, int rd)
> tcg_temp_free(t1);
> }
>
> -static void gen_ldst_pair (DisasContext *ctx, uint32_t opc, int rd,
> - int base, int16_t offset)
> +static void gen_ldst_pair(DisasContext *ctx, uint32_t opc, int rd,
> + int base, int16_t offset)
> {
> TCGv t0, t1;
>
> @@ -15270,7 +15274,7 @@ static void gen_sync(int stype)
> tcg_gen_mb(tcg_mo);
> }
>
> -static void gen_pool32axf (CPUMIPSState *env, DisasContext *ctx, int rt, int rs)
> +static void gen_pool32axf(CPUMIPSState *env, DisasContext *ctx, int rt, int rs)
> {
> int extension = (ctx->opcode >> 6) & 0x3f;
> int minor = (ctx->opcode >> 12) & 0xf;
> @@ -17234,7 +17238,7 @@ static void decode_micromips32_opc(CPUMIPSState *env, DisasContext *ctx)
> }
> }
>
> -static int decode_micromips_opc (CPUMIPSState *env, DisasContext *ctx)
> +static int decode_micromips_opc(CPUMIPSState *env, DisasContext *ctx)
> {
> uint32_t op;
>
>
^ permalink raw reply
* [Buildroot] [git commit] package/haveged: bump to version 1.9.4
From: Peter Korsgaard @ 2019-06-20 11:30 UTC (permalink / raw)
To: buildroot
commit: https://git.buildroot.net/buildroot/commit/?id=6bc4189b82ae19e7718ed0dcdefcec0f03233132
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
See https://github.com/jirka-h/haveged/releases/tag/1.9.4
Also change the site location, upstream release
mechanism has switched to using github.
Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
package/haveged/haveged.hash | 4 ++--
package/haveged/haveged.mk | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/package/haveged/haveged.hash b/package/haveged/haveged.hash
index d1133b6931..d98e1d984b 100644
--- a/package/haveged/haveged.hash
+++ b/package/haveged/haveged.hash
@@ -1,2 +1,2 @@
-# From http://www.issihosts.com/haveged/verify/haveged-1.9.1.sha1
-sha1 ab7234b7f57dbb7d500a5ab3cbf0494715ce6499 haveged-1.9.1.tar.gz
+# Locally calculated
+sha256 c4959d3cb1fa6391d16a3aa1ba4d82cd3a0d497206ae4b87d638088c0664e5aa haveged-1.9.4.tar.gz
diff --git a/package/haveged/haveged.mk b/package/haveged/haveged.mk
index a645557bc4..bc1bb2d3ac 100644
--- a/package/haveged/haveged.mk
+++ b/package/haveged/haveged.mk
@@ -4,8 +4,8 @@
#
################################################################################
-HAVEGED_VERSION = 1.9.1
-HAVEGED_SITE = http://www.issihosts.com/haveged
+HAVEGED_VERSION = 1.9.4
+HAVEGED_SITE = $(call github,jirka-h,haveged,$(HAVEGED_VERSION))
HAVEGED_LICENSE = GPL-3.0+
HAVEGED_LICENSE_FILES = COPYING
^ permalink raw reply related
* Re: kernel tree support matrix for Clang
From: Mark Brown @ 2019-06-20 11:30 UTC (permalink / raw)
To: Nick Desaulniers
Cc: kernelci, Matt Hart, Dan Rue, Anmar Oueja, clang-built-linux,
Todd Kjos, Sandeep Patil, Alistair Delva, Stephen Hines
In-Reply-To: <CAKwvOd=9U9Z2w8R_GnAKf438f+fXUZ5zCnvsmJGSKnjv+L4g2A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 511 bytes --]
On Wed, Jun 19, 2019 at 02:12:53PM -0700, Nick Desaulniers wrote:
> On Wed, Jun 19, 2019 at 11:57 AM Mark Brown <broonie@kernel.org> wrote:
> > The last time we talked about it the plan was to turn clang builds on
> > for mainline just as soon as the last few patches for making that build
> > land so that should be after the merge window.
> Which merge window? 5.1 or 5.2?
I can't remember off the top of my head; in any case v5.1 is released
so the v5.2 merge window has passed if everything is in there.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply
* Re: [PATCH v3 6/6] crypto: arm64/aes - implement accelerated ESSIV/CBC mode
From: Milan Broz @ 2019-06-20 11:29 UTC (permalink / raw)
To: Eric Biggers, Ard Biesheuvel
Cc: linux-crypto, Herbert Xu, dm-devel, linux-fscrypt,
Gilad Ben-Yossef, Milan Broz
In-Reply-To: <20190619223710.GC33328@gmail.com>
On 20/06/2019 00:37, Eric Biggers wrote:
> On Wed, Jun 19, 2019 at 06:29:21PM +0200, Ard Biesheuvel wrote:
>> Add an accelerated version of the 'essiv(cbc(aes),aes,sha256)'
>> skcipher, which is used by fscrypt, and in some cases, by dm-crypt.
>> This avoids a separate call into the AES cipher for every invocation.
>>
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> I'm not sure we should bother with this, since fscrypt normally uses AES-256-XTS
> for contents encryption. AES-128-CBC-ESSIV support was only added because
> people wanted something that is fast on low-powered embedded devices with crypto
> accelerators such as CAAM or CESA that don't support XTS.
>
> In the case of Android, the CDD doesn't even allow AES-128-CBC-ESSIV with
> file-based encryption (fscrypt). It's still the default for "full disk
> encryption" (which uses dm-crypt), but that's being deprecated.
>
> So maybe dm-crypt users will want this, but I don't think it's very useful for
> fscrypt.
The aes-cbc-essiv:sha256 is still default for plain cryptsetup devices
(LUKS uses XTS for several years as a default already).
The reason is compatibility with older distros (if there is no cipher mode
specification in crypttab for plain device, switching default could cause data corruption).
But I think initscripts now enforce cipher and keysize crypttab options for some time,
so I can probably switch the default to XTS for plain devices soon.
(We have already compile time option for it anyway.)
IOW intention for dm-crypt is to slightly deprecate CBC mode use for all types of devices.
Milan
^ permalink raw reply
* Re: [PATCH v3 6/6] crypto: arm64/aes - implement accelerated ESSIV/CBC mode
From: Milan Broz @ 2019-06-20 11:29 UTC (permalink / raw)
To: Eric Biggers, Ard Biesheuvel
Cc: Herbert Xu, linux-fscrypt, Gilad Ben-Yossef, dm-devel,
linux-crypto, Milan Broz
In-Reply-To: <20190619223710.GC33328@gmail.com>
On 20/06/2019 00:37, Eric Biggers wrote:
> On Wed, Jun 19, 2019 at 06:29:21PM +0200, Ard Biesheuvel wrote:
>> Add an accelerated version of the 'essiv(cbc(aes),aes,sha256)'
>> skcipher, which is used by fscrypt, and in some cases, by dm-crypt.
>> This avoids a separate call into the AES cipher for every invocation.
>>
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> I'm not sure we should bother with this, since fscrypt normally uses AES-256-XTS
> for contents encryption. AES-128-CBC-ESSIV support was only added because
> people wanted something that is fast on low-powered embedded devices with crypto
> accelerators such as CAAM or CESA that don't support XTS.
>
> In the case of Android, the CDD doesn't even allow AES-128-CBC-ESSIV with
> file-based encryption (fscrypt). It's still the default for "full disk
> encryption" (which uses dm-crypt), but that's being deprecated.
>
> So maybe dm-crypt users will want this, but I don't think it's very useful for
> fscrypt.
The aes-cbc-essiv:sha256 is still default for plain cryptsetup devices
(LUKS uses XTS for several years as a default already).
The reason is compatibility with older distros (if there is no cipher mode
specification in crypttab for plain device, switching default could cause data corruption).
But I think initscripts now enforce cipher and keysize crypttab options for some time,
so I can probably switch the default to XTS for plain devices soon.
(We have already compile time option for it anyway.)
IOW intention for dm-crypt is to slightly deprecate CBC mode use for all types of devices.
Milan
^ permalink raw reply
* Re: [PATCH v3 2/2] shared/012: Add tests for filename casefolding feature
From: Eryu Guan @ 2019-06-20 11:29 UTC (permalink / raw)
To: Theodore Ts'o
Cc: Gabriel Krisman Bertazi, fstests, linux-ext4, Lakshmipathi.G
In-Reply-To: <20190616200154.GA7251@mit.edu>
On Sun, Jun 16, 2019 at 04:01:54PM -0400, Theodore Ts'o wrote:
> On Sun, Jun 16, 2019 at 10:44:40PM +0800, Eryu Guan wrote:
> > On Wed, Jun 12, 2019 at 02:40:33PM -0400, Gabriel Krisman Bertazi wrote:
> > Test looks good to me, and test passes for me with v5.2-rc4 kernel and
> > latest e2fsprogs, thanks! Just that, I moved the test to generic, as we
> > have all the needed _require rules ready to _notrun on unsupported fs,
> > so it's ready to be generic. (Sorry I was not involved with the
> > ext4-shared-generic discussion in the first place)
>
> Just to clear up my confusion, what's the distinction between shared
> and generic? Is it that if there are explicit "only run this test on
> file systems xxx, yyy, and zzz declarations", then it should be
> shared, and otherwise it should be in generic?
>
> - Ted
IMO, shared tests are generic tests that don't have proper _require
rules, so they're hard-coded with explicit "_supported_fs xxx yyy". With
proper _require rules, there should be no shared tests at all, and we'd
try avoid adding new shared tests if possible.
Thanks,
Eryu
^ permalink raw reply
* [Buildroot] [PATCH] configs/mx51evk: Bump kernel version
From: Peter Korsgaard @ 2019-06-20 11:29 UTC (permalink / raw)
To: buildroot
In-Reply-To: <20190619174253.24352-1-festevam@gmail.com>
>>>>> "Fabio" == Fabio Estevam <festevam@gmail.com> writes:
> Bump the kernel version to 5.1.10.
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply
* Re: MIPS: ath79: regression after patch: sched/fair: do not expose some tracepoints to user if CONFIG_SCHEDSTATS is not set
From: Yafang Shao @ 2019-06-20 11:28 UTC (permalink / raw)
To: Oleksij Rempel; +Cc: Steven Rostedt, linux-mips, kernel
In-Reply-To: <20190617131257.4izz5lj7mhc24bm5@pengutronix.de>
On Mon, Jun 17, 2019 at 9:12 PM Oleksij Rempel <o.rempel@pengutronix.de> wrote:
>
> On Mon, Jun 17, 2019 at 09:01:50PM +0800, Yafang Shao wrote:
> > On Mon, Jun 17, 2019 at 1:39 PM Oleksij Rempel <o.rempel@pengutronix.de> wrote:
> > >
> > > On Mon, Jun 17, 2019 at 10:04:46AM +0800, Yafang Shao wrote:
> > > > On Fri, Jun 14, 2019 at 4:34 PM Oleksij Rempel <o.rempel@pengutronix.de> wrote:
> > > > >
> > > > > On Fri, Jun 14, 2019 at 01:56:04PM +0800, Yafang Shao wrote:
> > > > > > On Fri, Jun 14, 2019 at 12:02 AM Oleksij Rempel <o.rempel@pengutronix.de> wrote:
> > > > > > >
> > > > > > > On Thu, Jun 13, 2019 at 04:12:57PM +0800, Yafang Shao wrote:
> > > > > > > > On Thu, Jun 13, 2019 at 4:08 PM Yafang Shao <laoar.shao@gmail.com> wrote:
> > > > > > > > >
> > > > > > > > > On Thu, Jun 13, 2019 at 2:30 PM Oleksij Rempel <o.rempel@pengutronix.de> wrote:
> > > > > > > > > >
> > > > > > > > > > Hi,
> > > > > > > > > >
> > > > > > > > > > After patch:
> > > > > > > > > > -----------------------------------------------------
> > > > > > > > > > commit 2a09b5de235a6b5f76193a2ed46546a2944f98bf
> > > > > > > > > > Author: Yafang Shao <laoar.shao@gmail.com>
> > > > > > > > > > Date: Tue Mar 26 20:13:10 2019 +0800
> > > > > > > > > > sched/fair: do not expose some tracepoints to user if CONFIG_SCHEDSTATS is not set
> > > > > > > > > >
> > > > > > > > > > The tracepoints trace_sched_stat_{iowait, blocked, wait, sleep} should
> > > > > > > > > > be not exposed to user if CONFIG_SCHEDSTATS is not set.
> > > > > > > > > >
> > > > > > > > > > Link: http://lkml.kernel.org/r/1553602391-11926-3-git-send-email-laoar.shao@gmail.com
> > > > > > > > > >
> > > > > > > > > > Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> > > > > > > > > > Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
> > > > > > > > > > Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> > > > > > > > > > -----------------------------------------------------
> > > > > > > > > >
> > > > > > > > > > i can't boot kernel on MIPS based system Atheros ar9331. The boot
> > > > > > > > > > process ends with following oops:
> > > > > > > > > > -----------------------------------------------------
> > > > > > > > > > [ 0.000000] Built 1 zonelists, mobility grouping on. Total pages: 16256 [0/1518]
> > > > > > > > > > [ 0.000000] Kernel command line: ip=dhcp root=/dev/nfs nfsroot=192.168.23.4:/home/ore/nfsroot/dpt-module,v3,tcp
> > > > > > > > > > [ 0.000000] Dentry cache hash table entries: 8192 (order: 3, 32768 bytes)
> > > > > > > > > > [ 0.000000] Inode-cache hash table entries: 4096 (order: 2, 16384 bytes)
> > > > > > > > > > [ 0.000000] Writing ErrCtl register=00000000
> > > > > > > > > > [ 0.000000] Readback ErrCtl register=00000000
> > > > > > > > > > [ 0.000000] Memory: 56376K/65536K available (5376K kernel code, 437K rwdata, 1068K rodata, 1432K init, 214K bss, 9160K reserved, 0K cma-reserved)
> > > > > > > > > > [ 0.000000] random: get_random_u32 called from cache_random_seq_create+0x9c/0x170 with crng_init=0
> > > > > > > > > > [ 0.000000] SLUB: HWalign=32, Order=0-3, MinObjects=0, CPUs=1, Nodes=1
> > > > > > > > > > [ 0.000000] ftrace: allocating 18167 entries in 36 pages
> > > > > > > > > > [ 0.000000] CPU 0 Unable to handle kernel paging request at virtual address 00000000, epc == 00000000, ra == 00000000
> > > > > > > > > > [ 0.000000] Oops[#1]:
> > > > > > > > > > [ 0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted 5.2.0-rc4+ #308
> > > > > > > > > > [ 0.000000] $ 0 : 00000000 8007e5fc 00000003 00000002
> > > > > > > > > > [ 0.000000] $ 4 : 00000001 00000000 00000000 83c22470
> > > > > > > > > > [ 0.000000] $ 8 : 00000000 00000000 00000000 00000000
> > > > > > > > > > [ 0.000000] $12 : 806afe04 00000000 00000001 00000000
> > > > > > > > > > [ 0.000000] $16 : 800adc0c 800adc00 00000000 00000000
> > > > > > > > > > [ 0.000000] $20 : 00000000 0000048e 00000000 806c0000
> > > > > > > > > > [ 0.000000] $24 : 00000003 800619e4
> > > > > > > > > > [ 0.000000] $28 : 806ae000 806afe10 808b0000 00000000
> > > > > > > > > > [ 0.000000] Hi : 00000000
> > > > > > > > > > [ 0.000000] Lo : 00000000
> > > > > > > > > > [ 0.000000] epc : 00000000 0x0
> > > > > > > > > > [ 0.000000] ra : 00000000 0x0
> > > > > > > > > > [ 0.000000] Status: 10000002 KERNEL EXL
> > > > > > > > > > [ 0.000000] Cause : 10800008 (ExcCode 02)
> > > > > > > > > > [ 0.000000] BadVA : 00000000
> > > > > > > > > > [ 0.000000] PrId : 00019374 (MIPS 24Kc)
> > > > > > > > > > [ 0.000000] Modules linked in:
> > > > > > > > > > [ 0.000000] Process swapper (pid: 0, threadinfo=(ptrval), task=(ptrval), tls=00000000)
> > > > > > > > > > [ 0.000000] Stack : 00000002 8007e784 806ca284 00000000 800adc0c 00000000 80070eb0 8007108c
> > > > > > > > > > [ 0.000000] 83c03c00 801ab7d8 83c03b80 00000000 00000000 83c03b80 00000000 801109cc
> > > > > > > > > > [ 0.000000] 00000001 80880000 80880000 800c1318 00000000 ffffffff 806b0000 806b0000
> > > > > > > > > > [ 0.000000] 83c22470 0000048e 8075eb00 807706dc 806b0000 80753158 806b0000 80755209
> > > > > > > > > > [ 0.000000] 00000001 80880000 80880000 80726cc8 ffffffff 000046f7 00000024 00000003
> > > > > > > > > > [ 0.000000] ...
> > > > > > > > > > [ 0.000000] Call Trace:
> > > > > > > > > > [ 0.000000]
> > > > > > > > > > [ 0.000000] [<8007e784>] r4k_flush_icache_range+0x10/0x18
> > > > > > > > > > [ 0.000000] [<800adc0c>] preempt_count_sub+0x10/0xe4
> > > > > > > > > > [ 0.000000] [<80070eb0>] ftrace_caller+0x0/0x54
> > > > > > > > > > [ 0.000000] [<8007108c>] ftrace_make_nop+0x8c/0x94
> > > > > > > > > > [ 0.000000] [<801ab7d8>] __get_free_pages+0x2c/0x60
> > > > > > > > > > [ 0.000000] [<801109cc>] ftrace_process_locs+0x364/0x3ec
> > > > > > > > > > [ 0.000000] [<800c1318>] vprintk_default+0x34/0x40
> > > > > > > > > > [ 0.000000] [<80726cc8>] ftrace_init+0xb8/0x138
> > > > > > > > > > [ 0.000000] [<8071ac98>] start_kernel+0x290/0x584
> > > > > > > > > > [ 0.000000] [<8071a368>] unknown_bootoption+0x0/0x270
> > > > > > > > > > [ 0.000000]
> > > > > > > > > > [ 0.000000] Code: (Bad address in epc)
> > > > > > > > > > [ 0.000000]
> > > > > > > > > > [ 0.000000] ---[ end trace 64e6fa591c4a277c ]---
> > > > > > > > > > [ 0.000000] Kernel panic - not syncing: Fatal exception
> > > > > > > > > > [ 0.000000] Rebooting in
> > > > > > > > > > -----------------------------------------------------
> > > > > > > > > >
> > > > > > > > > > After reverting this patch I can normally boot the kernel.
> > > > > > > > > > The kernel is build with CONFIG_SCHEDSTATS not set.
> > > > > > > > > >
> > > > > > > > > > --
> > > > > > > > > > Pengutronix e.K. | |
> > > > > > > > > > Industrial Linux Solutions | http://www.pengutronix.de/ |
> > > > > > > > > > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> > > > > > > > > > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
> > > > > > > > >
> > > > > > > > > Hi Oleksij,
> > > > > > > > >
> > > > > > > > > This really makes me confused.
> > > > > > > > > If CONFIG_SCHEDSTATS is not set, trace_sched_stat_{iowait, blocked,
> > > > > > > > > wait, sleep} will be optimized out by
> > > > > > > > > the compiler. That should not effect other codes.
> > > > > > > > >
> > > > > > > > > Would you pls. try bellow command on your build server?
> > > > > > > > > $ objdump -dr kernel/sched/fair.o | awk '/>:$/ { F=$2 } /sched_stat/ {
> > > > > > > > > print F " " $0 }'
> > > > > > > > >
> > > > > > > >
> > > > > > > > Plus, could you pls. show me the difference on the objdump of these
> > > > > > > > two vmlinux (with and without my patch) ?
> > > > > > >
> > > > > > > Both files are in attachment.
> > > > > > >
> > > > > >
> > > > > > Hi Oleksij,
> > > > > >
> > > > > > Unfortunately I don't have a mips toolchain on hand.
> > > > > > It would be better if you could give me the disassembled code of
> > > > > > these two vmlinuxs.
> > > > > > I will try to build a cross toolchain for MIPS 24Kc, that may take some time.
> > > > >
> > > > > disassembled code is in attachment.
> > > > >
> > > > > --
> > > >
> > > > + Steve,
> > > >
> > > > Hi Oleksij,
> > > >
> > > > I guess this issue is related with __mcount_loc, but I don't have a
> > > > clear idea how to fix it yet.
> > > > It would be better if you could share your .config file as well.
> > > >
> > > > Hi Steve,
> > > >
> > > > Do you have any suggestion on this issue?
> > > > My guess is when we define a tracepoint as nop, there's something
> > > > wrong in __mcount_loc,
> > > > which will be used by MIPS and then this oops occurs.
> > >
> > > kernel config is in attachment.
> > >
> >
> > Hi Oleksij,
> >
> > What is the output of "ftrace: allocating %ld entries in %ld pages"
> > after revert this patch ?
> > I want to know whether this issue is related with the number of ftrace entries,
> > e.g, whehter more pages are allocated after this patch is reverted.
> >
> > In this oops messages, the output is "ftrace: allocating 18167 entries
> > in 36 pages".
>
> Hi Yafang,
>
> [ 0.000000] ftrace: allocating 17948 entries in 36 pages
>
> Do you need complete dmesg?
>
Sorry for the late response.
The complete dmesg is not needed for now.
With my patch, the number of ftrace entries are 17948.
Without my patch, the number of ftrace entries are 18167, which is 219
greater, that seems impossible.
Actually my patch can decrease the number of ftrace entries.
Are you sure this issue is only related to my patch ?
The rcu tracepoint patch [1] also use the TRACE_EVENT_NOP.
Are there any different with this patch ?
[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=4f5fbd78a7b40bab538ae0d316363530da751e42
Thanks
Yafang
^ permalink raw reply
* [Buildroot] [git commit] configs/mx51evk: Bump kernel version
From: Peter Korsgaard @ 2019-06-20 11:29 UTC (permalink / raw)
To: buildroot
commit: https://git.buildroot.net/buildroot/commit/?id=87372e6a47eb63dc45d15d4d0df478f6cec66680
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
Bump the kernel version to 5.1.10.
Signed-off-by: Fabio Estevam <festevam@gmail.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
configs/mx51evk_defconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/configs/mx51evk_defconfig b/configs/mx51evk_defconfig
index 3c2d56132d..0cb8f476cd 100644
--- a/configs/mx51evk_defconfig
+++ b/configs/mx51evk_defconfig
@@ -2,8 +2,8 @@
BR2_arm=y
BR2_cortex_a8=y
-# Linux headers same as kernel, a 4.17 series
-BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_17=y
+# Linux headers same as kernel, a 5.1 series
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_1=y
# System
BR2_TARGET_GENERIC_GETTY_PORT="ttymxc0"
@@ -28,7 +28,7 @@ BR2_TARGET_UBOOT_FORMAT_IMX=y
# Kernel
BR2_LINUX_KERNEL=y
BR2_LINUX_KERNEL_CUSTOM_VERSION=y
-BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.17.2"
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.1.10"
BR2_LINUX_KERNEL_DEFCONFIG="imx_v6_v7"
BR2_LINUX_KERNEL_DTS_SUPPORT=y
BR2_LINUX_KERNEL_INTREE_DTS_NAME="imx51-babbage"
^ permalink raw reply related
* Re: [PATCH] drm/self_refresh: Fix possible NULL deref in failure path
From: Daniel Vetter @ 2019-06-20 11:28 UTC (permalink / raw)
To: Sean Paul
Cc: Zain Wang, Maxime Ripard, Jose Souza, Tomasz Figa, David Airlie,
Sean Paul, dri-devel, Dan Carpenter, Sam Ravnborg
In-Reply-To: <20190619181951.192305-1-sean@poorly.run>
On Wed, Jun 19, 2019 at 02:19:47PM -0400, Sean Paul wrote:
> From: Sean Paul <seanpaul@chromium.org>
>
> If state allocation fails, we still try to give back the reference on
> it. Also initialize ret in case the crtc is not enabled and we hit the
> eject button.
>
> Fixes: 1452c25b0e60 ("drm: Add helpers to kick off self refresh mode in drivers")
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Jose Souza <jose.souza@intel.com>
> Cc: Zain Wang <wzz@rock-chips.com>
> Cc: Tomasz Figa <tfiga@chromium.org>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Sean Paul <seanpaul@chromium.org>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <maxime.ripard@bootlin.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: David Airlie <airlied@linux.ie>
> Cc: dri-devel@lists.freedesktop.org
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/drm_self_refresh_helper.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_self_refresh_helper.c b/drivers/gpu/drm/drm_self_refresh_helper.c
> index e0d2ad1f070cb..4b9424a8f1f1c 100644
> --- a/drivers/gpu/drm/drm_self_refresh_helper.c
> +++ b/drivers/gpu/drm/drm_self_refresh_helper.c
> @@ -69,14 +69,14 @@ static void drm_self_refresh_helper_entry_work(struct work_struct *work)
> struct drm_connector *conn;
> struct drm_connector_state *conn_state;
> struct drm_crtc_state *crtc_state;
> - int i, ret;
> + int i, ret = 0;
>
> drm_modeset_acquire_init(&ctx, 0);
>
> state = drm_atomic_state_alloc(dev);
> if (!state) {
> ret = -ENOMEM;
> - goto out;
> + goto out_drop_locks;
> }
>
> retry:
> @@ -116,6 +116,8 @@ static void drm_self_refresh_helper_entry_work(struct work_struct *work)
> }
>
> drm_atomic_state_put(state);
> +
> +out_drop_locks:
> drm_modeset_drop_locks(&ctx);
> drm_modeset_acquire_fini(&ctx);
> }
> --
> Sean Paul, Software Engineer, Google / Chromium OS
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply
* [Buildroot] [PATCH 4/4] package/linux-headers: drop support for 5.x headers
From: Peter Korsgaard @ 2019-06-20 11:28 UTC (permalink / raw)
To: buildroot
In-Reply-To: <20190618115733.28551-4-peter@korsgaard.com>
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:
> The 5.0.x series is now EOL and vulnerable to the "TCP SACK PANIC" issue.
> Drop support for it in linux-headers.
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply
* [Buildroot] [PATCH 3/4] amarula_vyasa_rk3288_defconfig: use same-as-kernel option for kernel headers
From: Peter Korsgaard @ 2019-06-20 11:28 UTC (permalink / raw)
To: buildroot
In-Reply-To: <20190618115733.28551-3-peter@korsgaard.com>
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:
> Instead of the to-be-removed 5.0 option.
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply
* [Buildroot] [PATCH 2/4] Config.in.legacy: add legacy entry for 4.20.x headers
From: Peter Korsgaard @ 2019-06-20 11:28 UTC (permalink / raw)
To: buildroot
In-Reply-To: <20190618115733.28551-2-peter@korsgaard.com>
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:
> Commit b3bba8e4254 (package/linux-headers: drop support 4.20 headers)
> removed the option for 4.20.x kernel headers, but forgot to add a legacy
> option. Add that now.
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply
* [Buildroot] [PATCH 1/4] {linux, linux-headers}: bump 4.{4, 9, 14, 19}.x / 5.1.x series
From: Peter Korsgaard @ 2019-06-20 11:28 UTC (permalink / raw)
To: buildroot
In-Reply-To: <20190618115733.28551-1-peter@korsgaard.com>
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:
> Includes fixes for the "TCP SACK PANIC" vulnerability:
> https://access.redhat.com/security/vulnerabilities/tcpsack
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply
* Re: [Qemu-devel] [PATCH v1 02/17] tests/vm: avoid image presence check and removal
From: Philippe Mathieu-Daudé @ 2019-06-20 11:07 UTC (permalink / raw)
To: Alex Bennée, qemu-devel; +Cc: Fam Zheng, Cleber Rosa
In-Reply-To: <f07129f7-2813-e7e9-79ae-94a026495ab9@redhat.com>
On 6/20/19 12:29 PM, Philippe Mathieu-Daudé wrote:
> On 6/19/19 9:40 PM, Alex Bennée wrote:
>> From: Cleber Rosa <crosa@redhat.com>
>>
>> Python's os.rename() will silently replace an existing file,
>> so there's no need for the extra check and removal.
>>
>> Reference: https://docs.python.org/3/library/os.html#os.rename
>> Signed-off-by: Cleber Rosa <crosa@redhat.com>
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
And now:
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
>> Message-Id: <20190613130718.3763-3-crosa@redhat.com>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
^ permalink raw reply
* Re: [PATCH][net-next] netns: restore ops before calling ops_exit_list
From: Eric Dumazet @ 2019-06-20 11:27 UTC (permalink / raw)
To: Li RongQing; +Cc: netdev
In-Reply-To: <1561029880-1666-1-git-send-email-lirongqing@baidu.com>
On Thu, Jun 20, 2019 at 7:24 AM Li RongQing <lirongqing@baidu.com> wrote:
>
> ops has been iterated to first element when call pre_exit, and
> it needs to restore from save_ops, not save ops to save_ops
>
> Fixes: d7d99872c144 ("netns: add pre_exit method to struct pernet_operations")
> Signed-off-by: Li RongQing <lirongqing@baidu.com>
Thanks for fixing this :)
Reviewed-by: Eric Dumazet <edumazet@google.com>
^ permalink raw reply
* [Buildroot] [git commit] package/linux-headers: drop support for 5.x headers
From: Peter Korsgaard @ 2019-06-20 11:27 UTC (permalink / raw)
To: buildroot
commit: https://git.buildroot.net/buildroot/commit/?id=9e9a480ae402e5f850c728a39b79ce43575c436d
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
The 5.0.x series is now EOL and vulnerable to the "TCP SACK PANIC" issue.
Drop support for it in linux-headers.
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
Config.in.legacy | 7 +++++++
linux/linux.hash | 1 -
| 5 -----
3 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/Config.in.legacy b/Config.in.legacy
index 2b8dc3b1ee..9d54026899 100644
--- a/Config.in.legacy
+++ b/Config.in.legacy
@@ -160,6 +160,13 @@ config BR2_KERNEL_HEADERS_4_20
Version 4.20.x of the Linux kernel headers are no longer
maintained upstream and are now removed.
+config BR2_KERNEL_HEADERS_5_0
+ bool "kernel headers version 5.0.x are no longer supported"
+ select BR2_LEGACY
+ help
+ Version 5.0.x of the Linux kernel headers are no longer
+ maintained upstream and are now removed.
+
comment "Legacy options removed in 2019.05"
config BR2_CSKY_DSP
diff --git a/linux/linux.hash b/linux/linux.hash
index 497e8e4d6f..205441dc25 100644
--- a/linux/linux.hash
+++ b/linux/linux.hash
@@ -1,6 +1,5 @@
# From https://www.kernel.org/pub/linux/kernel/v5.x/sha256sums.asc
sha256 11fd93207290272389ad284b8b042041d088fbee0ed5798e933bf8e91697d219 linux-5.1.11.tar.xz
-sha256 98d307a546c95a215dee675ffa4b63c2a7a29e7af839f0d8dfb96dbb61aac2d7 linux-5.0.21.tar.xz
# From https://www.kernel.org/pub/linux/kernel/v4.x/sha256sums.asc
sha256 266ee655620c3689ae94761970d6827fffc919760caf815427ad22730ba4381e linux-4.19.52.tar.xz
sha256 d7464c2379cdee46548ae9f848671f4669d4003af4034f3f738f2f0511ec75b3 linux-4.14.127.tar.xz
--git a/package/linux-headers/Config.in.host b/package/linux-headers/Config.in.host
index 38ee0a6ac2..adf342fce0 100644
--- a/package/linux-headers/Config.in.host
+++ b/package/linux-headers/Config.in.host
@@ -49,10 +49,6 @@ config BR2_KERNEL_HEADERS_4_19
depends on !BR2_csky
select BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_19
-config BR2_KERNEL_HEADERS_5_0
- bool "Linux 5.0.x kernel headers"
- select BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_0
-
config BR2_KERNEL_HEADERS_5_1
bool "Linux 5.1.x kernel headers"
select BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_1
@@ -305,7 +301,6 @@ config BR2_DEFAULT_KERNEL_HEADERS
default "4.9.182" if BR2_KERNEL_HEADERS_4_9
default "4.14.127" if BR2_KERNEL_HEADERS_4_14
default "4.19.52" if BR2_KERNEL_HEADERS_4_19
- default "5.0.21" if BR2_KERNEL_HEADERS_5_0
default "5.1.11" if BR2_KERNEL_HEADERS_5_1
default BR2_DEFAULT_KERNEL_VERSION if BR2_KERNEL_HEADERS_VERSION
default "custom" if BR2_KERNEL_HEADERS_CUSTOM_TARBALL
^ permalink raw reply related
* [Buildroot] [git commit] amarula_vyasa_rk3288_defconfig: use same-as-kernel option for kernel headers
From: Peter Korsgaard @ 2019-06-20 11:27 UTC (permalink / raw)
To: buildroot
commit: https://git.buildroot.net/buildroot/commit/?id=b769e54a92fe71b01fd5a899ccf60af668d8a60d
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
Instead of the to-be-removed 5.0 option.
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
configs/amarula_vyasa_rk3288_defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configs/amarula_vyasa_rk3288_defconfig b/configs/amarula_vyasa_rk3288_defconfig
index 6fd46b6455..760ad3f9f4 100644
--- a/configs/amarula_vyasa_rk3288_defconfig
+++ b/configs/amarula_vyasa_rk3288_defconfig
@@ -4,7 +4,7 @@ BR2_cortex_a17=y
BR2_ARM_FPU_NEON_VFPV4=y
# Linux headers same as kernel, a 5.0 series
-BR2_KERNEL_HEADERS_5_0=y
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_0=y
# Bootloader
BR2_TARGET_UBOOT=y
^ permalink raw reply related
* Re: [Qemu-devel] [PATCH 1/4] MAINTAINERS: Update file items for MIPS Malta board
From: Philippe Mathieu-Daudé @ 2019-06-20 11:13 UTC (permalink / raw)
To: Aleksandar Markovic, qemu-devel; +Cc: arikalo, amarkovic
In-Reply-To: <1561022396-20649-2-git-send-email-aleksandar.markovic@rt-rk.com>
On 6/20/19 11:19 AM, Aleksandar Markovic wrote:
> From: Aleksandar Markovic <amarkovic@wavecomp.com>
>
> hw/mips/gt64xxx_pci.c is used for Malta only, so it is logical to
> place this file in Malta board section of the MAINTAINERS file.
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Aleksandar Markovic <amarkovic@wavecomp.com>
> ---
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index acbad13..869e87b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -930,6 +930,7 @@ M: Aurelien Jarno <aurelien@aurel32.net>
> R: Aleksandar Rikalo <arikalo@wavecomp.com>
> S: Maintained
> F: hw/mips/mips_malta.c
> +F: hw/mips/gt64xxx_pci.c
> F: tests/acceptance/linux_ssh_mips_malta.py
>
> Mipssim
>
^ permalink raw reply
* [Buildroot] [git commit] Config.in.legacy: add legacy entry for 4.20.x headers
From: Peter Korsgaard @ 2019-06-20 11:27 UTC (permalink / raw)
To: buildroot
commit: https://git.buildroot.net/buildroot/commit/?id=8f60d30829b6b05426a3914b703d03130fe64c53
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
Commit b3bba8e4254 (package/linux-headers: drop support 4.20 headers)
removed the option for 4.20.x kernel headers, but forgot to add a legacy
option. Add that now.
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
Config.in.legacy | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/Config.in.legacy b/Config.in.legacy
index 75d6c723a9..2b8dc3b1ee 100644
--- a/Config.in.legacy
+++ b/Config.in.legacy
@@ -153,6 +153,13 @@ config BR2_GDB_VERSION_8_0
The 8.0.x version of gdb has been removed. Use a newer
version instead.
+config BR2_KERNEL_HEADERS_4_20
+ bool "kernel headers version 4.20.x are no longer supported"
+ select BR2_LEGACY
+ help
+ Version 4.20.x of the Linux kernel headers are no longer
+ maintained upstream and are now removed.
+
comment "Legacy options removed in 2019.05"
config BR2_CSKY_DSP
^ permalink raw reply related
* [Buildroot] [git commit] {linux, linux-headers}: bump 4.{4, 9, 14, 19}.x / 5.1.x series
From: Peter Korsgaard @ 2019-06-20 11:27 UTC (permalink / raw)
To: buildroot
commit: https://git.buildroot.net/buildroot/commit/?id=19f6b3281c03a1892900723c47cc766e6770e862
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
Includes fixes for the "TCP SACK PANIC" vulnerability:
https://access.redhat.com/security/vulnerabilities/tcpsack
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
linux/Config.in | 2 +-
linux/linux.hash | 10 +++++-----
| 10 +++++-----
3 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/linux/Config.in b/linux/Config.in
index 95ee1cf542..0bc9612551 100644
--- a/linux/Config.in
+++ b/linux/Config.in
@@ -121,7 +121,7 @@ endif
config BR2_LINUX_KERNEL_VERSION
string
- default "5.1.10" if BR2_LINUX_KERNEL_LATEST_VERSION
+ default "5.1.11" if BR2_LINUX_KERNEL_LATEST_VERSION
default "v4.19.13-cip1" if BR2_LINUX_KERNEL_LATEST_CIP_VERSION
default BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE \
if BR2_LINUX_KERNEL_CUSTOM_VERSION
diff --git a/linux/linux.hash b/linux/linux.hash
index 6477991daa..497e8e4d6f 100644
--- a/linux/linux.hash
+++ b/linux/linux.hash
@@ -1,8 +1,8 @@
# From https://www.kernel.org/pub/linux/kernel/v5.x/sha256sums.asc
-sha256 39063041532579cb7e9fab5837313a8e6639c1c583cd39c72b313b3abfa9fbcf linux-5.1.10.tar.xz
+sha256 11fd93207290272389ad284b8b042041d088fbee0ed5798e933bf8e91697d219 linux-5.1.11.tar.xz
sha256 98d307a546c95a215dee675ffa4b63c2a7a29e7af839f0d8dfb96dbb61aac2d7 linux-5.0.21.tar.xz
# From https://www.kernel.org/pub/linux/kernel/v4.x/sha256sums.asc
-sha256 7afa920d776f8ca3fc3ced5026cc02c5ccc960c58314050982c307589b5a8d70 linux-4.19.51.tar.xz
-sha256 6a2e89504d8560b132ab743a0206ffce026bff2697b705819421c5f125633970 linux-4.14.126.tar.xz
-sha256 8fcd223e11cba322801bc38cdb8b581d64c0115f585dcb6604de8561b574fced linux-4.9.181.tar.xz
-sha256 b2ab69813192d49b1b7f89257a3319ef3fd73a54f441f3296d68b744b1c681d3 linux-4.4.181.tar.xz
+sha256 266ee655620c3689ae94761970d6827fffc919760caf815427ad22730ba4381e linux-4.19.52.tar.xz
+sha256 d7464c2379cdee46548ae9f848671f4669d4003af4034f3f738f2f0511ec75b3 linux-4.14.127.tar.xz
+sha256 b16e12681a0638368479d73a9b1b8e9407c1ae4b7ae52fdf236d9e5657999695 linux-4.9.182.tar.xz
+sha256 c409d88f61cd9a37cbba36d5d9c8162263eb1e5c9380efaf880a3ec10cd88527 linux-4.4.182.tar.xz
--git a/package/linux-headers/Config.in.host b/package/linux-headers/Config.in.host
index eb957b4f12..38ee0a6ac2 100644
--- a/package/linux-headers/Config.in.host
+++ b/package/linux-headers/Config.in.host
@@ -301,12 +301,12 @@ endchoice
config BR2_DEFAULT_KERNEL_HEADERS
string
- default "4.4.181" if BR2_KERNEL_HEADERS_4_4
- default "4.9.181" if BR2_KERNEL_HEADERS_4_9
- default "4.14.126" if BR2_KERNEL_HEADERS_4_14
- default "4.19.51" if BR2_KERNEL_HEADERS_4_19
+ default "4.4.182" if BR2_KERNEL_HEADERS_4_4
+ default "4.9.182" if BR2_KERNEL_HEADERS_4_9
+ default "4.14.127" if BR2_KERNEL_HEADERS_4_14
+ default "4.19.52" if BR2_KERNEL_HEADERS_4_19
default "5.0.21" if BR2_KERNEL_HEADERS_5_0
- default "5.1.10" if BR2_KERNEL_HEADERS_5_1
+ default "5.1.11" if BR2_KERNEL_HEADERS_5_1
default BR2_DEFAULT_KERNEL_VERSION if BR2_KERNEL_HEADERS_VERSION
default "custom" if BR2_KERNEL_HEADERS_CUSTOM_TARBALL
default BR2_KERNEL_HEADERS_CUSTOM_REPO_VERSION \
^ permalink raw reply related
* Re: [Qemu-devel] [PATCH v1 04/17] tests/vm: add source repos on ubuntu.i386
From: Philippe Mathieu-Daudé @ 2019-06-20 11:06 UTC (permalink / raw)
To: Alex Bennée, qemu-devel; +Cc: Fam Zheng, Cleber Rosa
In-Reply-To: <20190619194021.8240-5-alex.bennee@linaro.org>
On 6/19/19 9:40 PM, Alex Bennée wrote:
> From: Cleber Rosa <crosa@redhat.com>
>
> Possibly because of different behavior on the newly update
> cloud-image, trying to run 'apt-get build-dep' results in:
>
> E: You must put some 'source' URIs in your sources.list
>
> This enables all source repos (even though some are not
> needed) for simplicity sake.
>
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Message-Id: <20190613130718.3763-5-crosa@redhat.com>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> tests/vm/ubuntu.i386 | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/vm/ubuntu.i386 b/tests/vm/ubuntu.i386
> index 7017e6d388..3ea459ee20 100755
> --- a/tests/vm/ubuntu.i386
> +++ b/tests/vm/ubuntu.i386
> @@ -77,6 +77,7 @@ class UbuntuX86VM(basevm.BaseVM):
> time.sleep(5)
> self.wait_ssh()
> # The previous update sometimes doesn't survive a reboot, so do it again
> + self.ssh_root_check("sed -ie s/^#\ deb-src/deb-src/g /etc/apt/sources.list")
> self.ssh_root_check("apt-get update")
> self.ssh_root_check("apt-get build-dep -y qemu")
> self.ssh_root_check("apt-get install -y libfdt-dev flex bison")
>
^ permalink raw reply
* Re: [Qemu-devel] [PATCH v1 01/17] tests/vm: avoid extra compressed image copy
From: Philippe Mathieu-Daudé @ 2019-06-20 11:07 UTC (permalink / raw)
To: Alex Bennée, qemu-devel; +Cc: Fam Zheng, Cleber Rosa
In-Reply-To: <20190619194021.8240-2-alex.bennee@linaro.org>
On 6/19/19 9:40 PM, Alex Bennée wrote:
> From: Cleber Rosa <crosa@redhat.com>
>
> The image copy is only really needed because xz doesn't know to
> properly decompress a file not named properly. Instead of
> decompressing to stdout, and having to rely on a shell, let's just
> create a link instead of copying the file.
>
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Message-Id: <20190613130718.3763-2-crosa@redhat.com>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> tests/vm/centos | 4 ++--
> tests/vm/freebsd | 4 ++--
> tests/vm/netbsd | 4 ++--
> tests/vm/openbsd | 4 ++--
> 4 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/tests/vm/centos b/tests/vm/centos
> index 7417b50af4..b00b46a8dc 100755
> --- a/tests/vm/centos
> +++ b/tests/vm/centos
> @@ -66,8 +66,8 @@ class CentosVM(basevm.BaseVM):
> cimg = self._download_with_cache("https://cloud.centos.org/centos/7/images/CentOS-7-x86_64-GenericCloud-1802.qcow2.xz")
> img_tmp = img + ".tmp"
> sys.stderr.write("Extracting the image...\n")
> - subprocess.check_call(["cp", "-f", cimg, img_tmp + ".xz"])
> - subprocess.check_call(["xz", "-dvf", img_tmp + ".xz"])
> + subprocess.check_call(["ln", "-f", cimg, img_tmp + ".xz"])
> + subprocess.check_call(["xz", "--keep", "-dvf", img_tmp + ".xz"])
> subprocess.check_call(["qemu-img", "resize", img_tmp, "50G"])
> self.boot(img_tmp, extra_args = ["-cdrom", self._gen_cloud_init_iso()])
> self.wait_ssh()
> diff --git a/tests/vm/freebsd b/tests/vm/freebsd
> index b0066017a6..5575c23a6f 100755
> --- a/tests/vm/freebsd
> +++ b/tests/vm/freebsd
> @@ -34,8 +34,8 @@ class FreeBSDVM(basevm.BaseVM):
> img_tmp_xz = img + ".tmp.xz"
> img_tmp = img + ".tmp"
> sys.stderr.write("Extracting the image...\n")
> - subprocess.check_call(["cp", "-f", cimg, img_tmp_xz])
> - subprocess.check_call(["xz", "-dvf", img_tmp_xz])
> + subprocess.check_call(["ln", "-f", cimg, img_tmp_xz])
> + subprocess.check_call(["xz", "--keep", "-dvf", img_tmp_xz])
> if os.path.exists(img):
> os.remove(img)
> os.rename(img_tmp, img)
> diff --git a/tests/vm/netbsd b/tests/vm/netbsd
> index 4c6624ea5e..d0508f4465 100755
> --- a/tests/vm/netbsd
> +++ b/tests/vm/netbsd
> @@ -34,8 +34,8 @@ class NetBSDVM(basevm.BaseVM):
> img_tmp_xz = img + ".tmp.xz"
> img_tmp = img + ".tmp"
> sys.stderr.write("Extracting the image...\n")
> - subprocess.check_call(["cp", "-f", cimg, img_tmp_xz])
> - subprocess.check_call(["xz", "-dvf", img_tmp_xz])
> + subprocess.check_call(["ln", "-f", cimg, img_tmp_xz])
> + subprocess.check_call(["xz", "--keep", "-dvf", img_tmp_xz])
> if os.path.exists(img):
> os.remove(img)
> os.rename(img_tmp, img)
> diff --git a/tests/vm/openbsd b/tests/vm/openbsd
> index 2105c01a26..87ec982489 100755
> --- a/tests/vm/openbsd
> +++ b/tests/vm/openbsd
> @@ -36,8 +36,8 @@ class OpenBSDVM(basevm.BaseVM):
> img_tmp_xz = img + ".tmp.xz"
> img_tmp = img + ".tmp"
> sys.stderr.write("Extracting the image...\n")
> - subprocess.check_call(["cp", "-f", cimg, img_tmp_xz])
> - subprocess.check_call(["xz", "-dvf", img_tmp_xz])
> + subprocess.check_call(["ln", "-f", cimg, img_tmp_xz])
> + subprocess.check_call(["xz", "--keep", "-dvf", img_tmp_xz])
> if os.path.exists(img):
> os.remove(img)
> os.rename(img_tmp, img)
>
^ permalink raw reply
* [PATCH][net-next] netns: restore ops before calling ops_exit_list
From: Li RongQing @ 2019-06-20 11:24 UTC (permalink / raw)
To: netdev, edumazet
ops has been iterated to first element when call pre_exit, and
it needs to restore from save_ops, not save ops to save_ops
Fixes: d7d99872c144 ("netns: add pre_exit method to struct pernet_operations")
Signed-off-by: Li RongQing <lirongqing@baidu.com>
---
net/core/net_namespace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c
index 89dc99a28978..198ce503ae73 100644
--- a/net/core/net_namespace.c
+++ b/net/core/net_namespace.c
@@ -345,7 +345,7 @@ static __net_init int setup_net(struct net *net, struct user_namespace *user_ns)
synchronize_rcu();
- saved_ops = ops;
+ ops = saved_ops;
list_for_each_entry_continue_reverse(ops, &pernet_list, list)
ops_exit_list(ops, &net_exit_list);
--
2.16.2
^ permalink raw reply related
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.