All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] cbus: fix comilation breakage
@ 2010-04-21 14:26 Alexander Shishkin
  2010-04-21 23:56 ` Paul Walmsley
  2010-04-22 22:11 ` [APPLIED] " Tony Lindgren
  0 siblings, 2 replies; 3+ messages in thread
From: Alexander Shishkin @ 2010-04-21 14:26 UTC (permalink / raw)
  To: linux-omap; +Cc: Tony Lindgren, Alexander Shishkin

Just tried to build n8x0_defconfig on the current master and
got cbus failing to compile due to implicit kzalloc() (and
others from slab.h) references. I'm not sure that including
slab.h directly is the right thing to do here, though.

Signed-off-by: Alexander Shishkin <ash@koowaldah.org>
---
 drivers/cbus/cbus.c         |    1 +
 drivers/cbus/retu-headset.c |    1 +
 drivers/cbus/retu-user.c    |    1 +
 drivers/cbus/retu-wdt.c     |    1 +
 drivers/cbus/tahvo-user.c   |    1 +
 5 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/drivers/cbus/cbus.c b/drivers/cbus/cbus.c
index 00c3c32..18260f2 100644
--- a/drivers/cbus/cbus.c
+++ b/drivers/cbus/cbus.c
@@ -26,6 +26,7 @@
 #include <linux/device.h>
 #include <linux/init.h>
 #include <linux/kernel.h>
+#include <linux/slab.h>
 #include <linux/delay.h>
 #include <linux/spinlock.h>
 #include <linux/gpio.h>
diff --git a/drivers/cbus/retu-headset.c b/drivers/cbus/retu-headset.c
index e798bc2..c38abf1 100644
--- a/drivers/cbus/retu-headset.c
+++ b/drivers/cbus/retu-headset.c
@@ -22,6 +22,7 @@
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/kernel.h>
+#include <linux/slab.h>
 #include <linux/delay.h>
 #include <linux/input.h>
 #include <linux/platform_device.h>
diff --git a/drivers/cbus/retu-user.c b/drivers/cbus/retu-user.c
index 0f35dc5..1a29492 100644
--- a/drivers/cbus/retu-user.c
+++ b/drivers/cbus/retu-user.c
@@ -23,6 +23,7 @@
 
 #include <linux/types.h>
 #include <linux/kernel.h>
+#include <linux/slab.h>
 #include <linux/interrupt.h>
 #include <linux/module.h>
 #include <linux/init.h>
diff --git a/drivers/cbus/retu-wdt.c b/drivers/cbus/retu-wdt.c
index 35932dd..79585d8 100644
--- a/drivers/cbus/retu-wdt.c
+++ b/drivers/cbus/retu-wdt.c
@@ -22,6 +22,7 @@
  */
 
 #include <linux/kernel.h>
+#include <linux/slab.h>
 #include <linux/module.h>
 #include <linux/device.h>
 #include <linux/init.h>
diff --git a/drivers/cbus/tahvo-user.c b/drivers/cbus/tahvo-user.c
index c0e8daf..01e7f20 100644
--- a/drivers/cbus/tahvo-user.c
+++ b/drivers/cbus/tahvo-user.c
@@ -23,6 +23,7 @@
 
 #include <linux/types.h>
 #include <linux/kernel.h>
+#include <linux/slab.h>
 #include <linux/interrupt.h>
 #include <linux/module.h>
 #include <linux/init.h>
-- 
1.5.6.5


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] cbus: fix comilation breakage
  2010-04-21 14:26 [PATCH] cbus: fix comilation breakage Alexander Shishkin
@ 2010-04-21 23:56 ` Paul Walmsley
  2010-04-22 22:11 ` [APPLIED] " Tony Lindgren
  1 sibling, 0 replies; 3+ messages in thread
From: Paul Walmsley @ 2010-04-21 23:56 UTC (permalink / raw)
  To: Alexander Shishkin; +Cc: linux-omap, Tony Lindgren

On Wed, 21 Apr 2010, Alexander Shishkin wrote:

> Just tried to build n8x0_defconfig on the current master and
> got cbus failing to compile due to implicit kzalloc() (and
> others from slab.h) references. I'm not sure that including
> slab.h directly is the right thing to do here, though.
> 
> Signed-off-by: Alexander Shishkin <ash@koowaldah.org>

Yep, hit the same problem here, this patch fixes the build.


- Paul

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [APPLIED] [PATCH] cbus: fix comilation breakage
  2010-04-21 14:26 [PATCH] cbus: fix comilation breakage Alexander Shishkin
  2010-04-21 23:56 ` Paul Walmsley
@ 2010-04-22 22:11 ` Tony Lindgren
  1 sibling, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2010-04-22 22:11 UTC (permalink / raw)
  To: linux-omap

This patch has been applied to the linux-omap
by youw fwiendly patch wobot.

Branch in linux-omap: cbus

Initial commit ID (Likely to change): 79b8b733f926a38ef8dc2f62a5aa5e9708f5deef

PatchWorks
http://patchwork.kernel.org/patch/93871/

Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=79b8b733f926a38ef8dc2f62a5aa5e9708f5deef



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-04-22 22:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-21 14:26 [PATCH] cbus: fix comilation breakage Alexander Shishkin
2010-04-21 23:56 ` Paul Walmsley
2010-04-22 22:11 ` [APPLIED] " Tony Lindgren

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.