All of lore.kernel.org
 help / color / mirror / Atom feed
From: Grant Edwards <grant.b.edwards@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] Interaction between SITE_METHOD=LOCAL and .patch files
Date: Tue, 7 Feb 2017 17:18:04 +0000 (UTC)	[thread overview]
Message-ID: <o7cvgb$209$1@blaine.gmane.org> (raw)
In-Reply-To: 0a532bbd-e625-a41e-ece3-6974bd63d4a2@mind.be

On 2017-02-07, Arnout Vandecappelle <arnout@mind.be> wrote:

>> After comparing build trees that worked with build trees that failed,
>> I finallythat setting SITE_METHOD = LOCAL prevents the application of
>> the .patch files present in the package directory. 
>
> It does. The technical reason for that is that SITE_METHOD = local
> is implemented using _OVERRIDE_SRCDIR, and for that we don't want to
> apply patches because the typical use case is to build some
> different version to which the patches wouldn't apply anyway.
>
> Also, when you set SITE_METHOD = local, there should be no reason to
> apply patches because you can just as well apply them in your custom
> tarball.

Can SITE_METHOD = local be used with a custom tarball?  My
understanding from the docs is that it requires an unpacked source
directory tree [in which, as you said, one can easily apply whatever
patches are required].

I agree that for the unpacked source directory tree use case, not
appying patches makes the most sense.

>  Indeed, it should be documented. Care to send a patch?

Will do.

-- 
Grant Edwards               grant.b.edwards        Yow! Somewhere in Tenafly,
                                  at               New Jersey, a chiropractor
                              gmail.com            is viewing "Leave it to
                                                   Beaver"!

  reply	other threads:[~2017-02-07 17:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-06 21:54 [Buildroot] Interaction between SITE_METHOD=LOCAL and .patch files Grant Edwards
2017-02-07 16:55 ` Arnout Vandecappelle
2017-02-07 17:18   ` Grant Edwards [this message]
2017-02-07 17:37     ` Grant Edwards
2017-02-07 19:47       ` Peter Korsgaard
2017-02-08  9:02         ` Thomas Petazzoni
2017-02-08  9:01     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='o7cvgb$209$1@blaine.gmane.org' \
    --to=grant.b.edwards@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.