From: "Michał Nazarewicz" <m.nazarewicz@samsung.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
'Daniel Walker' <dwalker@codeaurora.org>,
linux-mm@kvack.org, Pawel Osciak <p.osciak@samsung.com>,
'Xiaolin Zhang' <xiaolin.zhang@intel.com>,
'Hiremath Vaibhav' <hvaibhav@ti.com>,
'Robert Fekete' <robert.fekete@stericsson.com>,
'Marcus Lorentzon' <marcus.xm.lorentzon@stericsson.com>,
linux-kernel@vger.kernel.org,
'Kyungmin Park' <kyungmin.park@samsung.com>,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 2/4] mm: cma: Contiguous Memory Allocator added
Date: Thu, 22 Jul 2010 16:58:43 +0200 [thread overview]
Message-ID: <op.vf82j5m17p4s8u@pikus> (raw)
In-Reply-To: <20100722134056.GJ4737@rakim.wolfsonmicro.main>
On Thu, 22 Jul 2010 15:40:56 +0200, Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> On Thu, Jul 22, 2010 at 03:24:26PM +0200, Michał Nazarewicz wrote:
>
>> That's why command line is only intended as a way to overwrite the
>> defaults which are provided by the platform. In a final product,
>> configuration should be specified in platform code and not on
>> command line.
>
> Yeah, agreed though I'm not convinced we can't do it via userspace
> (initrd would give us a chance to do stuff early) or just kernel
> rebuilds.
If there's any other easy way of overwriting platform's default I'm happy
to listen. :)
>> >It sounds like apart from the way you're passing the configuration in
>> >you're doing roughly what I'd suggest. I'd expect that in a lot of
>> >cases the map could be satisfied from the default region so there'd be
>> >no need to explicitly set one up.
>
>> Platform can specify something like:
>
>> cma_defaults("reg=20M", "*/*=reg");
>
>> which would make all the drivers share 20 MiB region by default.
>
> Yes, exactly - probably you can even have a default region backed by
> normal vmalloc() RAM which would at least be able to take a stab at
> working by default.
Not sure what you mean here. vmalloc() allocated buffers cannot be used
with CMA since they are not contiguous in memory.
--
Best regards, _ _
| Humble Liege of Serenely Enlightened Majesty of o' \,=./ `o
| Computer Science, Michał "mina86" Nazarewicz (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--
WARNING: multiple messages have this Message-ID (diff)
From: "Michał Nazarewicz" <m.nazarewicz@samsung.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
'Daniel Walker' <dwalker@codeaurora.org>,
linux-mm@kvack.org, Pawel Osciak <p.osciak@samsung.com>,
'Xiaolin Zhang' <xiaolin.zhang@intel.com>,
'Hiremath Vaibhav' <hvaibhav@ti.com>,
'Robert Fekete' <robert.fekete@stericsson.com>,
'Marcus Lorentzon' <marcus.xm.lorentzon@stericsson.com>,
linux-kernel@vger.kernel.org,
'Kyungmin Park' <kyungmin.park@samsung.com>,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 2/4] mm: cma: Contiguous Memory Allocator added
Date: Thu, 22 Jul 2010 16:58:43 +0200 [thread overview]
Message-ID: <op.vf82j5m17p4s8u@pikus> (raw)
In-Reply-To: <20100722134056.GJ4737@rakim.wolfsonmicro.main>
On Thu, 22 Jul 2010 15:40:56 +0200, Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> On Thu, Jul 22, 2010 at 03:24:26PM +0200, Michał Nazarewicz wrote:
>
>> That's why command line is only intended as a way to overwrite the
>> defaults which are provided by the platform. In a final product,
>> configuration should be specified in platform code and not on
>> command line.
>
> Yeah, agreed though I'm not convinced we can't do it via userspace
> (initrd would give us a chance to do stuff early) or just kernel
> rebuilds.
If there's any other easy way of overwriting platform's default I'm happy
to listen. :)
>> >It sounds like apart from the way you're passing the configuration in
>> >you're doing roughly what I'd suggest. I'd expect that in a lot of
>> >cases the map could be satisfied from the default region so there'd be
>> >no need to explicitly set one up.
>
>> Platform can specify something like:
>
>> cma_defaults("reg=20M", "*/*=reg");
>
>> which would make all the drivers share 20 MiB region by default.
>
> Yes, exactly - probably you can even have a default region backed by
> normal vmalloc() RAM which would at least be able to take a stab at
> working by default.
Not sure what you mean here. vmalloc() allocated buffers cannot be used
with CMA since they are not contiguous in memory.
--
Best regards, _ _
| Humble Liege of Serenely Enlightened Majesty of o' \,=./ `o
| Computer Science, Michał "mina86" Nazarewicz (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-07-22 14:57 UTC|newest]
Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-20 15:51 [PATCH 0/4] The Contiguous Memory Allocator Michal Nazarewicz
2010-07-20 15:51 ` Michal Nazarewicz
2010-07-20 15:51 ` [PATCH 1/4] lib: rbtree: rb_root_init() function added Michal Nazarewicz
2010-07-20 15:51 ` [PATCH 2/4] mm: cma: Contiguous Memory Allocator added Michal Nazarewicz
2010-07-20 15:51 ` [PATCH 3/4] mm: cma: Test device and application added Michal Nazarewicz
2010-07-20 15:51 ` [PATCH 4/4] arm: Added CMA to Aquila and Goni Michal Nazarewicz
2010-07-20 18:15 ` [PATCH 2/4] mm: cma: Contiguous Memory Allocator added Daniel Walker
2010-07-20 18:15 ` Daniel Walker
2010-07-20 19:14 ` Michał Nazarewicz
2010-07-20 19:14 ` Michał Nazarewicz
2010-07-20 19:38 ` Daniel Walker
2010-07-20 19:38 ` Daniel Walker
2010-07-21 12:01 ` Michał Nazarewicz
2010-07-21 12:01 ` Michał Nazarewicz
2010-07-21 17:35 ` Daniel Walker
2010-07-21 17:35 ` Daniel Walker
2010-07-21 18:11 ` Michał Nazarewicz
2010-07-21 18:11 ` Michał Nazarewicz
2010-07-21 18:19 ` Daniel Walker
2010-07-21 18:19 ` Daniel Walker
2010-07-21 18:38 ` Michał Nazarewicz
2010-07-21 18:38 ` Michał Nazarewicz
2010-07-21 18:58 ` Daniel Walker
2010-07-21 18:58 ` Daniel Walker
2010-07-21 19:21 ` Michał Nazarewicz
2010-07-21 19:21 ` Michał Nazarewicz
2010-07-21 19:37 ` Daniel Walker
2010-07-21 19:37 ` Daniel Walker
2010-07-21 19:53 ` Michał Nazarewicz
2010-07-21 19:53 ` Michał Nazarewicz
2010-07-21 20:03 ` Daniel Walker
2010-07-21 20:03 ` Daniel Walker
2010-07-21 20:22 ` Michał Nazarewicz
2010-07-21 20:22 ` Michał Nazarewicz
2010-07-21 20:34 ` Daniel Walker
2010-07-21 20:34 ` Daniel Walker
2010-07-21 20:43 ` Michał Nazarewicz
2010-07-21 20:43 ` Michał Nazarewicz
2010-07-21 20:45 ` Daniel Walker
2010-07-21 20:45 ` Daniel Walker
2010-07-21 20:56 ` Michał Nazarewicz
2010-07-21 20:56 ` Michał Nazarewicz
2010-07-21 21:01 ` Daniel Walker
2010-07-21 21:01 ` Daniel Walker
2010-07-22 9:34 ` Michał Nazarewicz
2010-07-22 9:34 ` Michał Nazarewicz
2010-07-21 13:52 ` Mark Brown
2010-07-21 13:52 ` Mark Brown
2010-07-21 14:31 ` Michał Nazarewicz
2010-07-21 14:31 ` Michał Nazarewicz
2010-07-21 18:24 ` Mark Brown
2010-07-21 18:24 ` Mark Brown
2010-07-21 18:41 ` Michał Nazarewicz
2010-07-21 18:41 ` Michał Nazarewicz
2010-07-22 9:06 ` Mark Brown
2010-07-22 9:06 ` Mark Brown
2010-07-22 9:25 ` Marek Szyprowski
2010-07-22 9:25 ` Marek Szyprowski
2010-07-22 10:52 ` Mark Brown
2010-07-22 10:52 ` Mark Brown
2010-07-22 11:30 ` Michał Nazarewicz
2010-07-22 11:30 ` Michał Nazarewicz
2010-07-22 12:46 ` Mark Brown
2010-07-22 12:46 ` Mark Brown
2010-07-22 13:24 ` Michał Nazarewicz
2010-07-22 13:24 ` Michał Nazarewicz
2010-07-22 13:40 ` Mark Brown
2010-07-22 13:40 ` Mark Brown
2010-07-22 14:58 ` Michał Nazarewicz [this message]
2010-07-22 14:58 ` Michał Nazarewicz
2010-07-22 15:05 ` Mark Brown
2010-07-22 15:05 ` Mark Brown
2010-07-20 20:52 ` Jonathan Corbet
2010-07-20 20:52 ` Jonathan Corbet
2010-07-21 10:16 ` Michał Nazarewicz
2010-07-21 10:16 ` Michał Nazarewicz
2010-07-21 0:12 ` Jonathan Corbet
2010-07-21 0:12 ` Jonathan Corbet
2010-07-22 5:37 ` FUJITA Tomonori
2010-07-22 5:37 ` FUJITA Tomonori
2010-07-22 7:28 ` Marek Szyprowski
2010-07-22 7:28 ` Marek Szyprowski
2010-07-22 9:35 ` FUJITA Tomonori
2010-07-22 9:35 ` FUJITA Tomonori
2010-07-22 9:50 ` Michał Nazarewicz
2010-07-22 9:50 ` Michał Nazarewicz
2010-07-22 10:17 ` FUJITA Tomonori
2010-07-22 10:17 ` FUJITA Tomonori
2010-07-22 10:55 ` Mark Brown
2010-07-22 10:55 ` Mark Brown
2010-07-22 11:49 ` Michał Nazarewicz
2010-07-22 11:49 ` Michał Nazarewicz
2010-07-22 4:54 ` Zach Pfeffer
2010-07-22 4:54 ` Zach Pfeffer
2010-07-22 7:49 ` Marek Szyprowski
2010-07-22 7:49 ` Marek Szyprowski
2010-07-23 7:06 ` Pawel Osciak
2010-07-23 7:06 ` Pawel Osciak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=op.vf82j5m17p4s8u@pikus \
--to=m.nazarewicz@samsung.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dwalker@codeaurora.org \
--cc=hvaibhav@ti.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=m.szyprowski@samsung.com \
--cc=marcus.xm.lorentzon@stericsson.com \
--cc=p.osciak@samsung.com \
--cc=robert.fekete@stericsson.com \
--cc=xiaolin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.