From: m.nazarewicz@samsung.com (Michał Nazarewicz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 2/4] mm: cma: Contiguous Memory Allocator added
Date: Wed, 28 Jul 2010 10:53:17 +0200 [thread overview]
Message-ID: <op.vgjpm3it7p4s8u@pikus> (raw)
In-Reply-To: <20100727120841.GC11468@n2100.arm.linux.org.uk>
>> +static inline dma_addr_t __must_check
>> +cma_alloc(const struct device *dev, const char *kind,
>> + size_t size, dma_addr_t alignment)
>> +{
>> + return dev ? -EINVAL : __cma_alloc(dev, kind, size, alignment);
On Tue, 27 Jul 2010 14:08:41 +0200, Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:
> So I can't use this to allocate memory for anything but a NULL device?
>> +static inline int
>> +cma_info(struct cma_info *info, const struct device *dev, const char *kind)
>> +{
>> + return dev ? -EINVAL : __cma_info(info, dev, kind);
> This won't return information for anything but a NULL device?
Obviously a bug. Thanks for spotting that.
--
Best regards, _ _
| Humble Liege of Serenely Enlightened Majesty of o' \,=./ `o
| Computer Science, Micha? "mina86" Nazarewicz (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--
WARNING: multiple messages have this Message-ID (diff)
From: "Michał Nazarewicz" <m.nazarewicz@samsung.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Daniel Walker <dwalker@codeaurora.org>,
Jonathan Corbet <corbet@lwn.net>,
Pawel Osciak <p.osciak@samsung.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
linux-kernel@vger.kernel.org, Hiremath Vaibhav <hvaibhav@ti.com>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
linux-mm@kvack.org, Kyungmin Park <kyungmin.park@samsung.com>,
Zach Pfeffer <zpfeffer@codeaurora.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCHv2 2/4] mm: cma: Contiguous Memory Allocator added
Date: Wed, 28 Jul 2010 10:53:17 +0200 [thread overview]
Message-ID: <op.vgjpm3it7p4s8u@pikus> (raw)
In-Reply-To: <20100727120841.GC11468@n2100.arm.linux.org.uk>
>> +static inline dma_addr_t __must_check
>> +cma_alloc(const struct device *dev, const char *kind,
>> + size_t size, dma_addr_t alignment)
>> +{
>> + return dev ? -EINVAL : __cma_alloc(dev, kind, size, alignment);
On Tue, 27 Jul 2010 14:08:41 +0200, Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:
> So I can't use this to allocate memory for anything but a NULL device?
>> +static inline int
>> +cma_info(struct cma_info *info, const struct device *dev, const char *kind)
>> +{
>> + return dev ? -EINVAL : __cma_info(info, dev, kind);
> This won't return information for anything but a NULL device?
Obviously a bug. Thanks for spotting that.
--
Best regards, _ _
| Humble Liege of Serenely Enlightened Majesty of o' \,=./ `o
| Computer Science, Michał "mina86" Nazarewicz (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--
WARNING: multiple messages have this Message-ID (diff)
From: "Michał Nazarewicz" <m.nazarewicz@samsung.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Daniel Walker <dwalker@codeaurora.org>,
Jonathan Corbet <corbet@lwn.net>,
Pawel Osciak <p.osciak@samsung.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
linux-kernel@vger.kernel.org, Hiremath Vaibhav <hvaibhav@ti.com>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
linux-mm@kvack.org, Kyungmin Park <kyungmin.park@samsung.com>,
Zach Pfeffer <zpfeffer@codeaurora.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCHv2 2/4] mm: cma: Contiguous Memory Allocator added
Date: Wed, 28 Jul 2010 10:53:17 +0200 [thread overview]
Message-ID: <op.vgjpm3it7p4s8u@pikus> (raw)
In-Reply-To: <20100727120841.GC11468@n2100.arm.linux.org.uk>
>> +static inline dma_addr_t __must_check
>> +cma_alloc(const struct device *dev, const char *kind,
>> + size_t size, dma_addr_t alignment)
>> +{
>> + return dev ? -EINVAL : __cma_alloc(dev, kind, size, alignment);
On Tue, 27 Jul 2010 14:08:41 +0200, Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:
> So I can't use this to allocate memory for anything but a NULL device?
>> +static inline int
>> +cma_info(struct cma_info *info, const struct device *dev, const char *kind)
>> +{
>> + return dev ? -EINVAL : __cma_info(info, dev, kind);
> This won't return information for anything but a NULL device?
Obviously a bug. Thanks for spotting that.
--
Best regards, _ _
| Humble Liege of Serenely Enlightened Majesty of o' \,=./ `o
| Computer Science, Michał "mina86" Nazarewicz (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-07-28 8:53 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-26 14:11 [PATCHv2 0/4] The Contiguous Memory Allocator Michal Nazarewicz
2010-07-26 14:40 ` Michal Nazarewicz
2010-07-26 14:11 ` Michal Nazarewicz
2010-07-26 14:11 ` [PATCHv2 1/4] lib: rbtree: rb_root_init() function added Michal Nazarewicz
2010-07-26 14:40 ` Michal Nazarewicz
2010-07-26 14:11 ` Michal Nazarewicz
2010-07-26 14:11 ` [PATCHv2 2/4] mm: cma: Contiguous Memory Allocator added Michal Nazarewicz
2010-07-26 14:40 ` Michal Nazarewicz
2010-07-26 14:11 ` Michal Nazarewicz
2010-07-26 14:11 ` [PATCHv2 3/4] mm: cma: Test device and application added Michal Nazarewicz
2010-07-26 14:40 ` Michal Nazarewicz
2010-07-26 14:11 ` Michal Nazarewicz
2010-07-26 14:11 ` [PATCHv2 4/4] arm: Added CMA to Aquila and Goni Michal Nazarewicz
2010-07-26 14:40 ` Michal Nazarewicz
2010-07-26 14:11 ` Michal Nazarewicz
2010-07-26 20:28 ` [PATCHv2 2/4] mm: cma: Contiguous Memory Allocator added Hans Verkuil
2010-07-26 20:28 ` Hans Verkuil
2010-07-26 20:28 ` Hans Verkuil
2010-07-27 7:41 ` Marek Szyprowski
2010-07-27 7:41 ` Marek Szyprowski
2010-07-27 7:41 ` Marek Szyprowski
2010-07-27 16:27 ` Hans Verkuil
2010-07-27 16:27 ` Hans Verkuil
2010-07-27 16:27 ` Hans Verkuil
2010-07-28 9:04 ` Marek Szyprowski
2010-07-28 9:04 ` Marek Szyprowski
2010-07-28 9:04 ` Marek Szyprowski
2010-08-01 13:26 ` Hans Verkuil
2010-08-01 13:26 ` Hans Verkuil
2010-08-01 13:26 ` Hans Verkuil
2010-08-02 15:51 ` Michał Nazarewicz
2010-08-02 15:51 ` Michał Nazarewicz
2010-08-02 15:51 ` Michał Nazarewicz
2010-08-03 7:19 ` Hans Verkuil
2010-08-03 7:19 ` Hans Verkuil
2010-08-03 7:19 ` Hans Verkuil
2010-08-06 13:31 ` Michał Nazarewicz
2010-08-06 13:31 ` Michał Nazarewicz
2010-08-06 13:31 ` Michał Nazarewicz
2010-07-27 12:08 ` Russell King - ARM Linux
2010-07-27 12:08 ` Russell King - ARM Linux
2010-07-27 12:08 ` Russell King - ARM Linux
2010-07-27 12:45 ` Marek Szyprowski
2010-07-27 12:45 ` Marek Szyprowski
2010-07-27 12:45 ` Marek Szyprowski
2010-07-27 12:58 ` Jonathan Corbet
2010-07-27 12:58 ` Jonathan Corbet
2010-07-27 12:58 ` Jonathan Corbet
2010-07-27 13:46 ` Marek Szyprowski
2010-07-27 13:46 ` Marek Szyprowski
2010-07-27 13:46 ` Marek Szyprowski
2010-07-27 14:21 ` FUJITA Tomonori
2010-07-27 14:21 ` FUJITA Tomonori
2010-07-27 14:21 ` FUJITA Tomonori
2010-07-28 8:53 ` Michał Nazarewicz [this message]
2010-07-28 8:53 ` Michał Nazarewicz
2010-07-28 8:53 ` Michał Nazarewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=op.vgjpm3it7p4s8u@pikus \
--to=m.nazarewicz@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.