* [xen-unstable test] 11825: regressions - FAIL
@ 2012-02-02 15:21 xen.org
2012-02-02 15:31 ` Ian Jackson
0 siblings, 1 reply; 5+ messages in thread
From: xen.org @ 2012-02-02 15:21 UTC (permalink / raw)
To: xen-devel; +Cc: ian.jackson
flight 11825 xen-unstable real [real]
http://www.chiark.greenend.org.uk/~xensrcts/logs/11825/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-i386-pair 6 xen-install/dst_host fail REGR. vs. 11643
test-amd64-i386-pair 5 xen-install/src_host fail REGR. vs. 11643
test-amd64-i386-xl-credit2 4 xen-install fail REGR. vs. 11643
test-amd64-i386-pv 4 xen-install fail REGR. vs. 11643
test-amd64-i386-rhel6hvm-intel 4 xen-install fail REGR. vs. 11643
test-amd64-i386-rhel6hvm-amd 4 xen-install fail REGR. vs. 11643
test-amd64-i386-xl 4 xen-install fail REGR. vs. 11643
test-amd64-i386-xl-multivcpu 4 xen-install fail REGR. vs. 11643
test-amd64-i386-xl-winxpsp3-vcpus1 4 xen-install fail REGR. vs. 11643
test-amd64-i386-win-vcpus1 4 xen-install fail REGR. vs. 11643
test-amd64-i386-xend-winxpsp3 4 xen-install fail REGR. vs. 11643
test-amd64-i386-xl-win7-amd64 4 xen-install fail REGR. vs. 11643
test-amd64-i386-xl-win-vcpus1 4 xen-install fail REGR. vs. 11643
test-amd64-i386-win 4 xen-install fail REGR. vs. 11643
Regressions which are regarded as allowable (not blocking):
build-i386 4 xen-build fail like 11637
build-i386-oldkern 4 xen-build fail like 11637
Tests which did not succeed, but are not blocking:
test-amd64-amd64-xl-pcipt-intel 9 guest-start fail never pass
test-i386-i386-xl 1 xen-build-check(1) blocked n/a
test-i386-i386-pv 1 xen-build-check(1) blocked n/a
test-amd64-amd64-xl-win7-amd64 13 guest-stop fail never pass
test-i386-i386-pair 1 xen-build-check(1) blocked n/a
test-i386-i386-xl-win 1 xen-build-check(1) blocked n/a
test-i386-i386-win 1 xen-build-check(1) blocked n/a
test-amd64-amd64-xl-win 13 guest-stop fail never pass
test-i386-i386-xl-winxpsp3 1 xen-build-check(1) blocked n/a
test-amd64-amd64-win 16 leak-check/check fail never pass
test-amd64-amd64-xl-winxpsp3 13 guest-stop fail never pass
version targeted for testing:
xen e2e2df4224e2
baseline version:
xen e2722b24dc09
------------------------------------------------------------
People who touched revisions under test:
Adin Scannell <adin@scannell.ca>
Alex Zeffertt <alex.zeffertt@eu.citrix.com>
Andres Lagar-Cavilla <andres@lagarcavilla.org>
Andrew Cooper <andrew.cooper3@citrix.com>
Daniel De Graaf <dgdegra@tycho.nsa.gov>
Dario Faggioli <dario.faggioli@citrix.com>
Diego Ongaro <diego.ongaro@citrix.com>
Dietmar Hahn <dietmar.hahn@ts.fujitsu.com>
Ian Campbell <ian.campbell@citrix.com>
Ian Jackson <ian.jackson@eu.citrix.com>
Jan Beulich <jbeulich@suse.com>
Jim Fehlig <jfehlig@suse.com>
juergen.gross@ts.fujitsu.com
Keir Fraser <keir@xen.org>
Olaf Hering <olaf@aepfle.de>
Paulian Bogdan Marinca <paulian@marinca.net>
Roger Pau Monne <roger.pau@entel.upc.edu>
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Tim Deegan <tim@xen.org>
Wei Wang <wei.wang2@amd.com>
------------------------------------------------------------
jobs:
build-amd64 pass
build-i386 fail
build-amd64-oldkern pass
build-i386-oldkern fail
build-amd64-pvops pass
build-i386-pvops pass
test-amd64-amd64-xl pass
test-amd64-i386-xl fail
test-i386-i386-xl blocked
test-amd64-i386-rhel6hvm-amd fail
test-amd64-amd64-xl-win7-amd64 fail
test-amd64-i386-xl-win7-amd64 fail
test-amd64-i386-xl-credit2 fail
test-amd64-amd64-xl-pcipt-intel fail
test-amd64-i386-rhel6hvm-intel fail
test-amd64-i386-xl-multivcpu fail
test-amd64-amd64-pair pass
test-amd64-i386-pair fail
test-i386-i386-pair blocked
test-amd64-amd64-xl-sedf-pin pass
test-amd64-amd64-pv pass
test-amd64-i386-pv fail
test-i386-i386-pv blocked
test-amd64-amd64-xl-sedf pass
test-amd64-i386-win-vcpus1 fail
test-amd64-i386-xl-win-vcpus1 fail
test-amd64-i386-xl-winxpsp3-vcpus1 fail
test-amd64-amd64-win fail
test-amd64-i386-win fail
test-i386-i386-win blocked
test-amd64-amd64-xl-win fail
test-i386-i386-xl-win blocked
test-amd64-i386-xend-winxpsp3 fail
test-amd64-amd64-xl-winxpsp3 fail
test-i386-i386-xl-winxpsp3 blocked
------------------------------------------------------------
sg-report-flight on woking.cam.xci-test.com
logs: /home/xc_osstest/logs
images: /home/xc_osstest/images
Logs, config files, etc. are available at
http://www.chiark.greenend.org.uk/~xensrcts/logs
Test harness code can be found at
http://xenbits.xensource.com/gitweb?p=osstest.git;a=summary
Not pushing.
(No revision log; it would be 1340 lines long.)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [xen-unstable test] 11825: regressions - FAIL
2012-02-02 15:21 [xen-unstable test] 11825: regressions - FAIL xen.org
@ 2012-02-02 15:31 ` Ian Jackson
2012-02-02 15:49 ` Tim Deegan
2012-02-02 15:51 ` Ian Jackson
0 siblings, 2 replies; 5+ messages in thread
From: Ian Jackson @ 2012-02-02 15:31 UTC (permalink / raw)
To: xen-devel@lists.xensource.com, Andres Lagar-Cavilla, Tim Deegan
xen.org writes ("[xen-unstable test] 11825: regressions - FAIL"):
> build-i386 4 xen-build fail like 11637
gcc -O1 -fno-omit-frame-pointer -m32 -march=i686 -g -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement -fno-builtin -fno-common -Wredundant-decls -iwithprefix include -Werror -Wno-pointer-arith -pipe -I/home/osstest/build.11825.build-i386/xen-unstable/xen/include -I/home/osstest/build.11825.build-i386/xen-unstable/xen/include/asm-x86/mach-generic -I/home/osstest/build.11825.build-i386/xen-unstable/xen/include/asm-x86/mach-default -msoft-float -fno-stack-protector -fno-exceptions -Wnested-externs -fno-optimize-sibling-calls -nostdinc -g -D__XEN__ -include /home/osstest/build.11825.build-i386/xen-unstable/xen/include/xen/config.h -DVERBOSE -fno-omit-frame-pointer -DCONFIG_FRAME_POINTER -MMD -MF .memory.o.d -c memory.c -o memory.o
cc1: warnings being treated as errors
memory.c: In function 'guest_remove_page':
memory.c:192: error: implicit declaration of function 'mem_sharing_unshare_page'
memory.c:192: error: nested extern declaration of 'mem_sharing_unshare_page'
make[4]: *** [memory.o] Error 1
make[4]: Leaving directory `/home/osstest/build.11825.build-i386/xen-unstable/xen/common'
make[3]: *** [/home/osstest/build.11825.build-i386/xen-unstable/xen/common/built_in.o] Error 2
I think this is due to the changeset below.
Ian.
# HG changeset patch
# User Andres Lagar-Cavilla <andres@lagarcavilla.org>
# Date 1328185651 0
# Node ID e2e2df4224e221ff7bbb9a75083d3b21f70a47d2
# Parent 23fe4a60190f11efc750af51f55228183f7bb736
x86/mm: Fix balooning+sharing
Never mind that ballooning a shared page makes no sense. We still fix it
because it may be exercised.
Signed-off-by: Andres Lagar-Cavilla <andres@lagarcavilla.org>
Signed-off-by: Tim Deegan <tim@xen.org>
Committed-by: Tim Deegan <tim@xen.org>
diff -r 23fe4a60190f -r e2e2df4224e2 xen/common/memory.c
--- a/xen/common/memory.c Thu Feb 02 12:23:18 2012 +0000
+++ b/xen/common/memory.c Thu Feb 02 12:27:31 2012 +0000
@@ -183,14 +183,14 @@ int guest_remove_page(struct domain *d,
page = mfn_to_page(mfn);
#ifdef CONFIG_X86
- /* If gmfn is shared, just drop the guest reference (which may or may not
- * free the page) */
- if(p2m_is_shared(p2mt))
+ if ( p2m_is_shared(p2mt) )
{
- put_page_and_type(page);
- guest_physmap_remove_page(d, gmfn, mfn, 0);
- put_gfn(d, gmfn);
- return 1;
+ /* Unshare the page, bail out on error. We unshare because
+ * we might be the only one using this shared page, and we
+ * need to trigger proper cleanup. Once done, this is
+ * like any other page. */
+ if ( mem_sharing_unshare_page(d, gmfn, 0) )
+ return 0;
}
#endif /* CONFIG_X86 */
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [xen-unstable test] 11825: regressions - FAIL
2012-02-02 15:31 ` Ian Jackson
@ 2012-02-02 15:49 ` Tim Deegan
2012-02-02 15:52 ` Ian Jackson
2012-02-02 15:51 ` Ian Jackson
1 sibling, 1 reply; 5+ messages in thread
From: Tim Deegan @ 2012-02-02 15:49 UTC (permalink / raw)
To: Ian Jackson; +Cc: xen-devel@lists.xensource.com, Andres Lagar-Cavilla
At 15:31 +0000 on 02 Feb (1328196702), Ian Jackson wrote:
> xen.org writes ("[xen-unstable test] 11825: regressions - FAIL"):
> > build-i386 4 xen-build fail like 11637
>
> gcc -O1 -fno-omit-frame-pointer -m32 -march=i686 -g -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement -fno-builtin -fno-common -Wredundant-decls -iwithprefix include -Werror -Wno-pointer-arith -pipe -I/home/osstest/build.11825.build-i386/xen-unstable/xen/include -I/home/osstest/build.11825.build-i386/xen-unstable/xen/include/asm-x86/mach-generic -I/home/osstest/build.11825.build-i386/xen-unstable/xen/include/asm-x86/mach-default -msoft-float -fno-stack-protector -fno-exceptions -Wnested-externs -fno-optimize-sibling-calls -nostdinc -g -D__XEN__ -include /home/osstest/build.11825.build-i386/xen-unstable/xen/include/xen/config.h -DVERBOSE -fno-omit-frame-pointer -DCONFIG_FRAME_POINTER -MMD -MF .memory.o.d -c memory.c -o memory.o
> cc1: warnings being treated as errors
> memory.c: In function 'guest_remove_page':
> memory.c:192: error: implicit declaration of function 'mem_sharing_unshare_page'
> memory.c:192: error: nested extern declaration of 'mem_sharing_unshare_page'
> make[4]: *** [memory.o] Error 1
Oops! Fixed by 24691:3432abcf9380.
Cheers,
Tim.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [xen-unstable test] 11825: regressions - FAIL
2012-02-02 15:31 ` Ian Jackson
2012-02-02 15:49 ` Tim Deegan
@ 2012-02-02 15:51 ` Ian Jackson
1 sibling, 0 replies; 5+ messages in thread
From: Ian Jackson @ 2012-02-02 15:51 UTC (permalink / raw)
To: xen-devel@lists.xensource.com, Andres Lagar-Cavilla, Tim Deegan
Cc: Keir Fraser
Ian Jackson writes ("Re: [xen-unstable test] 11825: regressions - FAIL"):
> memory.c: In function 'guest_remove_page':
> memory.c:192: error: implicit declaration of function 'mem_sharing_unshare_page'
> memory.c:192: error: nested extern declaration of 'mem_sharing_unshare_page'
> make[4]: *** [memory.o] Error 1
> make[4]: Leaving directory `/home/osstest/build.11825.build-i386/xen-unstable/xen/common'
> make[3]: *** [/home/osstest/build.11825.build-i386/xen-unstable/xen/common/built_in.o] Error 2
The patch below fixes it for me, but I'm not sure whether replacing
CONFIG_X86 with __x86_64__ is proper.
x86/mm: Fix 32-bit build by disabling some memory sharing code
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
diff -r dcc6d57e4c07 xen/common/memory.c
--- a/xen/common/memory.c Thu Feb 02 15:28:58 2012 +0000
+++ b/xen/common/memory.c Thu Feb 02 15:49:50 2012 +0000
@@ -182,7 +182,7 @@ int guest_remove_page(struct domain *d,
}
page = mfn_to_page(mfn);
-#ifdef CONFIG_X86
+#ifdef __x86_64__
if ( p2m_is_shared(p2mt) )
{
/* Unshare the page, bail out on error. We unshare because
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [xen-unstable test] 11825: regressions - FAIL
2012-02-02 15:49 ` Tim Deegan
@ 2012-02-02 15:52 ` Ian Jackson
0 siblings, 0 replies; 5+ messages in thread
From: Ian Jackson @ 2012-02-02 15:52 UTC (permalink / raw)
To: Tim Deegan; +Cc: xen-devel@lists.xensource.com, Andres Lagar-Cavilla
Tim Deegan writes ("Re: [xen-unstable test] 11825: regressions - FAIL"):
> At 15:31 +0000 on 02 Feb (1328196702), Ian Jackson wrote:
> > xen.org writes ("[xen-unstable test] 11825: regressions - FAIL"):
> > > build-i386 4 xen-build fail like 11637
...
> > cc1: warnings being treated as errors
> > memory.c: In function 'guest_remove_page':
> > memory.c:192: error: implicit declaration of function 'mem_sharing_unshare_page'
> > memory.c:192: error: nested extern declaration of 'mem_sharing_unshare_page'
> > make[4]: *** [memory.o] Error 1
>
> Oops! Fixed by 24691:3432abcf9380.
Ah, great, thanks.
Ian.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-02-02 15:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-02 15:21 [xen-unstable test] 11825: regressions - FAIL xen.org
2012-02-02 15:31 ` Ian Jackson
2012-02-02 15:49 ` Tim Deegan
2012-02-02 15:52 ` Ian Jackson
2012-02-02 15:51 ` Ian Jackson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.