[PATCH v1] tools: ipxe: update for fixing build with GCC10

[PATCH v1] tools: ipxe: update for fixing build with GCC10

[Olaf Hering]

Update to v1.21.1 to fix build in Tumbleweed, which has been broken
since months due to lack of new release.

Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
 tools/firmware/etherboot/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/firmware/etherboot/Makefile b/tools/firmware/etherboot/Makefile
index 0de30599bf..ed9e11305f 100644
--- a/tools/firmware/etherboot/Makefile
+++ b/tools/firmware/etherboot/Makefile
@@ -10,7 +10,7 @@ else
 IPXE_GIT_URL ?= git://git.ipxe.org/ipxe.git
 endif
 
-IPXE_GIT_TAG := 1dd56dbd11082fb622c2ed21cfaced4f47d798a6
+IPXE_GIT_TAG := 988d2c13cdf0f0b4140685af35ced70ac5b3283c
 
 IPXE_TARBALL_URL ?= $(XEN_EXTFILES_URL)/ipxe-git-$(IPXE_GIT_TAG).tar.gz
 

Re: [PATCH v1] tools: ipxe: update for fixing build with GCC10

[Wei Liu]

On Mon, Jan 04, 2021 at 12:52:23PM +0100, Olaf Hering wrote:
> Update to v1.21.1 to fix build in Tumbleweed, which has been broken
> since months due to lack of new release.
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>

Acked-by: Wei Liu <wl@xen.org>

> ---
>  tools/firmware/etherboot/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/firmware/etherboot/Makefile b/tools/firmware/etherboot/Makefile
> index 0de30599bf..ed9e11305f 100644
> --- a/tools/firmware/etherboot/Makefile
> +++ b/tools/firmware/etherboot/Makefile
> @@ -10,7 +10,7 @@ else
>  IPXE_GIT_URL ?= git://git.ipxe.org/ipxe.git
>  endif
>  
> -IPXE_GIT_TAG := 1dd56dbd11082fb622c2ed21cfaced4f47d798a6
> +IPXE_GIT_TAG := 988d2c13cdf0f0b4140685af35ced70ac5b3283c
>  
>  IPXE_TARBALL_URL ?= $(XEN_EXTFILES_URL)/ipxe-git-$(IPXE_GIT_TAG).tar.gz
>  

[xen-unstable-smoke test] 158191: regressions - FAIL

[osstest service owner]

flight 158191 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/158191/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 158134
 test-armhf-armhf-xl           8 xen-boot                 fail REGR. vs. 158134

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-debianhvm-amd64  1 build-check(1)        blocked n/a
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  edf5b22022aea0a76eaeb36cc060d984340e1e18
baseline version:
 xen                  7ba2ab495be54f608cb47440e1497b2795bd301a

Last test of basis   158134  2021-01-04 15:01:26 Z    1 days
Failing since        158142  2021-01-05 02:00:25 Z    1 days    7 attempts
Testing same since   158174  2021-01-05 22:00:25 Z    0 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Bertrand Marquis <bertrand.marquis@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Manuel Bouyer <bouyer@antioche.eu.org>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Olaf Hering <olaf@aepfle.de>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Wei Liu <wl@xen.org>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  fail    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          blocked 
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    blocked 
 test-amd64-amd64-libvirt                                     blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 432 lines long.)

Re: [xen-unstable-smoke test] 158191: regressions - FAIL

[Jan Beulich]

On 06.01.2021 07:46, osstest service owner wrote:
> flight 158191 xen-unstable-smoke real [real]
> http://logs.test-lab.xenproject.org/osstest/logs/158191/
> 
> Regressions :-(
> 
> Tests which did not succeed and are blocking,
> including tests which could not be run:
>  build-amd64                   6 xen-build                fail REGR. vs. 158134

Perhaps an unwanted effect of c7115531ea8e "tools: ipxe: update for
fixing build with GCC10"? Did the build perhaps fetch a pre-cooked
tarball before?

Jan

make[6]: Entering directory '/home/osstest/build.158191.build-amd64/xen/tools/firmware/etherboot'
set -e; if ! /usr/bin/wget -c -O _ipxe.tar.gz http://xenbits.xen.org/xen-extfiles/ipxe-git-988d2c13cdf0f0b4140685af35ced70ac5b3283c.tar.gz; then \
	git clone file:////osstest/IPXE-GIT-FORBIDDEN ipxe.git; \
	(cd ipxe.git && git archive --format=tar --prefix=ipxe/ \
	988d2c13cdf0f0b4140685af35ced70ac5b3283c | gzip -n >../_ipxe.tar.gz); \
	rm -rf ipxe.git; \
fi
--2021-01-06 05:12:39--  http://xenbits.xen.org/xen-extfiles/ipxe-git-988d2c13cdf0f0b4140685af35ced70ac5b3283c.tar.gz
Resolving cache (cache)... 172.16.148.6
Connecting to cache (cache)|172.16.148.6|:3128... connected.
Proxy request sent, awaiting response... 404 Not Found
2021-01-06 05:12:39 ERROR 404: Not Found.

Cloning into 'ipxe.git'...
fatal: '//osstest/IPXE-GIT-FORBIDDEN' does not appear to be a git repository
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
make[6]: Leaving directory '/home/osstest/build.158191.build-amd64/xen/tools/firmware/etherboot'
make[6]: *** [Makefile:36: ipxe.tar.gz] Error 128

Re: [PATCH v1] tools: ipxe: update for fixing build with GCC10 [and 1 more messages]

[Ian Jackson]

Wei Liu writes ("Re: [PATCH v1] tools: ipxe: update for fixing build with GCC10"):
> On Mon, Jan 04, 2021 at 12:52:23PM +0100, Olaf Hering wrote:
> > Update to v1.21.1 to fix build in Tumbleweed, which has been broken
> > since months due to lack of new release.
> > 
> > Signed-off-by: Olaf Hering <olaf@aepfle.de>
> 
> Acked-by: Wei Liu <wl@xen.org>
...
> > -IPXE_GIT_TAG := 1dd56dbd11082fb622c2ed21cfaced4f47d798a6
> > +IPXE_GIT_TAG := 988d2c13cdf0f0b4140685af35ced70ac5b3283c

Unfortunately this broke the build, but it's not really your fault:

osstest service owner writes ("[xen-unstable-smoke test] 158191: regressions - FAIL"):
> Tests which did not succeed and are blocking,
> including tests which could not be run:
>  build-amd64                   6 xen-build                fail REGR. vs. 158134

--2021-01-06 01:27:19--  http://xenbits.xen.org/xen-extfiles/ipxe-git-988d2c13cdf0f0b4140685af35ced70ac5b3283c.tar.gz
Resolving cache (cache)... 172.16.148.6
Connecting to cache (cache)|172.16.148.6|:3128... connected.
Proxy request sent, awaiting response... 404 Not Found

We currently insist on having have a tarball.

That means someone (me, I guess) has to do a "git archive" and put the
resulting tarball in the right place on xenbits.  Unfortunately this
is still manual, but we don't update ipxe very often.

I have made the tarball now.

Ian.

Re: [PATCH v1] tools: ipxe: update for fixing build with GCC10 [and 1 more messages]

[Wei Liu]

On Wed, Jan 06, 2021 at 11:23:43AM +0000, Ian Jackson wrote:
> Wei Liu writes ("Re: [PATCH v1] tools: ipxe: update for fixing build with GCC10"):
> > On Mon, Jan 04, 2021 at 12:52:23PM +0100, Olaf Hering wrote:
> > > Update to v1.21.1 to fix build in Tumbleweed, which has been broken
> > > since months due to lack of new release.
> > > 
> > > Signed-off-by: Olaf Hering <olaf@aepfle.de>
> > 
> > Acked-by: Wei Liu <wl@xen.org>
> ...
> > > -IPXE_GIT_TAG := 1dd56dbd11082fb622c2ed21cfaced4f47d798a6
> > > +IPXE_GIT_TAG := 988d2c13cdf0f0b4140685af35ced70ac5b3283c
> 
> Unfortunately this broke the build, but it's not really your fault:
> 
> osstest service owner writes ("[xen-unstable-smoke test] 158191: regressions - FAIL"):
> > Tests which did not succeed and are blocking,
> > including tests which could not be run:
> >  build-amd64                   6 xen-build                fail REGR. vs. 158134
> 
> --2021-01-06 01:27:19--  http://xenbits.xen.org/xen-extfiles/ipxe-git-988d2c13cdf0f0b4140685af35ced70ac5b3283c.tar.gz
> Resolving cache (cache)... 172.16.148.6
> Connecting to cache (cache)|172.16.148.6|:3128... connected.
> Proxy request sent, awaiting response... 404 Not Found
> 
> We currently insist on having have a tarball.
> 
> That means someone (me, I guess) has to do a "git archive" and put the
> resulting tarball in the right place on xenbits.  Unfortunately this
> is still manual, but we don't update ipxe very often.
> 

Wouldn't the build host just fetch from the upstream git tree? That's
why I didn't ask you to make a tarball -- I was waiting to see if this
could pass osstest before asking.

> I have made the tarball now.

Thanks.

Wei.

> 
> Ian.

Re: [PATCH v1] tools: ipxe: update for fixing build with GCC10 [and 1 more messages]

[Wei Liu]

On Wed, Jan 06, 2021 at 11:25:34AM +0000, Wei Liu wrote:
> On Wed, Jan 06, 2021 at 11:23:43AM +0000, Ian Jackson wrote:
> > Wei Liu writes ("Re: [PATCH v1] tools: ipxe: update for fixing build with GCC10"):
> > > On Mon, Jan 04, 2021 at 12:52:23PM +0100, Olaf Hering wrote:
> > > > Update to v1.21.1 to fix build in Tumbleweed, which has been broken
> > > > since months due to lack of new release.
> > > > 
> > > > Signed-off-by: Olaf Hering <olaf@aepfle.de>
> > > 
> > > Acked-by: Wei Liu <wl@xen.org>
> > ...
> > > > -IPXE_GIT_TAG := 1dd56dbd11082fb622c2ed21cfaced4f47d798a6
> > > > +IPXE_GIT_TAG := 988d2c13cdf0f0b4140685af35ced70ac5b3283c
> > 
> > Unfortunately this broke the build, but it's not really your fault:
> > 
> > osstest service owner writes ("[xen-unstable-smoke test] 158191: regressions - FAIL"):
> > > Tests which did not succeed and are blocking,
> > > including tests which could not be run:
> > >  build-amd64                   6 xen-build                fail REGR. vs. 158134
> > 
> > --2021-01-06 01:27:19--  http://xenbits.xen.org/xen-extfiles/ipxe-git-988d2c13cdf0f0b4140685af35ced70ac5b3283c.tar.gz
> > Resolving cache (cache)... 172.16.148.6
> > Connecting to cache (cache)|172.16.148.6|:3128... connected.
> > Proxy request sent, awaiting response... 404 Not Found
> > 
> > We currently insist on having have a tarball.
> > 
> > That means someone (me, I guess) has to do a "git archive" and put the
> > resulting tarball in the right place on xenbits.  Unfortunately this
> > is still manual, but we don't update ipxe very often.
> > 
> 
> Wouldn't the build host just fetch from the upstream git tree? That's
> why I didn't ask you to make a tarball -- I was waiting to see if this
> could pass osstest before asking.
> 

Never mind. It seems that I have missed the change of requirement...

Wei.

Re: [PATCH v1] tools: ipxe: update for fixing build with GCC10 [and 1 more messages]

[Ian Jackson]

Wei Liu writes ("Re: [PATCH v1] tools: ipxe: update for fixing build with GCC10 [and 1 more messages]"):
> On Wed, Jan 06, 2021 at 11:25:34AM +0000, Wei Liu wrote:
> > Wouldn't the build host just fetch from the upstream git tree? That's
> > why I didn't ask you to make a tarball -- I was waiting to see if this
> > could pass osstest before asking.

The build system's ability to do that has been nobbled in osstest for
a very long time.

> Never mind. It seems that I have missed the change of requirement...

I don't think there has been a change.  But it's been a long time
since we did an ipxe update.

Ian.

Re: [PATCH v1] tools: ipxe: update for fixing build with GCC10 [and 1 more messages]

[Olaf Hering]

[-- Attachment #1: Type: text/plain, Size: 214 bytes --]

Am Wed, 6 Jan 2021 11:23:43 +0000
schrieb Ian Jackson <iwj@xenproject.org>:

> We currently insist on having have a tarball.

Maybe add a comment to IPXE_GIT_TAG which lists the required extra steps.

Olaf

[-- Attachment #2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]