All of lore.kernel.org
 help / color / mirror / Atom feed
* [xen-unstable-smoke test] 183276: regressions - FAIL
@ 2023-10-06  3:32 osstest service owner
  2023-10-06  8:42 ` Roger Pau Monné
  0 siblings, 1 reply; 2+ messages in thread
From: osstest service owner @ 2023-10-06  3:32 UTC (permalink / raw)
  To: xen-devel

flight 183276 xen-unstable-smoke real [real]
flight 183279 xen-unstable-smoke real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/183276/
http://logs.test-lab.xenproject.org/osstest/logs/183279/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl         18 guest-start/debian.repeat fail REGR. vs. 183270

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  295514ff7550626de4fb5e43b51deb25d9331cd5
baseline version:
 xen                  02c98966360b76052779b0186784437af88f301e

Last test of basis   183270  2023-10-05 13:03:52 Z    0 days
Testing same since   183272  2023-10-05 16:00:24 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tamas K Lengyel <tamas@tklengyel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit 295514ff7550626de4fb5e43b51deb25d9331cd5
Author: Jan Beulich <jbeulich@suse.com>
Date:   Mon Oct 2 17:11:27 2023 +0200

    common: convert vCPU info area registration
    
    Switch to using map_guest_area(). Noteworthy differences from
    map_vcpu_info():
    - remote vCPU-s are paused rather than checked for being down (which in
      principle can change right after the check),
    - the domain lock is taken for a much smaller region,
    - the error code for an attempt to re-register the area is now -EBUSY,
    - we could in principle permit de-registration when no area was
      previously registered (which would permit "probing", if necessary for
      anything).
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
    Acked-by: Julien Grall <jgrall@amazon.com>
    Release-acked-by: Henry Wang <Henry.Wang@arm.com>

commit 60e544a8c58fdc720de05f6a721178f9516436d1
Author: Jan Beulich <jbeulich@suse.com>
Date:   Mon Oct 2 17:11:26 2023 +0200

    x86: introduce GADDR based secondary time area registration alternative
    
    The registration by virtual/linear address has downsides: The access is
    expensive for HVM/PVH domains. Furthermore for 64-bit PV domains the area
    is inaccessible (and hence cannot be updated by Xen) when in guest-user
    mode.
    
    Introduce a new vCPU operation allowing to register the secondary time
    area by guest-physical address.
    
    An at least theoretical downside to using physically registered areas is
    that PV then won't see dirty (and perhaps also accessed) bits set in its
    respective page table entries.
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
    Acked-by: Julien Grall <jgrall@amazon.com>
    Release-acked-by: Henry Wang <Henry.Wang@arm.com>

commit d5df44275e7af690ef18b56cc58762ce33a37149
Author: Jan Beulich <jbeulich@suse.com>
Date:   Mon Oct 2 17:11:25 2023 +0200

    domain: introduce GADDR based runstate area registration alternative
    
    The registration by virtual/linear address has downsides: At least on
    x86 the access is expensive for HVM/PVH domains. Furthermore for 64-bit
    PV domains the area is inaccessible (and hence cannot be updated by Xen)
    when in guest-user mode.
    
    Introduce a new vCPU operation allowing to register the runstate area by
    guest-physical address.
    
    An at least theoretical downside to using physically registered areas is
    that PV then won't see dirty (and perhaps also accessed) bits set in its
    respective page table entries.
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
    Acked-by: Julien Grall <jgrall@amazon.com>
    Release-acked-by: Henry Wang <Henry.Wang@arm.com>

commit eadc288cbb0ddc432ff8c9c639fb25b7538325de
Author: Jan Beulich <jbeulich@suse.com>
Date:   Mon Oct 2 17:11:24 2023 +0200

    domain: map/unmap GADDR based shared guest areas
    
    The registration by virtual/linear address has downsides: At least on
    x86 the access is expensive for HVM/PVH domains. Furthermore for 64-bit
    PV domains the areas are inaccessible (and hence cannot be updated by
    Xen) when in guest-user mode, and for HVM guests they may be
    inaccessible when Meltdown mitigations are in place. (There are yet
    more issues.)
    
    In preparation of the introduction of new vCPU operations allowing to
    register the respective areas (one of the two is x86-specific) by
    guest-physical address, flesh out the map/unmap functions.
    
    Noteworthy differences from map_vcpu_info():
    - areas can be registered more than once (and de-registered),
    - remote vCPU-s are paused rather than checked for being down (which in
      principle can change right after the check),
    - the domain lock is taken for a much smaller region.
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
    Reviewed-by: Julien Grall <jgrall@amazon.com>
    Release-acked-by: Henry Wang <Henry.Wang@arm.com>

commit c4dde71e3e6961f817e2a574ce4918041cb30fb9
Author: Jan Beulich <jbeulich@suse.com>
Date:   Wed Oct 4 15:53:31 2023 +0200

    x86/mem-sharing: copy GADDR based shared guest areas
    
    In preparation of the introduction of new vCPU operations allowing to
    register the respective areas (one of the two is x86-specific) by
    guest-physical address, add the necessary fork handling (with the
    backing function yet to be filled in).
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
    Acked-by: Tamas K Lengyel <tamas@tklengyel.com>
    Release-acked-by: Henry Wang <Henry.Wang@arm.com>

commit c2e285ea0e6dea9cc6f4578e49d76075a153baa0
Author: Jan Beulich <jbeulich@suse.com>
Date:   Mon Oct 2 17:11:22 2023 +0200

    x86: update GADDR based secondary time area
    
    Before adding a new vCPU operation to register the secondary time area
    by guest-physical address, add code to actually keep such areas up-to-
    date.
    
    Note that pages aren't marked dirty when written to (matching the
    handling of space mapped by map_vcpu_info()), on the basis that the
    registrations are lost anyway across migration (or would need re-
    populating at the target for transparent migration). Plus the contents
    of the areas in question have to be deemed volatile in the first place
    (so saving a "most recent" value is pretty meaningless even for e.g.
    snapshotting).
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
    Release-acked-by: Henry Wang <Henry.Wang@arm.com>

commit e1ddb822ca2e3c332d42d508e2a5fbd7be018815
Author: Jan Beulich <jbeulich@suse.com>
Date:   Mon Oct 2 17:11:21 2023 +0200

    domain: update GADDR based runstate guest area
    
    Before adding a new vCPU operation to register the runstate area by
    guest-physical address, add code to actually keep such areas up-to-date.
    
    Note that updating of the area will be done exclusively following the
    model enabled by VMASST_TYPE_runstate_update_flag for virtual-address
    based registered areas.
    
    Note further that pages aren't marked dirty when written to (matching
    the handling of space mapped by map_vcpu_info()), on the basis that the
    registrations are lost anyway across migration (or would need re-
    populating at the target for transparent migration). Plus the contents
    of the areas in question have to be deemed volatile in the first place
    (so saving a "most recent" value is pretty meaningless even for e.g.
    snapshotting).
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
    Reviewed-by: Julien Grall <jgrall@amazon.com>
    Release-acked-by: Henry Wang <Henry.Wang@arm.com>

commit c4630e316240508f3fb619678adc4cfb47bf13d2
Author: Jan Beulich <jbeulich@suse.com>
Date:   Mon Oct 2 17:11:20 2023 +0200

    domain: GADDR based shared guest area registration alternative - teardown
    
    In preparation of the introduction of new vCPU operations allowing to
    register the respective areas (one of the two is x86-specific) by
    guest-physical address, add the necessary domain cleanup hooks.
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Reviewed-by: Julien Grall <jgrall@amazon.com>
    Acked-by: Roger Pau Monné <roger.pau@citrix.com>
    Release-acked-by: Henry Wang <Henry.Wang@arm.com>

commit 826da6e30cf37a22b3f32dba33477856125df91b
Author: Jan Beulich <jbeulich@suse.com>
Date:   Mon Oct 2 17:11:19 2023 +0200

    x86/shim: zap runstate and time area handles during shutdown
    
    While likely the guest would just re-register the same areas after
    a possible resume, let's not take this for granted and avoid the risk of
    otherwise corrupting guest memory.
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Acked-by: Roger Pau Monné <roger.pau@citrix.com>
    Release-acked-by: Henry Wang <Henry.Wang@arm.com>

commit 9a499a84a2724757ad59b684e7858dfb60521290
Author: Roger Pau Monne <roger.pau@citrix.com>
Date:   Mon Oct 2 17:11:18 2023 +0200

    mem_sharing/fork: do not attempt to populate vcpu_info page
    
    Instead let map_vcpu_info() and it's call to get_page_from_gfn()
    populate the page in the child as needed.  Also remove the bogus
    copy_domain_page(): should be placed before the call to map_vcpu_info(),
    as the later can update the contents of the vcpu_info page.
    
    Note that this eliminates a bug in copy_vcpu_settings(): The function did
    allocate a new page regardless of the GFN already having a mapping, thus in
    particular breaking the case of two vCPU-s having their info areas on the same
    page.
    
    Fixes: 41548c5472a3 ('mem_sharing: VM forking')
    Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
    Acked-by: Tamas K Lengyel <tamas@tklengyel.com>
    Release-acked-by: Henry Wang <Henry.Wang@arm.com>
(qemu changes not included)


^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-06  8:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-06  3:32 [xen-unstable-smoke test] 183276: regressions - FAIL osstest service owner
2023-10-06  8:42 ` Roger Pau Monné

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.