All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 1/1] network memory allocator.
Date: 14 Aug 2006 13:40:21 +0200	[thread overview]
Message-ID: <p73k65ba6l6.fsf@verdi.suse.de> (raw)
In-Reply-To: <20060814110359.GA27704@2ka.mipt.ru>

Evgeniy Polyakov <johnpol@2ka.mipt.ru> writes:

> Design notes.
> Original idea was to store meta information used for allocation in an
> AVL tree [1], but since I found a way to use some "unused" fields in struct page,
> tree is unused in the allocator.

But there seems to be still an AVL tree in there?


> Benchmarks with trivial epoll based web server showed noticeble (more
> than 40%) imrovements of the request rates (1600-1800 requests per
> second vs. more than 2300 ones). It can be described by more
> cache-friendly freeing algorithm, by tighter objects packing and thus
> reduced cache line ping-pongs, reduced lookups into higher-layer caches
> and so on.

So what are its drawbacks compared to slab/kmalloc? 

Also if it really performs that much better it might be a good
idea to replace all of kmalloc() with it, but doing that
would require a lot more benchmarks with various workloads
and small and big machines first.

-Andi


WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <ak@suse.de>
To: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 1/1] network memory allocator.
Date: 14 Aug 2006 13:40:21 +0200	[thread overview]
Message-ID: <p73k65ba6l6.fsf@verdi.suse.de> (raw)
In-Reply-To: <20060814110359.GA27704@2ka.mipt.ru>

Evgeniy Polyakov <johnpol@2ka.mipt.ru> writes:

> Design notes.
> Original idea was to store meta information used for allocation in an
> AVL tree [1], but since I found a way to use some "unused" fields in struct page,
> tree is unused in the allocator.

But there seems to be still an AVL tree in there?


> Benchmarks with trivial epoll based web server showed noticeble (more
> than 40%) imrovements of the request rates (1600-1800 requests per
> second vs. more than 2300 ones). It can be described by more
> cache-friendly freeing algorithm, by tighter objects packing and thus
> reduced cache line ping-pongs, reduced lookups into higher-layer caches
> and so on.

So what are its drawbacks compared to slab/kmalloc? 

Also if it really performs that much better it might be a good
idea to replace all of kmalloc() with it, but doing that
would require a lot more benchmarks with various workloads
and small and big machines first.

-Andi

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2006-08-14 11:40 UTC|newest]

Thread overview: 104+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-14 11:04 [PATCH 1/1] network memory allocator Evgeniy Polyakov
2006-08-14 11:04 ` Evgeniy Polyakov
2006-08-14 11:22 ` David Miller
2006-08-14 11:22   ` David Miller, Evgeniy Polyakov
2006-08-14 11:32   ` Evgeniy Polyakov
2006-08-14 11:32     ` Evgeniy Polyakov
2006-08-14 11:40 ` Andi Kleen [this message]
2006-08-14 11:40   ` Andi Kleen
2006-08-14 11:46   ` Evgeniy Polyakov
2006-08-14 11:46     ` Evgeniy Polyakov
2006-08-14 12:07 ` Keith Owens
2006-08-14 12:07   ` Keith Owens
2006-08-14 12:20   ` Evgeniy Polyakov
2006-08-14 12:20     ` Evgeniy Polyakov
2006-08-14 17:42     ` Rick Jones
2006-08-14 17:42       ` Rick Jones
2006-08-14 20:15       ` David Miller
2006-08-14 20:15         ` David Miller, Rick Jones
2006-08-14 12:25 ` Peter Zijlstra
2006-08-14 12:25   ` Peter Zijlstra
2006-08-14 12:35   ` Evgeniy Polyakov
2006-08-14 12:35     ` Evgeniy Polyakov
2006-08-14 12:38     ` Evgeniy Polyakov
2006-08-14 12:38       ` Evgeniy Polyakov
2006-08-15 10:55     ` Peter Zijlstra
2006-08-15 10:55       ` Peter Zijlstra
2006-08-15 11:26       ` Evgeniy Polyakov
2006-08-15 11:26         ` Evgeniy Polyakov
2006-08-15 12:03         ` Peter Zijlstra
2006-08-15 12:03           ` Peter Zijlstra
2006-08-15 12:34           ` Evgeniy Polyakov
2006-08-15 12:34             ` Evgeniy Polyakov
2006-08-15 13:49             ` Peter Zijlstra
2006-08-15 13:49               ` Peter Zijlstra
2006-08-15 14:15               ` Evgeniy Polyakov
2006-08-15 14:15                 ` Evgeniy Polyakov
2006-08-15 14:48                 ` Peter Zijlstra
2006-08-15 14:48                   ` Peter Zijlstra
2006-08-15 15:05                   ` Evgeniy Polyakov
2006-08-15 15:05                     ` Evgeniy Polyakov
2006-08-15 15:07                     ` Evgeniy Polyakov
2006-08-15 15:07                       ` Evgeniy Polyakov
2006-08-15 17:42                     ` Peter Zijlstra
2006-08-15 17:42                       ` Peter Zijlstra
2006-08-15 17:49                       ` Evgeniy Polyakov
2006-08-15 17:49                         ` Evgeniy Polyakov
2006-08-16  2:52                 ` Bill Fink
2006-08-16  2:52                   ` Bill Fink
2006-08-16  5:38                   ` Evgeniy Polyakov
2006-08-16  5:38                     ` Evgeniy Polyakov
2006-08-14 17:46 ` Rick Jones
2006-08-14 17:46   ` Rick Jones
2006-08-14 19:42   ` Evgeniy Polyakov
2006-08-14 19:42     ` Evgeniy Polyakov
2006-08-15  7:27 ` Andrew Morton
2006-08-15  7:27   ` Andrew Morton
2006-08-15  8:08   ` Andi Kleen
2006-08-15  8:08     ` Andi Kleen
2006-08-15 10:02     ` Evgeniy Polyakov
2006-08-15 10:02       ` Evgeniy Polyakov
2006-08-15 10:27       ` David Miller
2006-08-15 10:27         ` David Miller, Evgeniy Polyakov
2006-08-15  9:20   ` Evgeniy Polyakov
2006-08-15  9:20     ` Evgeniy Polyakov
2006-08-15 20:21 ` Arnd Bergmann
2006-08-16  5:35   ` Evgeniy Polyakov
2006-08-16  8:48     ` Christoph Hellwig
2006-08-16  8:48       ` Christoph Hellwig
2006-08-16  9:00       ` Evgeniy Polyakov
2006-08-16  9:00         ` Evgeniy Polyakov
2006-08-16  9:05         ` David Miller
2006-08-16  9:05           ` David Miller, Evgeniy Polyakov
2006-08-16  9:10           ` Christoph Hellwig
2006-08-16  9:10             ` Christoph Hellwig
2006-08-16  9:32             ` Evgeniy Polyakov
2006-08-16  9:32               ` Evgeniy Polyakov
2006-08-16  9:38               ` Christoph Hellwig
2006-08-16  9:38                 ` Christoph Hellwig
2006-08-16  9:40                 ` David Miller
2006-08-16  9:40                   ` David Miller, Christoph Hellwig
2006-08-16  9:44                   ` Christoph Hellwig
2006-08-16  9:44                     ` Christoph Hellwig
2006-08-16  9:42         ` Christoph Hellwig
2006-08-16  9:42           ` Christoph Hellwig
2006-08-16 11:27         ` Arnd Bergmann
2006-08-16 11:27           ` Arnd Bergmann
2006-08-16 12:00           ` Evgeniy Polyakov
2006-08-16 12:00             ` Evgeniy Polyakov
2006-08-16 12:25       ` Andi Kleen
2006-08-16 12:25         ` Andi Kleen
2006-08-18  2:25         ` Christoph Lameter
2006-08-18  2:25           ` Christoph Lameter
2006-08-18  9:29           ` Andi Kleen
2006-08-18  9:29             ` Andi Kleen
2006-08-18  8:51             ` David Miller
2006-08-18  8:51               ` David Miller, Andi Kleen
2006-08-18 17:04             ` Christoph Lameter
2006-08-18 17:04               ` Christoph Lameter
2006-08-16  7:51 ` [PATCH2 " Evgeniy Polyakov
2006-08-16  7:51   ` Evgeniy Polyakov
2006-08-16 16:57   ` Stephen Hemminger
2006-08-16 16:57     ` Stephen Hemminger
2006-08-16 19:27     ` Evgeniy Polyakov
2006-08-16 19:27       ` Evgeniy Polyakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=p73k65ba6l6.fsf@verdi.suse.de \
    --to=ak@suse.de \
    --cc=johnpol@2ka.mipt.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.