From: Sam Morris <sam@robots.org.uk>
To: grub-devel@gnu.org
Subject: Re: [PATCH] tell the user why they are in rescue mode
Date: Sat, 9 Feb 2008 15:42:24 +0000 (UTC) [thread overview]
Message-ID: <pan.2008.02.09.15.42.23@robots.org.uk> (raw)
In-Reply-To: 20080208191539.GA24599@thorin
On Fri, 08 Feb 2008 20:15:39 +0100, Robert Millan wrote:
> On Fri, Feb 08, 2008 at 06:44:26PM +0000, Sam Morris wrote:
>>
>> While that works, the output looks like this:
>>
>> Entering rescue mode...
>> error: out of disk
>> > _
>>
>> Which does not present the information in the clearest possible way: it
>> looks like the error happened in the rescue mode code, instead of the
>> normal mode code.
>>
>> Also, the error message could be lost if any of the code between the
>> start of grub_enter_rescue_mode and its call to grub_print_error itself
>> triggers an error.
>>
>> For these reasons I think it's better to call grub_print_error from
>> within grub_load_normal.
>
> Agreed. See attached patch. Does this work as expected ?
Yes, it works fine.
--
Sam Morris
http://robots.org.uk/
PGP key id 1024D/5EA01078
3412 EA18 1277 354B 991B C869 B219 7FDB 5EA0 1078
next prev parent reply other threads:[~2008-02-09 15:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-07 18:34 [PATCH] tell the user why they are in rescue mode Sam Morris
2008-02-08 1:10 ` Robert Millan
2008-02-08 18:44 ` Sam Morris
2008-02-08 19:15 ` Robert Millan
2008-02-09 15:42 ` Sam Morris [this message]
2008-02-10 17:08 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pan.2008.02.09.15.42.23@robots.org.uk \
--to=sam@robots.org.uk \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.