All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Holger Hoffstätte" <holger.hoffstaette@googlemail.com>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: Dirty pages underflow on 3.14.23
Date: Wed, 7 Jan 2015 10:57:46 +0000 (UTC)	[thread overview]
Message-ID: <pan.2015.01.07.10.57.46@googlemail.com> (raw)
In-Reply-To: alpine.LRH.2.02.1501061246400.16437@file01.intranet.prod.int.rdu2.redhat.com

On Tue, 06 Jan 2015 12:54:43 -0500, Mikulas Patocka wrote:

> On Tue, 6 Jan 2015, Johannes Weiner wrote:
> 
>> > The bug probably happened during git pull or apt-get update, though
>> > one can't be sure that these commands caused it.
>> > 
>> > I see that 3.14.24 containes some fix for underflow (commit
>> > 6619741f17f541113a02c30f22a9ca22e32c9546, upstream commit
>> > abe5f972912d086c080be4bde67750630b6fb38b), but it doesn't seem that
>> > that commit fixes this condition. If you have a commit that could fix
>> > this, say it.
>> 
>> That's an unrelated counter, but there is a known dirty underflow
>> problem that was addressed in 87a7e00b206a ("mm: protect
>> set_page_dirty() from ongoing truncation").  It should make it into the
>> stable kernels in the near future.  Can you reproduce this issue?
>> 
>> Thanks,
>> Johannes
> 
> I can't reprodce it. It happened just once.
> 
> That patch is supposed to fix an occasional underflow by a single page -
> while my meminfo showed underflow by 22952KiB (5738 pages).

You are probably looking for:
commit 835f252c6debd204fcd607c79975089b1ecd3472
"aio: fix uncorrent dirty pages accouting when truncating AIO ring buffer"

It definitely went into 3.14.26, don't know about 3.16.x.

-h

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: "Holger Hoffstätte" <holger.hoffstaette@googlemail.com>
To: linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org
Subject: Re: Dirty pages underflow on 3.14.23
Date: Wed, 7 Jan 2015 10:57:46 +0000 (UTC)	[thread overview]
Message-ID: <pan.2015.01.07.10.57.46@googlemail.com> (raw)
In-Reply-To: alpine.LRH.2.02.1501061246400.16437@file01.intranet.prod.int.rdu2.redhat.com

On Tue, 06 Jan 2015 12:54:43 -0500, Mikulas Patocka wrote:

> On Tue, 6 Jan 2015, Johannes Weiner wrote:
> 
>> > The bug probably happened during git pull or apt-get update, though
>> > one can't be sure that these commands caused it.
>> > 
>> > I see that 3.14.24 containes some fix for underflow (commit
>> > 6619741f17f541113a02c30f22a9ca22e32c9546, upstream commit
>> > abe5f972912d086c080be4bde67750630b6fb38b), but it doesn't seem that
>> > that commit fixes this condition. If you have a commit that could fix
>> > this, say it.
>> 
>> That's an unrelated counter, but there is a known dirty underflow
>> problem that was addressed in 87a7e00b206a ("mm: protect
>> set_page_dirty() from ongoing truncation").  It should make it into the
>> stable kernels in the near future.  Can you reproduce this issue?
>> 
>> Thanks,
>> Johannes
> 
> I can't reprodce it. It happened just once.
> 
> That patch is supposed to fix an occasional underflow by a single page -
> while my meminfo showed underflow by 22952KiB (5738 pages).

You are probably looking for:
commit 835f252c6debd204fcd607c79975089b1ecd3472
"aio: fix uncorrent dirty pages accouting when truncating AIO ring buffer"

It definitely went into 3.14.26, don't know about 3.16.x.

-h


  reply	other threads:[~2015-01-07 11:37 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-05 23:05 Dirty pages underflow on 3.14.23 Mikulas Patocka
2015-01-05 23:05 ` Mikulas Patocka
2015-01-06 15:02 ` Johannes Weiner
2015-01-06 15:02   ` Johannes Weiner
2015-01-06 17:54   ` Mikulas Patocka
2015-01-06 17:54     ` Mikulas Patocka
2015-01-07 10:57     ` Holger Hoffstätte [this message]
2015-01-07 10:57       ` Holger Hoffstätte
2015-01-07 21:28       ` Simon Kirby
2015-01-07 21:28         ` Simon Kirby
2015-01-07 21:48         ` Vlastimil Babka
2015-01-07 21:48           ` Vlastimil Babka
2015-01-08  1:04           ` Simon Kirby
2015-01-08  1:04             ` Simon Kirby
2015-01-08 12:10             ` Vlastimil Babka
2015-01-08 12:10               ` Vlastimil Babka
2015-01-07  9:44 ` Simon Kirby
2015-01-07  9:44   ` Simon Kirby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pan.2015.01.07.10.57.46@googlemail.com \
    --to=holger.hoffstaette@googlemail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.