Re: [PATCH 1/3] btrfs: iterate over unused chunk space in FITRIM

["Holger Hoffstätte" <holger.hoffstaette@googlemail.com>]

On Fri, 05 Jun 2015 09:08:37 -0400, Jeff Mahoney wrote:

>> which conflicts with Filipe's patch on Tuesday called "Btrfs: check
>> pending chunks when shrinking fs to avoid corruption":
>> 
>> +		if (contains_pending_extent(trans, device, &start, len)) {
>> 
>> since trans (returned from start_transaction()) is a handle, not
>> the tx itself.
>> 
>> ISTM that it should now pass trans->transaction instead..or
>> something.
> 
> Yep. That's how you'd resolve that merge. The trans->transaction
> pointer will be valid for the life of the handle.

Good - that's what I've done locally for my branches. Thanks for
confirming. Good to know that I can still make sense of things.

It was more of a question/heads-up since it's not completely unheard of
for warnings to go unnoticed.. :)

cheers
Holger