* [Buildroot] [PATCH 1 of 2] Config.in files: unify comment dependency on udev /dev management
2013-12-19 20:13 [Buildroot] [PATCH 0 of 2] Unify comments on udev /dev management dependency Thomas De Schampheleire
@ 2013-12-19 20:13 ` Thomas De Schampheleire
2013-12-19 20:13 ` [Buildroot] [PATCH 2 of 2] manual: explain format of comment about udev /dev management dependency Thomas De Schampheleire
2013-12-19 20:55 ` [Buildroot] [PATCH 0 of 2] Unify comments on " Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Thomas De Schampheleire @ 2013-12-19 20:13 UTC (permalink / raw)
To: buildroot
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
---
Note: this patch builds on top of the previous series (also touching
package/udev/Config.in)
package/libmbim/Config.in | 2 +-
package/modem-manager/Config.in | 2 +-
package/network-manager/Config.in | 5 +++--
package/systemd/Config.in | 2 +-
package/udev/Config.in | 9 +++------
5 files changed, 9 insertions(+), 11 deletions(-)
diff --git a/package/libmbim/Config.in b/package/libmbim/Config.in
--- a/package/libmbim/Config.in
+++ b/package/libmbim/Config.in
@@ -12,6 +12,6 @@ config BR2_PACKAGE_LIBMBIM
http://www.freedesktop.org/wiki/Software/libmbim/
-comment "libmbim needs udev and a toolchain w/ wchar, threads"
+comment "libmbim needs udev /dev management and a toolchain w/ wchar, threads"
depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \
!BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV
diff --git a/package/modem-manager/Config.in b/package/modem-manager/Config.in
--- a/package/modem-manager/Config.in
+++ b/package/modem-manager/Config.in
@@ -31,6 +31,6 @@ config BR2_PACKAGE_MODEM_MANAGER_LIBQMI
This option enables support for QMI protocol
endif
-comment "modemmanager needs udev and a toolchain w/ largefile, wchar, threads, IPv6"
+comment "modemmanager needs udev /dev management and a toolchain w/ largefile, wchar, threads, IPv6"
depends on !BR2_INET_IPV6 || !BR2_LARGEFILE || !BR2_USE_WCHAR || \
!BR2_TOOLCHAIN_HAS_THREADS || !BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV
diff --git a/package/network-manager/Config.in b/package/network-manager/Config.in
--- a/package/network-manager/Config.in
+++ b/package/network-manager/Config.in
@@ -28,8 +28,9 @@ config BR2_PACKAGE_NETWORK_MANAGER
http://projects.gnome.org/NetworkManager/
-comment "NetworkManager needs a toolchain w/ IPv6, largefile, wchar, threads"
+comment "NetworkManager needs udev /dev management and a toolchain w/ IPv6, largefile, wchar, threads"
depends on !BR2_avr32
depends on BR2_USE_MMU
depends on !BR2_INET_IPV6 || !BR2_LARGEFILE || !BR2_USE_WCHAR || \
- !BR2_TOOLCHAIN_HAS_THREADS
+ !BR2_TOOLCHAIN_HAS_THREADS || \
+ !BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV
diff --git a/package/systemd/Config.in b/package/systemd/Config.in
--- a/package/systemd/Config.in
+++ b/package/systemd/Config.in
@@ -20,5 +20,5 @@ config BR2_PACKAGE_SYSTEMD
comment "systemd needs udev /dev management and a toolchain w/ IPv6, threads"
depends on BR2_USE_MMU
- depends on !BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV || !BR2_INET_IPV6 || \\
+ depends on !BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV || !BR2_INET_IPV6 || \
!BR2_TOOLCHAIN_HAS_THREADS
diff --git a/package/udev/Config.in b/package/udev/Config.in
--- a/package/udev/Config.in
+++ b/package/udev/Config.in
@@ -40,10 +40,7 @@ comment "enabling all extras needs a too
endif
-comment "udev requires /dev mgmnt set to udev under System configuration"
+comment "udev needs udev /dev management and a toolchain w/ largefile, wchar, dynamic library"
depends on !BR2_avr32
- depends on !BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV
-
-comment "udev needs a toolchain w/ largefile, wchar, dynamic library"
- depends on !BR2_avr32
- depends on !BR2_LARGEFILE || !BR2_USE_WCHAR || BR2_PREFER_STATIC_LIB
+ depends on !BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV || \
+ !BR2_LARGEFILE || !BR2_USE_WCHAR || BR2_PREFER_STATIC_LIB
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 2 of 2] manual: explain format of comment about udev /dev management dependency
2013-12-19 20:13 [Buildroot] [PATCH 0 of 2] Unify comments on udev /dev management dependency Thomas De Schampheleire
2013-12-19 20:13 ` [Buildroot] [PATCH 1 of 2] Config.in files: unify comment dependency on udev /dev management Thomas De Schampheleire
@ 2013-12-19 20:13 ` Thomas De Schampheleire
2013-12-19 20:55 ` [Buildroot] [PATCH 0 of 2] Unify comments on " Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Thomas De Schampheleire @ 2013-12-19 20:13 UTC (permalink / raw)
To: buildroot
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
---
docs/manual/adding-packages-directory.txt | 17 +++++++++++++++++
1 files changed, 17 insertions(+), 0 deletions(-)
diff --git a/docs/manual/adding-packages-directory.txt b/docs/manual/adding-packages-directory.txt
--- a/docs/manual/adding-packages-directory.txt
+++ b/docs/manual/adding-packages-directory.txt
@@ -270,6 +270,23 @@ kernel, use this format:
foo needs a toolchain w/ featA, featB, featC and a Linux kernel to be built
--------------------------
+Dependencies on udev /dev management
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+If a package needs udev /dev management, it should depend on symbol
++BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV+, and the following comment
+should be added:
+
+--------------------------
+foo needs udev /dev management
+--------------------------
+
+If there is a dependency on both toolchain options and udev /dev
+management, use this format:
+
+--------------------------
+foo needs udev /dev management and a toolchain w/ featA, featB, featC
+--------------------------
+
The +.mk+ file
~~~~~~~~~~~~~~
[[adding-packages-mk]]
^ permalink raw reply [flat|nested] 4+ messages in thread