Re: [PATCH] trivial: remove unneeded int

[Petr Lautrbach <plautrba@redhat.com>]

Petr Lautrbach <plautrba@redhat.com> writes:

> Jokke Hämäläinen <jokke.hamalainen@kolttonen.fi> writes:
>
>> diff --git a/libsepol/src/context.c b/libsepol/src/context.c
>> index a88937fc..e81b28c6 100644
>> --- a/libsepol/src/context.c
>> +++ b/libsepol/src/context.c
>> @@ -38,7 +38,6 @@ int context_is_valid(const policydb_t * p, const context_struct_t * c)
>>  	role_datum_t *role;
>>  	user_datum_t *usrdatum;
>>  	ebitmap_t types, roles;
>> -	int ret = 1;
>>  
>>  	ebitmap_init(&types);
>>  	ebitmap_init(&roles);
>> @@ -75,7 +74,7 @@ int context_is_valid(const policydb_t * p, const context_struct_t * c)
>>  	if (!mls_context_isvalid(p, c))
>>  		return 0;
>>  
>> -	return ret;
>> +	return 1;
>>  }
>>  
>>  /*
>
> ack
>
> Would you please add Signed-off line (git commit -s ...) to the description, see
> `git log` and https://developercertificate.org/
>
> Also, if the patch applies only to one subdirectory it's a common practice
> to use prefix in the subject of the patch, e.g.:
>
> libsepol: trivial: remove unneeded int
>

The same comment applies also to your other unmerged patches

* trivial: remove unneeded int
* remove redundant if
* More accurate error messages
* trivial fix incorrect indentation
* trivial typo fix

travis CI seems to be happy with all of them
https://travis-ci.org/bachradsusi/SELinuxProject-selinux/builds/542793341