From: Petr Lautrbach <plautrba@redhat.com>
To: "Jokke Hämäläinen" <jokke.hamalainen@kolttonen.fi>
Cc: selinux@vger.kernel.org
Subject: Re: [PATCH] trivial: remove unneeded int
Date: Fri, 07 Jun 2019 16:04:05 +0200 [thread overview]
Message-ID: <pjd5zphv6ei.fsf@redhat.com> (raw)
In-Reply-To: <alpine.LFD.2.21.1905242306150.9521@34-41-5D-CA-59-C7> ("Jokke \=\?utf-8\?B\?SMOkbcOkbMOkaW5lbiIncw\=\=\?\= message of "Fri, 24 May 2019 23:07:38 +0300 (EEST)")
Jokke Hämäläinen <jokke.hamalainen@kolttonen.fi> writes:
> diff --git a/libsepol/src/context.c b/libsepol/src/context.c
> index a88937fc..e81b28c6 100644
> --- a/libsepol/src/context.c
> +++ b/libsepol/src/context.c
> @@ -38,7 +38,6 @@ int context_is_valid(const policydb_t * p, const context_struct_t * c)
> role_datum_t *role;
> user_datum_t *usrdatum;
> ebitmap_t types, roles;
> - int ret = 1;
>
> ebitmap_init(&types);
> ebitmap_init(&roles);
> @@ -75,7 +74,7 @@ int context_is_valid(const policydb_t * p, const context_struct_t * c)
> if (!mls_context_isvalid(p, c))
> return 0;
>
> - return ret;
> + return 1;
> }
>
> /*
ack
Would you please add Signed-off line (git commit -s ...) to the description, see
`git log` and https://developercertificate.org/
Also, if the patch applies only to one subdirectory it's a common practice
to use prefix in the subject of the patch, e.g.:
libsepol: trivial: remove unneeded int
Petr
next prev parent reply other threads:[~2019-06-07 14:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-24 20:07 [PATCH] trivial: remove unneeded int Jokke Hämäläinen
2019-06-07 14:04 ` Petr Lautrbach [this message]
2019-06-07 14:46 ` Petr Lautrbach
2019-06-12 14:32 ` Jokke Hämäläinen
2019-06-12 18:39 ` William Roberts
2019-06-13 15:57 ` Jokke Hämäläinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pjd5zphv6ei.fsf@redhat.com \
--to=plautrba@redhat.com \
--cc=jokke.hamalainen@kolttonen.fi \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.