* [PATCH] dbus: Fix name of polkit function
@ 2019-01-31 19:42 Petr Lautrbach
2019-02-06 20:46 ` Nicolas Iooss
0 siblings, 1 reply; 6+ messages in thread
From: Petr Lautrbach @ 2019-01-31 19:42 UTC (permalink / raw)
To: selinux; +Cc: Dan Walsh, Petr Lautrbach
From: Dan Walsh <dwalsh@redhat.com>
Signed-off-by: Petr Lautrbach <plautrba@redhat.com>
---
dbus/org.selinux.policy | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/dbus/org.selinux.policy b/dbus/org.selinux.policy
index 01266102..9772127b 100644
--- a/dbus/org.selinux.policy
+++ b/dbus/org.selinux.policy
@@ -70,9 +70,9 @@
<allow_active>auth_admin_keep</allow_active>
</defaults>
</action>
- <action id="org.selinux.change_policy_type">
- <description>SELinux write access</description>
- <message>System policy prevents change_policy_type access to SELinux</message>
+ <action id="org.selinux.change_default_mode">
+ <description>Change SELinux default enforcing mode</description>
+ <message>System policy prevents change_default_policy access to SELinux</message>
<defaults>
<allow_any>no</allow_any>
<allow_inactive>no</allow_inactive>
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] dbus: Fix name of polkit function
2019-01-31 19:42 [PATCH] dbus: Fix name of polkit function Petr Lautrbach
@ 2019-02-06 20:46 ` Nicolas Iooss
2019-02-07 9:09 ` Petr Lautrbach
0 siblings, 1 reply; 6+ messages in thread
From: Nicolas Iooss @ 2019-02-06 20:46 UTC (permalink / raw)
To: Petr Lautrbach; +Cc: selinux, Dan Walsh
On Thu, Jan 31, 2019 at 8:42 PM Petr Lautrbach <plautrba@redhat.com> wrote:
>
> From: Dan Walsh <dwalsh@redhat.com>
>
> Signed-off-by: Petr Lautrbach <plautrba@redhat.com>
Hi,
As I am unfamiliar with D-Bus code, I try to understand what is the
nature of this change (is-it a bugfix, an improvement, something
else?). Here are the facts:
- Currently, dbus/selinux_server.py uses «
@slip.dbus.polkit.require_auth("org.selinux.change_default_mode") »
for function « change_default_mode ».
- "org.selinux.change_default_mode" does not exist, and I do not know
whether that means that some kind of default policykit policy gets
applied.
- "org.selinux.change_policy_type" is defined in
dbus/org.selinux.policy, without any user.
- The commit that introduced dbus/selinux_server.py (commit
e6a1298e5421 ("These are massive changes involved in building new
GUI.")) added a function named « change_default_mode », without any
specific policykit access checking.
- Commit e8718ef51463 ("Make sure we do the polkit check on all dbus
interfaces.") added «
@slip.dbus.polkit.require_auth("org.selinux.change_default_mode") » in
policycoreutils/sepolicy/selinux_server.py.
If I understand correctly, this last commit is buggy and should have
added "org.selinux.change_default_mode" to
policycoreutils/sepolicy/org.selinux.policy. Therefore this new patch
fixes a bug and removes an unused policykit action. Is this right? If
yes, I suggest adding this to the commit description:
Add missing action org.selinux.change_default_mode for
change_default_mode() and remove unused action
org.selinux.change_policy_type.
Fixes: e8718ef51463 ("Make sure we do the polkit check on all dbus
interfaces.")
Would this be acceptable?
Thanks,
Nicolas
> ---
> dbus/org.selinux.policy | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/dbus/org.selinux.policy b/dbus/org.selinux.policy
> index 01266102..9772127b 100644
> --- a/dbus/org.selinux.policy
> +++ b/dbus/org.selinux.policy
> @@ -70,9 +70,9 @@
> <allow_active>auth_admin_keep</allow_active>
> </defaults>
> </action>
> - <action id="org.selinux.change_policy_type">
> - <description>SELinux write access</description>
> - <message>System policy prevents change_policy_type access to SELinux</message>
> + <action id="org.selinux.change_default_mode">
> + <description>Change SELinux default enforcing mode</description>
> + <message>System policy prevents change_default_policy access to SELinux</message>
> <defaults>
> <allow_any>no</allow_any>
> <allow_inactive>no</allow_inactive>
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] dbus: Fix name of polkit function
2019-02-06 20:46 ` Nicolas Iooss
@ 2019-02-07 9:09 ` Petr Lautrbach
2019-02-07 9:18 ` [PATCH v2] " Petr Lautrbach
0 siblings, 1 reply; 6+ messages in thread
From: Petr Lautrbach @ 2019-02-07 9:09 UTC (permalink / raw)
To: selinux; +Cc: Petr Lautrbach, Nicolas Iooss, Dan Walsh
Nicolas Iooss <nicolas.iooss@m4x.org> writes:
> On Thu, Jan 31, 2019 at 8:42 PM Petr Lautrbach
> <plautrba@redhat.com> wrote:
>>
>> From: Dan Walsh <dwalsh@redhat.com>
>>
>> Signed-off-by: Petr Lautrbach <plautrba@redhat.com>
>
> Hi,
> As I am unfamiliar with D-Bus code, I try to understand what is
> the
> nature of this change (is-it a bugfix, an improvement, something
> else?). Here are the facts:
>
> - Currently, dbus/selinux_server.py uses «
> @slip.dbus.polkit.require_auth("org.selinux.change_default_mode")
> »
> for function « change_default_mode ».
> - "org.selinux.change_default_mode" does not exist, and I do not
> know
> whether that means that some kind of default policykit policy
> gets
> applied.
> - "org.selinux.change_policy_type" is defined in
> dbus/org.selinux.policy, without any user.
> - The commit that introduced dbus/selinux_server.py (commit
> e6a1298e5421 ("These are massive changes involved in building
> new
> GUI.")) added a function named « change_default_mode », without
> any
> specific policykit access checking.
> - Commit e8718ef51463 ("Make sure we do the polkit check on all
> dbus
> interfaces.") added «
> @slip.dbus.polkit.require_auth("org.selinux.change_default_mode")
> » in
> policycoreutils/sepolicy/selinux_server.py.
>
> If I understand correctly, this last commit is buggy and should
> have
> added "org.selinux.change_default_mode" to
> policycoreutils/sepolicy/org.selinux.policy. Therefore this new
> patch
> fixes a bug and removes an unused policykit action. Is this
> right? If
> yes, I suggest adding this to the commit description:
>
> Add missing action org.selinux.change_default_mode for
> change_default_mode() and remove unused action
> org.selinux.change_policy_type.
>
> Fixes: e8718ef51463 ("Make sure we do the polkit check on
> all dbus
> interfaces.")
>
> Would this be acceptable?
You are completely right and the new message makes sense. I'll
resend
the patch with updated commit message.
Thanks!
>
>> ---
>> dbus/org.selinux.policy | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/dbus/org.selinux.policy b/dbus/org.selinux.policy
>> index 01266102..9772127b 100644
>> --- a/dbus/org.selinux.policy
>> +++ b/dbus/org.selinux.policy
>> @@ -70,9 +70,9 @@
>> <allow_active>auth_admin_keep</allow_active>
>> </defaults>
>> </action>
>> - <action id="org.selinux.change_policy_type">
>> - <description>SELinux write access</description>
>> - <message>System policy prevents change_policy_type
>> access to SELinux</message>
>> + <action id="org.selinux.change_default_mode">
>> + <description>Change SELinux default enforcing
>> mode</description>
>> + <message>System policy prevents change_default_policy
>> access to SELinux</message>
>> <defaults>
>> <allow_any>no</allow_any>
>> <allow_inactive>no</allow_inactive>
>> --
>> 2.20.1
>>
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v2] dbus: Fix name of polkit function
2019-02-07 9:09 ` Petr Lautrbach
@ 2019-02-07 9:18 ` Petr Lautrbach
2019-02-07 21:04 ` Nicolas Iooss
0 siblings, 1 reply; 6+ messages in thread
From: Petr Lautrbach @ 2019-02-07 9:18 UTC (permalink / raw)
To: selinux; +Cc: Dan Walsh, Petr Lautrbach
From: Dan Walsh <dwalsh@redhat.com>
Add missing action org.selinux.change_default_mode for change_default_mode() and
remove unused action org.selinux.change_policy_type.
Fixes: e8718ef51463 ("Make sure we do the polkit check on all dbus interfaces.")
Signed-off-by: Petr Lautrbach <plautrba@redhat.com>
---
dbus/org.selinux.policy | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/dbus/org.selinux.policy b/dbus/org.selinux.policy
index 01266102..9772127b 100644
--- a/dbus/org.selinux.policy
+++ b/dbus/org.selinux.policy
@@ -70,9 +70,9 @@
<allow_active>auth_admin_keep</allow_active>
</defaults>
</action>
- <action id="org.selinux.change_policy_type">
- <description>SELinux write access</description>
- <message>System policy prevents change_policy_type access to SELinux</message>
+ <action id="org.selinux.change_default_mode">
+ <description>Change SELinux default enforcing mode</description>
+ <message>System policy prevents change_default_policy access to SELinux</message>
<defaults>
<allow_any>no</allow_any>
<allow_inactive>no</allow_inactive>
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2] dbus: Fix name of polkit function
2019-02-07 9:18 ` [PATCH v2] " Petr Lautrbach
@ 2019-02-07 21:04 ` Nicolas Iooss
2019-02-10 16:49 ` Nicolas Iooss
0 siblings, 1 reply; 6+ messages in thread
From: Nicolas Iooss @ 2019-02-07 21:04 UTC (permalink / raw)
To: Petr Lautrbach; +Cc: selinux, Dan Walsh
On Thu, Feb 7, 2019 at 10:18 AM Petr Lautrbach <plautrba@redhat.com> wrote:
>
> From: Dan Walsh <dwalsh@redhat.com>
>
> Add missing action org.selinux.change_default_mode for change_default_mode() and
> remove unused action org.selinux.change_policy_type.
>
> Fixes: e8718ef51463 ("Make sure we do the polkit check on all dbus interfaces.")
>
> Signed-off-by: Petr Lautrbach <plautrba@redhat.com>
Acked-by: Nicolas Iooss <nicolas.iooss@m4x.org>
> ---
> dbus/org.selinux.policy | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/dbus/org.selinux.policy b/dbus/org.selinux.policy
> index 01266102..9772127b 100644
> --- a/dbus/org.selinux.policy
> +++ b/dbus/org.selinux.policy
> @@ -70,9 +70,9 @@
> <allow_active>auth_admin_keep</allow_active>
> </defaults>
> </action>
> - <action id="org.selinux.change_policy_type">
> - <description>SELinux write access</description>
> - <message>System policy prevents change_policy_type access to SELinux</message>
> + <action id="org.selinux.change_default_mode">
> + <description>Change SELinux default enforcing mode</description>
> + <message>System policy prevents change_default_policy access to SELinux</message>
> <defaults>
> <allow_any>no</allow_any>
> <allow_inactive>no</allow_inactive>
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] dbus: Fix name of polkit function
2019-02-07 21:04 ` Nicolas Iooss
@ 2019-02-10 16:49 ` Nicolas Iooss
0 siblings, 0 replies; 6+ messages in thread
From: Nicolas Iooss @ 2019-02-10 16:49 UTC (permalink / raw)
To: Petr Lautrbach; +Cc: selinux, Dan Walsh
On Thu, Feb 7, 2019 at 10:04 PM Nicolas Iooss <nicolas.iooss@m4x.org> wrote:
>
> On Thu, Feb 7, 2019 at 10:18 AM Petr Lautrbach <plautrba@redhat.com> wrote:
> >
> > From: Dan Walsh <dwalsh@redhat.com>
> >
> > Add missing action org.selinux.change_default_mode for change_default_mode() and
> > remove unused action org.selinux.change_policy_type.
> >
> > Fixes: e8718ef51463 ("Make sure we do the polkit check on all dbus interfaces.")
> >
> > Signed-off-by: Petr Lautrbach <plautrba@redhat.com>
>
> Acked-by: Nicolas Iooss <nicolas.iooss@m4x.org>
Merged.
Nicolas
> > ---
> > dbus/org.selinux.policy | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/dbus/org.selinux.policy b/dbus/org.selinux.policy
> > index 01266102..9772127b 100644
> > --- a/dbus/org.selinux.policy
> > +++ b/dbus/org.selinux.policy
> > @@ -70,9 +70,9 @@
> > <allow_active>auth_admin_keep</allow_active>
> > </defaults>
> > </action>
> > - <action id="org.selinux.change_policy_type">
> > - <description>SELinux write access</description>
> > - <message>System policy prevents change_policy_type access to SELinux</message>
> > + <action id="org.selinux.change_default_mode">
> > + <description>Change SELinux default enforcing mode</description>
> > + <message>System policy prevents change_default_policy access to SELinux</message>
> > <defaults>
> > <allow_any>no</allow_any>
> > <allow_inactive>no</allow_inactive>
> > --
> > 2.20.1
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-02-10 16:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-31 19:42 [PATCH] dbus: Fix name of polkit function Petr Lautrbach
2019-02-06 20:46 ` Nicolas Iooss
2019-02-07 9:09 ` Petr Lautrbach
2019-02-07 9:18 ` [PATCH v2] " Petr Lautrbach
2019-02-07 21:04 ` Nicolas Iooss
2019-02-10 16:49 ` Nicolas Iooss
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.