All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] core.fsync: fix incorrect expression for default configuration
@ 2022-03-29 21:41 Neeraj K. Singh via GitGitGadget
  0 siblings, 0 replies; only message in thread
From: Neeraj K. Singh via GitGitGadget @ 2022-03-29 21:41 UTC (permalink / raw)
  To: git; +Cc: Neeraj K. Singh, Neeraj Singh

From: Neeraj Singh <neerajsi@microsoft.com>

Commit b9f5d0358d2e882 introduced an incorrect value for
FSYNC_COMPONENTS_DEFAULT. We need an AND-NOT rather than
OR-NOT.

Signed-off-by: Neeraj Singh <neerajsi@microsoft.com>
---
    core.fsync: fix incorrect expression for default configuration
    
    Commit b9f5d0358d2e882 introduced an incorrect value for
    FSYNC_COMPONENTS_DEFAULT. We need an AND-NOT rather than OR-NOT.
    
    Signed-off-by: Neeraj Singh neerajsi@microsoft.com

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1191%2Fneerajsi-msft%2Fns%2Ffix-fsync-default-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1191/neerajsi-msft/ns/fix-fsync-default-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1191

 cache.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/cache.h b/cache.h
index ef7d34b7a09..ee9549c4601 100644
--- a/cache.h
+++ b/cache.h
@@ -1014,8 +1014,8 @@ enum fsync_component {
 #define FSYNC_COMPONENTS_DERIVED_METADATA (FSYNC_COMPONENT_PACK_METADATA | \
 					   FSYNC_COMPONENT_COMMIT_GRAPH)
 
-#define FSYNC_COMPONENTS_DEFAULT (FSYNC_COMPONENTS_OBJECTS | \
-				  FSYNC_COMPONENTS_DERIVED_METADATA | \
+#define FSYNC_COMPONENTS_DEFAULT ((FSYNC_COMPONENTS_OBJECTS | \
+				   FSYNC_COMPONENTS_DERIVED_METADATA) & \
 				  ~FSYNC_COMPONENT_LOOSE_OBJECT)
 
 #define FSYNC_COMPONENTS_COMMITTED (FSYNC_COMPONENTS_OBJECTS | \

base-commit: 1d4f13e63720fb8eae39afa215199f7d77662dba
-- 
gitgitgadget

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2022-03-29 21:42 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-29 21:41 [PATCH] core.fsync: fix incorrect expression for default configuration Neeraj K. Singh via GitGitGadget

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.