All of lore.kernel.org
 help / color / mirror / Atom feed
From: "William Sprent via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Victoria Dye <vdye@github.com>, Elijah Newren <newren@gmail.com>,
	William Sprent <williams@unity3d.com>
Subject: [PATCH 0/2] builtin/sparse-checkout: add check-rules command
Date: Wed, 08 Mar 2023 13:49:07 +0000	[thread overview]
Message-ID: <pull.1488.git.1678283349.gitgitgadget@gmail.com> (raw)

Hi

Back in January I submitted a patch which suggested to teach 'ls-tree' to be
able to filter its output based on sparse checkout specifications [1]. My
main motivation for doing so was (is) to enable building more tooling on top
of sparse checkouts, which is currently hampered a bit by the fact that git
doesn't expose the pattern matching rules for the sparse checkouts.

I think the main point from that thread was that the 'ls-tree' change was
conceptually a larger change that I had initially thought it was. It was
suggested that perhaps it would be more straight-forward to initially add a
command in the vein of 'git-check-ignore' before teaching all the other
commands about sparse checkout specifics, and I think that makes sense. So I
am proposing here a new 'check-rules' sub-command to 'sparse-checkout'. This
exposes the sparse checkout pattern matching logic while still keeping the
pattern specification local to the sparse-checkout command.

Since the intention is that this new behavior would not need a work tree as
it allows the user to supply a set of rules to verify the paths against, the
change that introduces the sub-command is preceded by one that removes the
'NEEDS_WORK_TREE' flag for 'sparse-checkout' and replaces it with calls to
'setup_work_tree()' to keep current behavior.

1:
https://public-inbox.org/git/pull.1459.git.1673456518993.gitgitgadget@gmail.com/

William Sprent (2):
  builtin/sparse-checkout: remove NEED_WORK_TREE flag
  builtin/sparse-checkout: add check-rules command

 Documentation/git-sparse-checkout.txt |  23 +++-
 builtin/sparse-checkout.c             | 132 +++++++++++++++++----
 git.c                                 |   2 +-
 t/t1091-sparse-checkout-builtin.sh    | 162 +++++++++++++++++++++++++-
 4 files changed, 295 insertions(+), 24 deletions(-)


base-commit: d15644fe0226af7ffc874572d968598564a230dd
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1488%2Fwilliams-unity%2Fsparse-doodle-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1488/williams-unity/sparse-doodle-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1488
-- 
gitgitgadget

             reply	other threads:[~2023-03-08 13:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-08 13:49 William Sprent via GitGitGadget [this message]
2023-03-08 13:49 ` [PATCH 1/2] builtin/sparse-checkout: remove NEED_WORK_TREE flag William Sprent via GitGitGadget
2023-03-08 18:14   ` Junio C Hamano
2023-03-08 19:27     ` Junio C Hamano
2023-03-09 15:31       ` Elijah Newren
2023-03-09 22:19         ` Junio C Hamano
2023-03-08 13:49 ` [PATCH 2/2] builtin/sparse-checkout: add check-rules command William Sprent via GitGitGadget
2023-03-19  4:26   ` Elijah Newren
2023-03-20 15:49     ` William Sprent
2023-03-19  4:28 ` [PATCH 0/2] " Elijah Newren
2023-03-27  7:55 ` [PATCH v2 " William Sprent via GitGitGadget
2023-03-27  7:55   ` [PATCH v2 1/2] builtin/sparse-checkout: remove NEED_WORK_TREE flag William Sprent via GitGitGadget
2023-03-27 17:51     ` Junio C Hamano
2023-04-07 16:16       ` SZEDER Gábor
2023-04-07 16:38         ` Junio C Hamano
2023-03-27  7:55   ` [PATCH v2 2/2] builtin/sparse-checkout: add check-rules command William Sprent via GitGitGadget
2023-04-01 18:49   ` [PATCH v2 0/2] " Elijah Newren
2023-04-03 17:07     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pull.1488.git.1678283349.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=newren@gmail.com \
    --cc=vdye@github.com \
    --cc=williams@unity3d.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.