From: "Aryan Gupta via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: "Patrick Steinhardt [ ]" <ps@pks.im>,
"Michal Suchánek [ ]" <msuchanek@suse.de>,
"Jean-Noël AVILA [ ]" <jn.avila@free.fr>
Subject: [PATCH v4] tests: modernize the test script t0010-racy-git.sh
Date: Wed, 06 Mar 2024 09:14:06 +0000 [thread overview]
Message-ID: <pull.1675.v4.git.1709716446874.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.1675.v3.git.1709676557639.gitgitgadget@gmail.com>
From: Aryan Gupta <garyan447@gmail.com>
Modernize the formatting of the test script to align with current
standards and improve its overall readability.
Signed-off-by: Aryan Gupta <garyan447@gmail.com>
---
[GSOC][PATCH] Modernize a test script
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1675%2Faryangupta701%2Ftest-modernize-v4
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1675/aryangupta701/test-modernize-v4
Pull-Request: https://github.com/gitgitgadget/git/pull/1675
Range-diff vs v3:
1: 05ee9e8a458 = 1: 14c7137baea tests: modernize the test script t0010-racy-git.sh
t/t0010-racy-git.sh | 31 +++++++++++++++----------------
1 file changed, 15 insertions(+), 16 deletions(-)
diff --git a/t/t0010-racy-git.sh b/t/t0010-racy-git.sh
index 837c8b7228b..84172a37390 100755
--- a/t/t0010-racy-git.sh
+++ b/t/t0010-racy-git.sh
@@ -10,25 +10,24 @@ TEST_PASSES_SANITIZE_LEAK=true
for trial in 0 1 2 3 4
do
- rm -f .git/index
- echo frotz >infocom
- git update-index --add infocom
- echo xyzzy >infocom
-
- files=$(git diff-files -p)
- test_expect_success \
- "Racy GIT trial #$trial part A" \
- 'test "" != "$files"'
-
+ test_expect_success "Racy git trial #$trial part A" '
+ rm -f .git/index &&
+ echo frotz >infocom &&
+ git update-index --add infocom &&
+ echo xyzzy >infocom &&
+
+ git diff-files -p >out &&
+ test_file_not_empty out
+ '
sleep 1
- echo xyzzy >cornerstone
- git update-index --add cornerstone
- files=$(git diff-files -p)
- test_expect_success \
- "Racy GIT trial #$trial part B" \
- 'test "" != "$files"'
+ test_expect_success "Racy git trial #$trial part B" '
+ echo xyzzy >cornerstone &&
+ git update-index --add cornerstone &&
+ git diff-files -p >out &&
+ test_file_not_empty out
+ '
done
test_done
base-commit: 3c2a3fdc388747b9eaf4a4a4f2035c1c9ddb26d0
--
gitgitgadget
next prev parent reply other threads:[~2024-03-06 9:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 12:23 [PATCH] tests: modernize the test script t0010-racy-git.sh Aryan Gupta via GitGitGadget
2024-02-29 18:11 ` Eric Sunshine
2024-02-29 21:57 ` [PATCH v2] " Aryan Gupta via GitGitGadget
2024-02-29 22:19 ` Eric Sunshine
2024-02-29 23:14 ` Junio C Hamano
2024-02-29 23:22 ` Eric Sunshine
2024-02-29 23:36 ` Junio C Hamano
2024-02-29 23:52 ` Eric Sunshine
2024-03-01 0:06 ` Eric Sunshine
2024-03-01 2:03 ` Junio C Hamano
2024-03-05 22:09 ` [PATCH v3] " Aryan Gupta via GitGitGadget
2024-03-05 23:02 ` Junio C Hamano
2024-03-06 9:14 ` Aryan Gupta via GitGitGadget [this message]
2024-03-07 13:28 ` [PATCH v4] " Christian Couder
2024-03-07 14:23 ` Aryan Gupta
2024-03-07 18:17 ` Junio C Hamano
2024-03-07 18:30 ` Junio C Hamano
2024-03-07 18:33 ` Aryan Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.1675.v4.git.1709716446874.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=jn.avila@free.fr \
--cc=msuchanek@suse.de \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.