From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: "Aryan Gupta via GitGitGadget" <gitgitgadget@gmail.com>,
git@vger.kernel.org, "Patrick Steinhardt" <ps@pks.im>,
"Michal Suchánek" <msuchanek@suse.de>,
"Jean-Noël AVILA" <jn.avila@free.fr>,
"Kristoffer Haugsbakk" <code@khaugsbakk.name>,
"Aryan Gupta" <garyan447@gmail.com>
Subject: Re: [PATCH v2] tests: modernize the test script t0010-racy-git.sh
Date: Thu, 29 Feb 2024 15:36:42 -0800 [thread overview]
Message-ID: <xmqqa5nic06t.fsf@gitster.g> (raw)
In-Reply-To: <CAPig+cQ5m86=pLTpFrik0xS6XPyK4tZQx_wkc1xh2r9WDFkhuQ@mail.gmail.com> (Eric Sunshine's message of "Thu, 29 Feb 2024 18:22:55 -0500")
Eric Sunshine <sunshine@sunshineco.com> writes:
> On Thu, Feb 29, 2024 at 6:14 PM Junio C Hamano <gitster@pobox.com> wrote:
>> So, we may want to do it more like this, perhaps?
>>
>> test_expect_success "Racy GIT trial #$trial part A" '
>> rm -f .git/index &&
>> echo frotz >infocom &&
>> git update-index --add infocom &&
>> echo xyzzy >infocom &&
>>
>> files=$(git diff-files -p) &&
>> test "" != "$files"
>> '
>
> If taking it to this extent, then the modernized version of the last
> couple lines would be:
>
> git diff-files -p >out &&
> test_file_not_empty out
Yes. The modern style seems to prefer temporary files over
variables; the reason probably is because it tends to be easier to
remotely post-mortem?
next prev parent reply other threads:[~2024-02-29 23:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 12:23 [PATCH] tests: modernize the test script t0010-racy-git.sh Aryan Gupta via GitGitGadget
2024-02-29 18:11 ` Eric Sunshine
2024-02-29 21:57 ` [PATCH v2] " Aryan Gupta via GitGitGadget
2024-02-29 22:19 ` Eric Sunshine
2024-02-29 23:14 ` Junio C Hamano
2024-02-29 23:22 ` Eric Sunshine
2024-02-29 23:36 ` Junio C Hamano [this message]
2024-02-29 23:52 ` Eric Sunshine
2024-03-01 0:06 ` Eric Sunshine
2024-03-01 2:03 ` Junio C Hamano
2024-03-05 22:09 ` [PATCH v3] " Aryan Gupta via GitGitGadget
2024-03-05 23:02 ` Junio C Hamano
2024-03-06 9:14 ` [PATCH v4] " Aryan Gupta via GitGitGadget
2024-03-07 13:28 ` Christian Couder
2024-03-07 14:23 ` Aryan Gupta
2024-03-07 18:17 ` Junio C Hamano
2024-03-07 18:30 ` Junio C Hamano
2024-03-07 18:33 ` Aryan Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa5nic06t.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=code@khaugsbakk.name \
--cc=garyan447@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=jn.avila@free.fr \
--cc=msuchanek@suse.de \
--cc=ps@pks.im \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.