All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/1] Fix git status' display of git rebase -ir's label commands
@ 2019-05-10 20:23 Johannes Schindelin via GitGitGadget
  2019-05-10 20:23 ` [PATCH 1/1] status: fix display of rebase -ir's `label` command Johannes Schindelin via GitGitGadget
  0 siblings, 1 reply; 2+ messages in thread
From: Johannes Schindelin via GitGitGadget @ 2019-05-10 20:23 UTC (permalink / raw)
  To: git; +Cc: Junio C Hamano

Those label commands are currently displayed with their argument resolved as
abbreviated commit hash. Not really what we want. We really want the label
names instead.

Johannes Schindelin (1):
  status: fix display of rebase -ir's `label` command

 wt-status.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)


base-commit: 8104ec994ea3849a968b4667d072fedd1e688642
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-188%2Fdscho%2Ffix-status-with-rebase-ir-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-188/dscho/fix-status-with-rebase-ir-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/188
-- 
gitgitgadget

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH 1/1] status: fix display of rebase -ir's `label` command
  2019-05-10 20:23 [PATCH 0/1] Fix git status' display of git rebase -ir's label commands Johannes Schindelin via GitGitGadget
@ 2019-05-10 20:23 ` Johannes Schindelin via GitGitGadget
  0 siblings, 0 replies; 2+ messages in thread
From: Johannes Schindelin via GitGitGadget @ 2019-05-10 20:23 UTC (permalink / raw)
  To: git; +Cc: Junio C Hamano, Johannes Schindelin

From: Johannes Schindelin <johannes.schindelin@gmx.de>

The argument of a `label` command does *not* want to be turned into an
abbreviated SHA-1.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 wt-status.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/wt-status.c b/wt-status.c
index 1f564b12d2..5fc7de6027 100644
--- a/wt-status.c
+++ b/wt-status.c
@@ -1197,7 +1197,9 @@ static void abbrev_sha1_in_line(struct strbuf *line)
 	int i;
 
 	if (starts_with(line->buf, "exec ") ||
-	    starts_with(line->buf, "x "))
+	    starts_with(line->buf, "x ") ||
+	    starts_with(line->buf, "label ") ||
+	    starts_with(line->buf, "l "))
 		return;
 
 	split = strbuf_split_max(line, ' ', 3);
-- 
gitgitgadget

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-05-10 20:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-10 20:23 [PATCH 0/1] Fix git status' display of git rebase -ir's label commands Johannes Schindelin via GitGitGadget
2019-05-10 20:23 ` [PATCH 1/1] status: fix display of rebase -ir's `label` command Johannes Schindelin via GitGitGadget

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.