* [PATCH] t0081: modernize the code testing whether a file exists
@ 2026-10-14 7:26 Shashank S via GitGitGadget
2026-10-14 9:49 ` Usman Akinyemi
0 siblings, 1 reply; 2+ messages in thread
From: Shashank S via GitGitGadget @ 2026-10-14 7:26 UTC (permalink / raw)
To: git
Cc: Kaartic Sivaraam, Christian Couder, Siddharth Asthana,
Usman Akinyemi, Shashank S, Shashank
From: Shashank <shashu8660@gmail.com>
Replace the old-style shell `test -f` command with Git's modern
`test_path_is_file`.
This instance was found using:
`git grep "test -[efd]" t/'
Signed-off-by: Shashank <shashu8660@gmail.com>
---
[outreachy] t0081: Replace the old style 'test -f' to new
'test_path_is_file'
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2254%2Fshashu8660%2Fupdate-t0081-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2254/shashu8660/update-t0081-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/2254
t/t0081-find-pack.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t0081-find-pack.sh b/t/t0081-find-pack.sh
index ff9d56fbf1..7d5082c487 100755
--- a/t/t0081-find-pack.sh
+++ b/t/t0081-find-pack.sh
@@ -32,7 +32,7 @@ test_expect_success 'repack everything into a single packfile' '
".git/objects/pack/pack-"*".pack") true ;;
*) false ;;
esac &&
- test -f "$head_commit_pack" &&
+ test_path_is_file "$head_commit_pack" &&
# Everything is in the same pack
test "$head_commit_pack" = "$head_tree_pack" &&
base-commit: 6de20f6092dcf9bdb1c8efe03db4b70c82b423dd
--
gitgitgadget
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] t0081: modernize the code testing whether a file exists
2026-10-14 7:26 [PATCH] t0081: modernize the code testing whether a file exists Shashank S via GitGitGadget
@ 2026-10-14 9:49 ` Usman Akinyemi
0 siblings, 0 replies; 2+ messages in thread
From: Usman Akinyemi @ 2026-10-14 9:49 UTC (permalink / raw)
To: Shashank S via GitGitGadget
Cc: git, Kaartic Sivaraam, Christian Couder, Siddharth Asthana,
Shashank S
> From: Shashank <shashu8660@gmail.com>
>
> Replace the old-style shell `test -f` command with Git's modern
> `test_path_is_file`.
>
> This instance was found using:
> `git grep "test -[efd]" t/'
This is not necessary, remove it.
>
> Signed-off-by: Shashank <shashu8660@gmail.com>
> ---
> [outreachy] t0081: Replace the old style 'test -f' to new
> 'test_path_is_file'
>
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2254%2Fshashu8660%2Fupdate-t0081-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2254/shashu8660/update-t0081-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/2254
>
> t/t0081-find-pack.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t0081-find-pack.sh b/t/t0081-find-pack.sh
> index ff9d56fbf1..7d5082c487 100755
> --- a/t/t0081-find-pack.sh
> +++ b/t/t0081-find-pack.sh
> @@ -32,7 +32,7 @@ test_expect_success 'repack everything into a single packfile' '
> ".git/objects/pack/pack-"*".pack") true ;;
> *) false ;;
> esac &&
> - test -f "$head_commit_pack" &&
> + test_path_is_file "$head_commit_pack" &&
looks good to me.
>
> # Everything is in the same pack
> test "$head_commit_pack" = "$head_tree_pack" &&
>
> base-commit: 6de20f6092dcf9bdb1c8efe03db4b70c82b423dd
> --
> gitgitgadget
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-14 9:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-14 7:26 [PATCH] t0081: modernize the code testing whether a file exists Shashank S via GitGitGadget
2026-10-14 9:49 ` Usman Akinyemi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.