From: "Max Belsky via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Max Belsky <public.belsky@gmail.com>, Junio C Hamano <gitster@pobox.com>
Subject: [PATCH v2 0/1] doc: Add a note about ~/.zsh/_git file
Date: Fri, 11 Oct 2019 10:54:27 -0700 (PDT) [thread overview]
Message-ID: <pull.367.v2.git.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.367.git.gitgitgadget@gmail.com>
Hey,
Today I've spent a few hours to understand why git-completion doesn't work
in my zsh shell. It was because I thought ~/.zsh/_git should be a dictionary
with git-completion.zsh file.
I think this change may save some hours for someone else.
Maxim Belsky (1):
doc: Change zsh git completion file name
contrib/completion/git-completion.zsh | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
base-commit: 4c86140027f4a0d2caaa3ab4bd8bfc5ce3c11c8a
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-367%2Fmbelsky%2Fpatch-1-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-367/mbelsky/patch-1-v2
Pull-Request: https://github.com/gitgitgadget/git/pull/367
Range-diff vs v1:
1: ae00e1e393 ! 1: 3f994f3b9a doc: Change zsh git completion file name
@@ -2,7 +2,15 @@
doc: Change zsh git completion file name
+ The original comment does not describe type of ~/.zsh/_git explicitly
+ and zsh does not warn or fail if a user create it as a dictionary.
+ So unexperienced users could be misled by the original comment.
+
+ There is a small update to clarify it.
+
Signed-off-by: Maxim Belsky <public.belsky@gmail.com>
+ Helped-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
+ Helped-by: Junio C Hamano <gitster@pobox.com>
diff --git a/contrib/completion/git-completion.zsh b/contrib/completion/git-completion.zsh
--- a/contrib/completion/git-completion.zsh
@@ -13,9 +21,9 @@
#
-# The recommended way to install this script is to copy to '~/.zsh/_git', and
-# then add the following to your ~/.zshrc file:
-+# The recommended way to install this script is to copy to
-+# '~/.zsh/.git-completion.zsh', and then add the following to your ~/.zshrc
-+# file:
++# The recommended way to install this script is to make a copy of it in
++# ~/.zsh/ directory as ~/.zsh/git-completion.zsh and then add the following
++# to your ~/.zshrc file:
#
# fpath=(~/.zsh $fpath)
--
gitgitgadget
next prev parent reply other threads:[~2019-10-11 17:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 16:56 [PATCH 0/1] doc: Add a note about ~/.zsh/_git file Max Belsky via GitGitGadget
2019-10-10 16:56 ` [PATCH 1/1] doc: Change zsh git completion file name Maxim Belsky via GitGitGadget
2019-10-10 21:12 ` Johannes Schindelin
2019-10-11 5:57 ` Junio C Hamano
2019-10-11 17:54 ` Max Belsky via GitGitGadget [this message]
2019-10-11 17:54 ` [PATCH v2 " Maxim Belsky via GitGitGadget
2019-10-12 1:35 ` Junio C Hamano
2019-10-14 23:44 ` SZEDER Gábor
2019-10-15 2:07 ` Junio C Hamano
2020-10-25 3:40 ` Felipe Contreras
2019-10-15 18:48 ` [PATCH v3 0/1] doc: Add a note about ~/.zsh/_git file Max Belsky via GitGitGadget
2019-10-15 18:48 ` [PATCH v3 1/1] doc: Change zsh git completion file name Maxim Belsky via GitGitGadget
2019-10-16 2:06 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.367.v2.git.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=public.belsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.