From: Junio C Hamano <gitster@pobox.com>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: Maxim Belsky via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Max Belsky <public.belsky@gmail.com>
Subject: Re: [PATCH v2 1/1] doc: Change zsh git completion file name
Date: Tue, 15 Oct 2019 11:07:08 +0900 [thread overview]
Message-ID: <xmqqimoqdann.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20191014234439.GT29845@szeder.dev> ("SZEDER Gábor"'s message of "Tue, 15 Oct 2019 01:44:39 +0200")
SZEDER Gábor <szeder.dev@gmail.com> writes:
>> -# The recommended way to install this script is to copy to '~/.zsh/_git', and
>> -# then add the following to your ~/.zshrc file:
>> +# The recommended way to install this script is to make a copy of it in
>> +# ~/.zsh/ directory as ~/.zsh/git-completion.zsh and then add the following
>
> These updated instructions don't work for me, following them gives me
> zsh's git completion instead of ours:
> ...
> Instructing users to copy our completion script to
> '~/.zsh/git-completion.zsh' goes against this convention.
> More importantly, it appears that this is more than a mere convention,
> maybe a requirement even; at least renaming our zsh completion script
> to follow the convention (IOW following the current install
> instructions) makes it work all of a sudden:
Thanks for a dose of sanity. My "Helped-by" was about phrasing and
had nothing with the name of the file, so it should be fixable
without invalidating it ;-)
> -# The recommended way to install this script is to copy to '~/.zsh/_git', and
> -# then add the following to your ~/.zshrc file:
> +# The recommended way to install this script is to make a copy of it in
> +# ~/.zsh/ directory as ~/.zsh/git-completion.zsh and then add the following
# The recommended way to install this script is to make a copy of it in
# '~/.zsh/' directory as '~/.zsh/_git' and then add the following
next prev parent reply other threads:[~2019-10-15 2:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 16:56 [PATCH 0/1] doc: Add a note about ~/.zsh/_git file Max Belsky via GitGitGadget
2019-10-10 16:56 ` [PATCH 1/1] doc: Change zsh git completion file name Maxim Belsky via GitGitGadget
2019-10-10 21:12 ` Johannes Schindelin
2019-10-11 5:57 ` Junio C Hamano
2019-10-11 17:54 ` [PATCH v2 0/1] doc: Add a note about ~/.zsh/_git file Max Belsky via GitGitGadget
2019-10-11 17:54 ` [PATCH v2 1/1] doc: Change zsh git completion file name Maxim Belsky via GitGitGadget
2019-10-12 1:35 ` Junio C Hamano
2019-10-14 23:44 ` SZEDER Gábor
2019-10-15 2:07 ` Junio C Hamano [this message]
2020-10-25 3:40 ` Felipe Contreras
2019-10-15 18:48 ` [PATCH v3 0/1] doc: Add a note about ~/.zsh/_git file Max Belsky via GitGitGadget
2019-10-15 18:48 ` [PATCH v3 1/1] doc: Change zsh git completion file name Maxim Belsky via GitGitGadget
2019-10-16 2:06 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqimoqdann.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=public.belsky@gmail.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.