"start_info" symbol clash

"start_info" symbol clash

[Charles Coffing]

Can we rename "start_info" to something else, perhaps "xen_start_info"?

If CONFIG_SND_SB16_CSP is enabled, I get a compile error in
linux-2.6.8.1/sound/isa/sb/sb16_csp.c since it has a variable by the
same name.

  CC [M]  sound/isa/sb/sb16_csp.o
sound/isa/sb/sb16_csp.c: In function `snd_sb_csp_ioctl':
sound/isa/sb/sb16_csp.c:194: error: parse error before '.' token
sound/isa/sb/sb16_csp.c:237: error: structure has no member named
`sample_width'
sound/isa/sb/sb16_csp.c:237: error: structure has no member named
`channels'



-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl

Re: "start_info" symbol clash

[Ian Pratt]

> Can we rename "start_info" to something else, perhaps "xen_start_info"?
> 
> If CONFIG_SND_SB16_CSP is enabled, I get a compile error in
> linux-2.6.8.1/sound/isa/sb/sb16_csp.c since it has a variable by the
> same name.

I'll bet we've got a better excuse for ours being non-static than
they have ;-)

Anyhow, we'll have to rename.

Would you mind knocking up a suitable patch for xen/2.4/2.6 ?

Thanks,
Ian




-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl

Re: "start_info" symbol clash

[Keir Fraser]

Yes, this is easy to do. I'm just testing a patch now.

 -- Keir

> Can we rename "start_info" to something else, perhaps "xen_start_info"?
> 
> If CONFIG_SND_SB16_CSP is enabled, I get a compile error in
> linux-2.6.8.1/sound/isa/sb/sb16_csp.c since it has a variable by the
> same name.
> 
>   CC [M]  sound/isa/sb/sb16_csp.o
> sound/isa/sb/sb16_csp.c: In function `snd_sb_csp_ioctl':
> sound/isa/sb/sb16_csp.c:194: error: parse error before '.' token
> sound/isa/sb/sb16_csp.c:237: error: structure has no member named
> `sample_width'
> sound/isa/sb/sb16_csp.c:237: error: structure has no member named
> `channels'
> 
> 
> 
> -------------------------------------------------------
> This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
> Use IT products in your business? Tell us what you think of them. Give us
> Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
> http://productguide.itmanagersjournal.com/guidepromo.tmpl
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/xen-devel



-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl