* [PATCH][resend] sh: kgdb: Mark expected switch fall-throughs @ 2019-11-25 7:16 ` Kuninori Morimoto 0 siblings, 0 replies; 26+ messages in thread From: Kuninori Morimoto @ 2019-11-25 7:16 UTC (permalink / raw) To: Yoshinori Sato, Rich Felker Cc: Daniel Thompson, Will Deacon, Douglas Anderson, Paul Burton, Christophe Leroy, linux-sh, linux-kernel From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Mark switch cases where we are expecting to fall through. This patch fixes the following error: LINUX/arch/sh/kernel/kgdb.c: In function 'kgdb_arch_handle_exception': LINUX/arch/sh/kernel/kgdb.c:267:6: error: this statement may fall through [-Werror=implicit-fallthrough=] if (kgdb_hex2long(&ptr, &addr)) ^ LINUX/arch/sh/kernel/kgdb.c:269:2: note: here case 'D': ^~~~ Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Acked-by: Daniel Thompson <daniel.thompson@linaro.org> --- - nothing happen in 1 month... arch/sh/kernel/kgdb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/sh/kernel/kgdb.c b/arch/sh/kernel/kgdb.c index 6d61f8c..0d5f3c9 100644 --- a/arch/sh/kernel/kgdb.c +++ b/arch/sh/kernel/kgdb.c @@ -266,6 +266,7 @@ int kgdb_arch_handle_exception(int e_vector, int signo, int err_code, ptr = &remcomInBuffer[1]; if (kgdb_hex2long(&ptr, &addr)) linux_regs->pc = addr; + /* fallthrough */ case 'D': case 'k': atomic_set(&kgdb_cpu_doing_single_step, -1); -- 2.7.4 ^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH][resend] sh: kgdb: Mark expected switch fall-throughs @ 2019-11-25 7:16 ` Kuninori Morimoto 0 siblings, 0 replies; 26+ messages in thread From: Kuninori Morimoto @ 2019-11-25 7:16 UTC (permalink / raw) To: Yoshinori Sato, Rich Felker Cc: Daniel Thompson, Will Deacon, Douglas Anderson, Paul Burton, Christophe Leroy, linux-sh, linux-kernel From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Mark switch cases where we are expecting to fall through. This patch fixes the following error: LINUX/arch/sh/kernel/kgdb.c: In function 'kgdb_arch_handle_exception': LINUX/arch/sh/kernel/kgdb.c:267:6: error: this statement may fall through [-Werror=implicit-fallthrough=] if (kgdb_hex2long(&ptr, &addr)) ^ LINUX/arch/sh/kernel/kgdb.c:269:2: note: here case 'D': ^~~~ Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Acked-by: Daniel Thompson <daniel.thompson@linaro.org> --- - nothing happen in 1 month... arch/sh/kernel/kgdb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/sh/kernel/kgdb.c b/arch/sh/kernel/kgdb.c index 6d61f8c..0d5f3c9 100644 --- a/arch/sh/kernel/kgdb.c +++ b/arch/sh/kernel/kgdb.c @@ -266,6 +266,7 @@ int kgdb_arch_handle_exception(int e_vector, int signo, int err_code, ptr = &remcomInBuffer[1]; if (kgdb_hex2long(&ptr, &addr)) linux_regs->pc = addr; + /* fallthrough */ case 'D': case 'k': atomic_set(&kgdb_cpu_doing_single_step, -1); -- 2.7.4 ^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH][resend] sh: kgdb: Mark expected switch fall-throughs @ 2019-12-10 0:26 ` Kuninori Morimoto 0 siblings, 0 replies; 26+ messages in thread From: Kuninori Morimoto @ 2019-12-10 0:26 UTC (permalink / raw) To: Greg Kroah-Hartman, Yoshinori Sato, Rich Felker Cc: Daniel Thompson, Will Deacon, Douglas Anderson, Paul Burton, Christophe Leroy, linux-sh, linux-kernel Hi Greg I'm posting this patch from few month ago, but it seems SH ML maintainer is not working in these days... I'm not sure who can handle this patch in this case, but is it possible to consider about it ? Thank you for your help !! Best regards --- Kuninori Morimoto ^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH][resend] sh: kgdb: Mark expected switch fall-throughs @ 2019-12-10 0:26 ` Kuninori Morimoto 0 siblings, 0 replies; 26+ messages in thread From: Kuninori Morimoto @ 2019-12-10 0:26 UTC (permalink / raw) To: Greg Kroah-Hartman, Yoshinori Sato, Rich Felker Cc: Daniel Thompson, Will Deacon, Douglas Anderson, Paul Burton, Christophe Leroy, linux-sh, linux-kernel Hi Greg I'm posting this patch from few month ago, but it seems SH ML maintainer is not working in these days... I'm not sure who can handle this patch in this case, but is it possible to consider about it ? Thank you for your help !! Best regards --- Kuninori Morimoto ^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH] sh: kgdb: Mark expected switch fall-throughs 2019-12-10 0:26 ` Kuninori Morimoto @ 2019-12-10 0:27 ` Kuninori Morimoto -1 siblings, 0 replies; 26+ messages in thread From: Kuninori Morimoto @ 2019-12-10 0:27 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Yoshinori Sato, Rich Felker, Daniel Thompson, Will Deacon, Douglas Anderson, Paul Burton, Christophe Leroy, linux-sh, linux-kernel From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Mark switch cases where we are expecting to fall through. This patch fixes the following error: LINUX/arch/sh/kernel/kgdb.c: In function 'kgdb_arch_handle_exception': LINUX/arch/sh/kernel/kgdb.c:267:6: error: this statement may fall through [-Werror=implicit-fallthrough=] if (kgdb_hex2long(&ptr, &addr)) ^ LINUX/arch/sh/kernel/kgdb.c:269:2: note: here case 'D': ^~~~ Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Acked-by: Daniel Thompson <daniel.thompson@linaro.org> --- arch/sh/kernel/kgdb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/sh/kernel/kgdb.c b/arch/sh/kernel/kgdb.c index 6d61f8c..0d5f3c9 100644 --- a/arch/sh/kernel/kgdb.c +++ b/arch/sh/kernel/kgdb.c @@ -266,6 +266,7 @@ int kgdb_arch_handle_exception(int e_vector, int signo, int err_code, ptr = &remcomInBuffer[1]; if (kgdb_hex2long(&ptr, &addr)) linux_regs->pc = addr; + /* fallthrough */ case 'D': case 'k': atomic_set(&kgdb_cpu_doing_single_step, -1); -- 2.7.4 ^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH] sh: kgdb: Mark expected switch fall-throughs @ 2019-12-10 0:27 ` Kuninori Morimoto 0 siblings, 0 replies; 26+ messages in thread From: Kuninori Morimoto @ 2019-12-10 0:27 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Yoshinori Sato, Rich Felker, Daniel Thompson, Will Deacon, Douglas Anderson, Paul Burton, Christophe Leroy, linux-sh, linux-kernel, Daniel Thompson From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Mark switch cases where we are expecting to fall through. This patch fixes the following error: LINUX/arch/sh/kernel/kgdb.c: In function 'kgdb_arch_handle_exception': LINUX/arch/sh/kernel/kgdb.c:267:6: error: this statement may fall through [-Werror=implicit-fallthrough=] if (kgdb_hex2long(&ptr, &addr)) ^ LINUX/arch/sh/kernel/kgdb.c:269:2: note: here case 'D': ^~~~ Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Acked-by: Daniel Thompson <daniel.thompson@linaro.org> --- arch/sh/kernel/kgdb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/sh/kernel/kgdb.c b/arch/sh/kernel/kgdb.c index 6d61f8c..0d5f3c9 100644 --- a/arch/sh/kernel/kgdb.c +++ b/arch/sh/kernel/kgdb.c @@ -266,6 +266,7 @@ int kgdb_arch_handle_exception(int e_vector, int signo, int err_code, ptr = &remcomInBuffer[1]; if (kgdb_hex2long(&ptr, &addr)) linux_regs->pc = addr; + /* fallthrough */ case 'D': case 'k': atomic_set(&kgdb_cpu_doing_single_step, -1); -- 2.7.4 ^ permalink raw reply related [flat|nested] 26+ messages in thread
* Re: [PATCH][resend] sh: kgdb: Mark expected switch fall-throughs 2019-12-10 0:26 ` Kuninori Morimoto @ 2019-12-10 8:17 ` Geert Uytterhoeven -1 siblings, 0 replies; 26+ messages in thread From: Geert Uytterhoeven @ 2019-12-10 8:17 UTC (permalink / raw) To: Kuninori Morimoto Cc: Greg Kroah-Hartman, Yoshinori Sato, Rich Felker, Daniel Thompson, Will Deacon, Douglas Anderson, Paul Burton, Christophe Leroy, Linux-sh list, Linux Kernel Mailing List, Andrew Morton Hi Morimoto-san, On Tue, Dec 10, 2019 at 1:26 AM Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote: > I'm posting this patch from few month ago, > but it seems SH ML maintainer is not working in these days... > > I'm not sure who can handle this patch in this case, > but is it possible to consider about it ? You may want to CC Andrew Morton <akpm@linux-foundation.org>, who tends to pick up patches for non-responsive architecture maintainers. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH][resend] sh: kgdb: Mark expected switch fall-throughs @ 2019-12-10 8:17 ` Geert Uytterhoeven 0 siblings, 0 replies; 26+ messages in thread From: Geert Uytterhoeven @ 2019-12-10 8:17 UTC (permalink / raw) To: Kuninori Morimoto Cc: Greg Kroah-Hartman, Yoshinori Sato, Rich Felker, Daniel Thompson, Will Deacon, Douglas Anderson, Paul Burton, Christophe Leroy, Linux-sh list, Linux Kernel Mailing List, Andrew Morton Hi Morimoto-san, On Tue, Dec 10, 2019 at 1:26 AM Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote: > I'm posting this patch from few month ago, > but it seems SH ML maintainer is not working in these days... > > I'm not sure who can handle this patch in this case, > but is it possible to consider about it ? You may want to CC Andrew Morton <akpm@linux-foundation.org>, who tends to pick up patches for non-responsive architecture maintainers. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH][resend] sh: kgdb: Mark expected switch fall-throughs 2019-12-10 8:17 ` Geert Uytterhoeven @ 2019-12-10 8:19 ` Kuninori Morimoto -1 siblings, 0 replies; 26+ messages in thread From: Kuninori Morimoto @ 2019-12-10 8:19 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Greg Kroah-Hartman, Yoshinori Sato, Rich Felker, Daniel Thompson, Will Deacon, Douglas Anderson, Paul Burton, Christophe Leroy, Linux-sh list, Linux Kernel Mailing List, Andrew Morton Hi Geert > > I'm posting this patch from few month ago, > > but it seems SH ML maintainer is not working in these days... > > > > I'm not sure who can handle this patch in this case, > > but is it possible to consider about it ? > > You may want to CC Andrew Morton <akpm@linux-foundation.org>, who > tends to pick up patches for non-responsive architecture maintainers. Yeah, indeed. Thanks, will do soon Thank you for your help !! Best regards --- Kuninori Morimoto ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH][resend] sh: kgdb: Mark expected switch fall-throughs @ 2019-12-10 8:19 ` Kuninori Morimoto 0 siblings, 0 replies; 26+ messages in thread From: Kuninori Morimoto @ 2019-12-10 8:19 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Greg Kroah-Hartman, Yoshinori Sato, Rich Felker, Daniel Thompson, Will Deacon, Douglas Anderson, Paul Burton, Christophe Leroy, Linux-sh list, Linux Kernel Mailing List, Andrew Morton Hi Geert > > I'm posting this patch from few month ago, > > but it seems SH ML maintainer is not working in these days... > > > > I'm not sure who can handle this patch in this case, > > but is it possible to consider about it ? > > You may want to CC Andrew Morton <akpm@linux-foundation.org>, who > tends to pick up patches for non-responsive architecture maintainers. Yeah, indeed. Thanks, will do soon Thank you for your help !! Best regards --- Kuninori Morimoto ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH][resend] sh: kgdb: Mark expected switch fall-throughs 2019-12-10 0:26 ` Kuninori Morimoto @ 2019-12-10 20:10 ` Rob Landley -1 siblings, 0 replies; 26+ messages in thread From: Rob Landley @ 2019-12-10 20:10 UTC (permalink / raw) To: Kuninori Morimoto, Greg Kroah-Hartman, Yoshinori Sato, Rich Felker Cc: Daniel Thompson, Will Deacon, Douglas Anderson, Paul Burton, Christophe Leroy, linux-sh, linux-kernel On 12/9/19 6:26 PM, Kuninori Morimoto wrote: > > Hi Greg > > I'm posting this patch from few month ago, > but it seems SH ML maintainer is not working in these days... There's two of them and they both are? (I spoke to Rich on IRC last week?) Rob ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH][resend] sh: kgdb: Mark expected switch fall-throughs @ 2019-12-10 20:10 ` Rob Landley 0 siblings, 0 replies; 26+ messages in thread From: Rob Landley @ 2019-12-10 20:10 UTC (permalink / raw) To: Kuninori Morimoto, Greg Kroah-Hartman, Yoshinori Sato, Rich Felker Cc: Daniel Thompson, Will Deacon, Douglas Anderson, Paul Burton, Christophe Leroy, linux-sh, linux-kernel On 12/9/19 6:26 PM, Kuninori Morimoto wrote: > > Hi Greg > > I'm posting this patch from few month ago, > but it seems SH ML maintainer is not working in these days... There's two of them and they both are? (I spoke to Rich on IRC last week?) Rob ^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH][resend] sh: kgdb: Mark expected switch fall-throughs @ 2019-12-10 8:38 ` Kuninori Morimoto 0 siblings, 0 replies; 26+ messages in thread From: Kuninori Morimoto @ 2019-12-10 8:38 UTC (permalink / raw) To: Andrew Morton, Greg Kroah-Hartman, Yoshinori Sato, Rich Felker Cc: Daniel Thompson, Will Deacon, Douglas Anderson, Paul Burton, Christophe Leroy, linux-sh, linux-kernel Hi Andrew I'm posting this patch from few month ago, but it seems SH maintainer is not working in these days... Is it possible to consider about it ? SH compile will be error without this patch. Thank you for your help !! Best regards --- Kuninori Morimoto ^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH][resend] sh: kgdb: Mark expected switch fall-throughs @ 2019-12-10 8:38 ` Kuninori Morimoto 0 siblings, 0 replies; 26+ messages in thread From: Kuninori Morimoto @ 2019-12-10 8:38 UTC (permalink / raw) To: Andrew Morton, Greg Kroah-Hartman, Yoshinori Sato, Rich Felker Cc: Daniel Thompson, Will Deacon, Douglas Anderson, Paul Burton, Christophe Leroy, linux-sh, linux-kernel Hi Andrew I'm posting this patch from few month ago, but it seems SH maintainer is not working in these days... Is it possible to consider about it ? SH compile will be error without this patch. Thank you for your help !! Best regards --- Kuninori Morimoto ^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH] sh: kgdb: Mark expected switch fall-throughs 2019-12-10 8:38 ` Kuninori Morimoto @ 2019-12-10 8:39 ` Kuninori Morimoto -1 siblings, 0 replies; 26+ messages in thread From: Kuninori Morimoto @ 2019-12-10 8:39 UTC (permalink / raw) To: Andrew Morton Cc: Greg Kroah-Hartman, Yoshinori Sato, Rich Felker, Daniel Thompson, Will Deacon, Douglas Anderson, Paul Burton, Christophe Leroy, linux-sh, linux-kernel From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Mark switch cases where we are expecting to fall through. This patch fixes the following error: LINUX/arch/sh/kernel/kgdb.c: In function 'kgdb_arch_handle_exception': LINUX/arch/sh/kernel/kgdb.c:267:6: error: this statement may fall through [-Werror=implicit-fallthrough=] if (kgdb_hex2long(&ptr, &addr)) ^ LINUX/arch/sh/kernel/kgdb.c:269:2: note: here case 'D': ^~~~ Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Acked-by: Daniel Thompson <daniel.thompson@linaro.org> --- arch/sh/kernel/kgdb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/sh/kernel/kgdb.c b/arch/sh/kernel/kgdb.c index 6d61f8c..0d5f3c9 100644 --- a/arch/sh/kernel/kgdb.c +++ b/arch/sh/kernel/kgdb.c @@ -266,6 +266,7 @@ int kgdb_arch_handle_exception(int e_vector, int signo, int err_code, ptr = &remcomInBuffer[1]; if (kgdb_hex2long(&ptr, &addr)) linux_regs->pc = addr; + /* fallthrough */ case 'D': case 'k': atomic_set(&kgdb_cpu_doing_single_step, -1); -- 2.7.4 ^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH] sh: kgdb: Mark expected switch fall-throughs @ 2019-12-10 8:39 ` Kuninori Morimoto 0 siblings, 0 replies; 26+ messages in thread From: Kuninori Morimoto @ 2019-12-10 8:39 UTC (permalink / raw) To: Andrew Morton Cc: Greg Kroah-Hartman, Yoshinori Sato, Rich Felker, Daniel Thompson, Will Deacon, Douglas Anderson, Paul Burton, Christophe Leroy, linux-sh, linux-kernel From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Mark switch cases where we are expecting to fall through. This patch fixes the following error: LINUX/arch/sh/kernel/kgdb.c: In function 'kgdb_arch_handle_exception': LINUX/arch/sh/kernel/kgdb.c:267:6: error: this statement may fall through [-Werror=implicit-fallthrough=] if (kgdb_hex2long(&ptr, &addr)) ^ LINUX/arch/sh/kernel/kgdb.c:269:2: note: here case 'D': ^~~~ Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Acked-by: Daniel Thompson <daniel.thompson@linaro.org> --- arch/sh/kernel/kgdb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/sh/kernel/kgdb.c b/arch/sh/kernel/kgdb.c index 6d61f8c..0d5f3c9 100644 --- a/arch/sh/kernel/kgdb.c +++ b/arch/sh/kernel/kgdb.c @@ -266,6 +266,7 @@ int kgdb_arch_handle_exception(int e_vector, int signo, int err_code, ptr = &remcomInBuffer[1]; if (kgdb_hex2long(&ptr, &addr)) linux_regs->pc = addr; + /* fallthrough */ case 'D': case 'k': atomic_set(&kgdb_cpu_doing_single_step, -1); -- 2.7.4 ^ permalink raw reply related [flat|nested] 26+ messages in thread
* Re: [PATCH] sh: kgdb: Mark expected switch fall-throughs 2019-12-10 8:39 ` Kuninori Morimoto (?) @ 2019-12-10 8:47 ` Christophe Leroy -1 siblings, 0 replies; 26+ messages in thread From: Christophe Leroy @ 2019-12-10 8:47 UTC (permalink / raw) To: Kuninori Morimoto, Andrew Morton Cc: Greg Kroah-Hartman, Yoshinori Sato, Rich Felker, Daniel Thompson, Will Deacon, Douglas Anderson, Paul Burton, linux-sh, linux-kernel, stable@vger.kernel.org On 12/10/2019 08:39 AM, Kuninori Morimoto wrote: > > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > Mark switch cases where we are expecting to fall through. > > This patch fixes the following error: > > LINUX/arch/sh/kernel/kgdb.c: In function 'kgdb_arch_handle_exception': > LINUX/arch/sh/kernel/kgdb.c:267:6: error: this statement may fall through [-Werror=implicit-fallthrough=] > if (kgdb_hex2long(&ptr, &addr)) > ^ > LINUX/arch/sh/kernel/kgdb.c:269:2: note: here > case 'D': > ^~~~ > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > Acked-by: Daniel Thompson <daniel.thompson@linaro.org> I guess you should also add: Fixes: ab6e570ba33d ("sh: Generic kgdb stub support.") Cc: stable@vger.kernel.org Christophe ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH] sh: kgdb: Mark expected switch fall-throughs 2019-12-10 8:39 ` Kuninori Morimoto (?) (?) @ 2019-12-11 15:18 ` Daniel Thompson -1 siblings, 0 replies; 26+ messages in thread From: Daniel Thompson @ 2019-12-11 15:18 UTC (permalink / raw) To: Kuninori Morimoto Cc: Andrew Morton, Greg Kroah-Hartman, Yoshinori Sato, Rich Felker, Will Deacon, Douglas Anderson, Paul Burton, Christophe Leroy, linux-sh, linux-kernel On Tue, Dec 10, 2019 at 05:39:00PM +0900, Kuninori Morimoto wrote: > > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > Mark switch cases where we are expecting to fall through. > > This patch fixes the following error: > > LINUX/arch/sh/kernel/kgdb.c: In function 'kgdb_arch_handle_exception': > LINUX/arch/sh/kernel/kgdb.c:267:6: error: this statement may fall through [-Werror=implicit-fallthrough=] > if (kgdb_hex2long(&ptr, &addr)) > ^ > LINUX/arch/sh/kernel/kgdb.c:269:2: note: here > case 'D': > ^~~~ > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > Acked-by: Daniel Thompson <daniel.thompson@linaro.org> > --- > arch/sh/kernel/kgdb.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/sh/kernel/kgdb.c b/arch/sh/kernel/kgdb.c > index 6d61f8c..0d5f3c9 100644 > --- a/arch/sh/kernel/kgdb.c > +++ b/arch/sh/kernel/kgdb.c > @@ -266,6 +266,7 @@ int kgdb_arch_handle_exception(int e_vector, int signo, int err_code, > ptr = &remcomInBuffer[1]; > if (kgdb_hex2long(&ptr, &addr)) > linux_regs->pc = addr; > + /* fallthrough */ Since v5.5-rc1 there is the fallthrough pseudo keyword to document these cases: https://elixir.bootlin.com/linux/v5.5-rc1/source/Documentation/process/coding-style.rst#L59 Daniel. > case 'D': > case 'k': > atomic_set(&kgdb_cpu_doing_single_step, -1); > -- > 2.7.4 > ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH][resend] sh: kgdb: Mark expected switch fall-throughs 2019-12-10 8:38 ` Kuninori Morimoto @ 2019-12-10 20:12 ` Rob Landley -1 siblings, 0 replies; 26+ messages in thread From: Rob Landley @ 2019-12-10 20:12 UTC (permalink / raw) To: Kuninori Morimoto, Andrew Morton, Greg Kroah-Hartman, Yoshinori Sato, Rich Felker Cc: Daniel Thompson, Will Deacon, Douglas Anderson, Paul Burton, Christophe Leroy, linux-sh, linux-kernel On 12/10/19 2:38 AM, Kuninori Morimoto wrote: > > Hi Andrew > > I'm posting this patch from few month ago, > but it seems SH maintainer is not working in these days... Again, I dunno where you're getting that. (Me, I removed the -Werror...) Rob ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH][resend] sh: kgdb: Mark expected switch fall-throughs @ 2019-12-10 20:12 ` Rob Landley 0 siblings, 0 replies; 26+ messages in thread From: Rob Landley @ 2019-12-10 20:12 UTC (permalink / raw) To: Kuninori Morimoto, Andrew Morton, Greg Kroah-Hartman, Yoshinori Sato, Rich Felker Cc: Daniel Thompson, Will Deacon, Douglas Anderson, Paul Burton, Christophe Leroy, linux-sh, linux-kernel On 12/10/19 2:38 AM, Kuninori Morimoto wrote: > > Hi Andrew > > I'm posting this patch from few month ago, > but it seems SH maintainer is not working in these days... Again, I dunno where you're getting that. (Me, I removed the -Werror...) Rob ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH][resend] sh: kgdb: Mark expected switch fall-throughs 2019-12-10 20:12 ` Rob Landley @ 2019-12-10 20:20 ` Rob Landley -1 siblings, 0 replies; 26+ messages in thread From: Rob Landley @ 2019-12-10 20:20 UTC (permalink / raw) To: Kuninori Morimoto, Andrew Morton, Greg Kroah-Hartman, Yoshinori Sato, Rich Felker Cc: Daniel Thompson, Will Deacon, Douglas Anderson, Paul Burton, Christophe Leroy, linux-sh, linux-kernel On 12/10/19 2:12 PM, Rob Landley wrote: > On 12/10/19 2:38 AM, Kuninori Morimoto wrote: >> >> Hi Andrew >> >> I'm posting this patch from few month ago, >> but it seems SH maintainer is not working in these days... > > Again, I dunno where you're getting that. > > (Me, I removed the -Werror...) In fact I looked it up, _I_ didn't remove the -Werror, Rich acked a patch removing the -Werror back in August: https://www.spinics.net/lists/linux-sh/msg55405.html Rob ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH][resend] sh: kgdb: Mark expected switch fall-throughs @ 2019-12-10 20:20 ` Rob Landley 0 siblings, 0 replies; 26+ messages in thread From: Rob Landley @ 2019-12-10 20:20 UTC (permalink / raw) To: Kuninori Morimoto, Andrew Morton, Greg Kroah-Hartman, Yoshinori Sato, Rich Felker Cc: Daniel Thompson, Will Deacon, Douglas Anderson, Paul Burton, Christophe Leroy, linux-sh, linux-kernel On 12/10/19 2:12 PM, Rob Landley wrote: > On 12/10/19 2:38 AM, Kuninori Morimoto wrote: >> >> Hi Andrew >> >> I'm posting this patch from few month ago, >> but it seems SH maintainer is not working in these days... > > Again, I dunno where you're getting that. > > (Me, I removed the -Werror...) In fact I looked it up, _I_ didn't remove the -Werror, Rich acked a patch removing the -Werror back in August: https://www.spinics.net/lists/linux-sh/msg55405.html Rob ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH][resend] sh: kgdb: Mark expected switch fall-throughs 2019-12-10 8:38 ` Kuninori Morimoto @ 2019-12-10 22:28 ` Gustavo A. R. Silva -1 siblings, 0 replies; 26+ messages in thread From: Gustavo A. R. Silva @ 2019-12-10 22:28 UTC (permalink / raw) To: Kuninori Morimoto, Andrew Morton, Greg Kroah-Hartman, Yoshinori Sato, Rich Felker Cc: Daniel Thompson, Will Deacon, Douglas Anderson, Paul Burton, Christophe Leroy, linux-sh, linux-kernel Hi, On 12/10/19 02:38, Kuninori Morimoto wrote: > > Hi Andrew > > I'm posting this patch from few month ago, > but it seems SH maintainer is not working in these days... > > Is it possible to consider about it ? > SH compile will be error without this patch. > I've added this to my -next tree and will consider it for 5.5-rc2. Thanks! -- Gustavo ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH][resend] sh: kgdb: Mark expected switch fall-throughs @ 2019-12-10 22:28 ` Gustavo A. R. Silva 0 siblings, 0 replies; 26+ messages in thread From: Gustavo A. R. Silva @ 2019-12-10 22:28 UTC (permalink / raw) To: Kuninori Morimoto, Andrew Morton, Greg Kroah-Hartman, Yoshinori Sato, Rich Felker Cc: Daniel Thompson, Will Deacon, Douglas Anderson, Paul Burton, Christophe Leroy, linux-sh, linux-kernel Hi, On 12/10/19 02:38, Kuninori Morimoto wrote: > > Hi Andrew > > I'm posting this patch from few month ago, > but it seems SH maintainer is not working in these days... > > Is it possible to consider about it ? > SH compile will be error without this patch. > I've added this to my -next tree and will consider it for 5.5-rc2. Thanks! -- Gustavo ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH][resend] sh: kgdb: Mark expected switch fall-throughs 2019-12-10 22:28 ` Gustavo A. R. Silva @ 2019-12-11 9:17 ` Yoshinori Sato -1 siblings, 0 replies; 26+ messages in thread From: Yoshinori Sato @ 2019-12-11 9:17 UTC (permalink / raw) To: Gustavo A. R. Silva Cc: Kuninori Morimoto, Andrew Morton, Greg Kroah-Hartman, Rich Felker, Daniel Thompson, Will Deacon, Douglas Anderson, Paul Burton, Christophe Leroy, linux-sh, linux-kernel On Wed, 11 Dec 2019 07:28:43 +0900, Gustavo A. R. Silva wrote: > > Hi, > > On 12/10/19 02:38, Kuninori Morimoto wrote: > > > > Hi Andrew > > > > I'm posting this patch from few month ago, > > but it seems SH maintainer is not working in these days... > > > > Is it possible to consider about it ? > > SH compile will be error without this patch. > > > > I've added this to my -next tree and will consider it for 5.5-rc2. > > Thanks! > -- > Gustavo > Thanks. I was going to work tonight or tomorrow. Dose nothing if merged. -- Yoshinori Sato ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH][resend] sh: kgdb: Mark expected switch fall-throughs @ 2019-12-11 9:17 ` Yoshinori Sato 0 siblings, 0 replies; 26+ messages in thread From: Yoshinori Sato @ 2019-12-11 9:17 UTC (permalink / raw) To: Gustavo A. R. Silva Cc: Kuninori Morimoto, Andrew Morton, Greg Kroah-Hartman, Rich Felker, Daniel Thompson, Will Deacon, Douglas Anderson, Paul Burton, Christophe Leroy, linux-sh, linux-kernel On Wed, 11 Dec 2019 07:28:43 +0900, Gustavo A. R. Silva wrote: > > Hi, > > On 12/10/19 02:38, Kuninori Morimoto wrote: > > > > Hi Andrew > > > > I'm posting this patch from few month ago, > > but it seems SH maintainer is not working in these days... > > > > Is it possible to consider about it ? > > SH compile will be error without this patch. > > > > I've added this to my -next tree and will consider it for 5.5-rc2. > > Thanks! > -- > Gustavo > Thanks. I was going to work tonight or tomorrow. Dose nothing if merged. -- Yoshinori Sato ^ permalink raw reply [flat|nested] 26+ messages in thread
end of thread, other threads:[~2019-12-11 15:18 UTC | newest] Thread overview: 26+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-11-25 7:16 [PATCH][resend] sh: kgdb: Mark expected switch fall-throughs Kuninori Morimoto 2019-11-25 7:16 ` Kuninori Morimoto 2019-12-10 0:26 ` Kuninori Morimoto 2019-12-10 0:26 ` Kuninori Morimoto 2019-12-10 0:27 ` [PATCH] " Kuninori Morimoto 2019-12-10 0:27 ` Kuninori Morimoto 2019-12-10 8:17 ` [PATCH][resend] " Geert Uytterhoeven 2019-12-10 8:17 ` Geert Uytterhoeven 2019-12-10 8:19 ` Kuninori Morimoto 2019-12-10 8:19 ` Kuninori Morimoto 2019-12-10 20:10 ` Rob Landley 2019-12-10 20:10 ` Rob Landley 2019-12-10 8:38 ` Kuninori Morimoto 2019-12-10 8:38 ` Kuninori Morimoto 2019-12-10 8:39 ` [PATCH] " Kuninori Morimoto 2019-12-10 8:39 ` Kuninori Morimoto 2019-12-10 8:47 ` Christophe Leroy 2019-12-11 15:18 ` Daniel Thompson 2019-12-10 20:12 ` [PATCH][resend] " Rob Landley 2019-12-10 20:12 ` Rob Landley 2019-12-10 20:20 ` Rob Landley 2019-12-10 20:20 ` Rob Landley 2019-12-10 22:28 ` Gustavo A. R. Silva 2019-12-10 22:28 ` Gustavo A. R. Silva 2019-12-11 9:17 ` Yoshinori Sato 2019-12-11 9:17 ` Yoshinori Sato
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.