From: Yoshinori Sato <ysato@users.sourceforge.jp>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Rich Felker <dalias@libc.org>, Karl Nasrallah <knnspeed@aol.com>,
Linux-SH <linux-sh@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>
Subject: Re: [PATCH v2 0/3] sh: fixup strncpy()
Date: Sat, 21 Dec 2019 00:42:02 +0900 [thread overview]
Message-ID: <s59o8w3qa0l.wl-ysato@users.sourceforge.jp> (raw)
In-Reply-To: <87woatyutt.wl-kuninori.morimoto.gx@renesas.com>
On Thu, 19 Dec 2019 10:20:46 +0900,
Kuninori Morimoto wrote:
>
>
> Hi Sato-san, Rich
>
> These are strncpy() fixup patches, but using different solutions.
> Karl's patches are updating current strncpy(), but using 2 patterns.
> Kuninori's patch is using generic strncpy().
>
> We don't know which is the best, but we can follow
> SH maintainer's selection.
>
> Karl Nasrallah (2):
> sh: fixup strncpy() warning and add missing padding
> sh: fixup strncpy() warning and add missing padding
>
> Kuninori Morimoto (4):
> sh: use generic strncpy()
>
> Thank you for your help !!
> Best regards
> ---
> Kuninori Morimoto
I think the generic version is better, but I want to decide after comparing what code is generated.
If it is not very inefficient, I would like to make it a generic version.
--
Yoshinori Sato
WARNING: multiple messages have this Message-ID (diff)
From: Yoshinori Sato <ysato@users.sourceforge.jp>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Rich Felker <dalias@libc.org>, Karl Nasrallah <knnspeed@aol.com>,
Linux-SH <linux-sh@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>
Subject: Re: [PATCH v2 0/3] sh: fixup strncpy()
Date: Fri, 20 Dec 2019 15:42:02 +0000 [thread overview]
Message-ID: <s59o8w3qa0l.wl-ysato@users.sourceforge.jp> (raw)
In-Reply-To: <87woatyutt.wl-kuninori.morimoto.gx@renesas.com>
On Thu, 19 Dec 2019 10:20:46 +0900,
Kuninori Morimoto wrote:
>
>
> Hi Sato-san, Rich
>
> These are strncpy() fixup patches, but using different solutions.
> Karl's patches are updating current strncpy(), but using 2 patterns.
> Kuninori's patch is using generic strncpy().
>
> We don't know which is the best, but we can follow
> SH maintainer's selection.
>
> Karl Nasrallah (2):
> sh: fixup strncpy() warning and add missing padding
> sh: fixup strncpy() warning and add missing padding
>
> Kuninori Morimoto (4):
> sh: use generic strncpy()
>
> Thank you for your help !!
> Best regards
> ---
> Kuninori Morimoto
I think the generic version is better, but I want to decide after comparing what code is generated.
If it is not very inefficient, I would like to make it a generic version.
--
Yoshinori Sato
next prev parent reply other threads:[~2019-12-20 15:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 1:20 [PATCH v2 0/3] sh: fixup strncpy() Kuninori Morimoto
2019-12-19 1:20 ` Kuninori Morimoto
2019-12-19 1:23 ` [PATCH v2 1/3] sh: fixup strncpy() warning and add missing padding Kuninori Morimoto
2019-12-19 1:23 ` Kuninori Morimoto
2019-12-19 1:24 ` [PATCH v2 2/3] " Kuninori Morimoto
2019-12-19 1:24 ` Kuninori Morimoto
2019-12-19 1:24 ` [PATCH 3/3] sh: use generic strncpy() Kuninori Morimoto
2019-12-19 1:24 ` Kuninori Morimoto
2019-12-20 15:42 ` Yoshinori Sato [this message]
2019-12-20 15:42 ` [PATCH v2 0/3] sh: fixup strncpy() Yoshinori Sato
2019-12-21 2:35 ` Karl Nasrallah
2019-12-21 2:35 ` Karl Nasrallah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s59o8w3qa0l.wl-ysato@users.sourceforge.jp \
--to=ysato@users.sourceforge.jp \
--cc=dalias@libc.org \
--cc=geert+renesas@glider.be \
--cc=knnspeed@aol.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.