All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Jaroslav Kysela <perex@perex.cz>
Cc: alsa-devel@alsa-project.org, HaraldWelte@viatech.com,
	Lydia Wang <lydiawang@viatech.com.cn>
Subject: Re: [PATCH 7/16] ALSA: VIA HDA: Modify notify_aa_path_ctls() function
Date: Mon, 21 Mar 2011 12:08:19 +0100	[thread overview]
Message-ID: <s5h39mgspcs.wl%tiwai@suse.de> (raw)
In-Reply-To: <alpine.LNX.2.00.1103210832030.4805@eeebox2.perex-int.cz>

At Mon, 21 Mar 2011 08:32:43 +0100 (CET),
Jaroslav Kysela wrote:
> 
> On Mon, 21 Mar 2011, Lydia Wang wrote:
> 
> > From: Lydia Wang <lydiawang@viatech.com.cn>
> > Subject: ALSA: VIA HDA: Modify notify_aa_path_ctls() function.
> >
> > Modify notify_aa_path_ctls() function to get volume control items name
> > dynamically instead of by giving static item name.
> 
> This code looks ugly to me. If you like to have a dynamic set of notified 
> controls, create one using snd_array in via_spec.

Agreed.  The current code is too fragile.


thanks,

Takashi

  reply	other threads:[~2011-03-21 11:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-21  7:29 [PATCH 7/16] ALSA: VIA HDA: Modify notify_aa_path_ctls() function Lydia Wang
2011-03-21  7:32 ` Jaroslav Kysela
2011-03-21 11:08   ` Takashi Iwai [this message]
     [not found]     ` <5B2BE0DB92BC8F4694F815C2F34E0D5F660B76@exchbj03.viatech.com.bj>
2011-03-24  7:55       ` 答复: " Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h39mgspcs.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=HaraldWelte@viatech.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=lydiawang@viatech.com.cn \
    --cc=perex@perex.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.