Re: current buglets

[Takashi Iwai <tiwai@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 751 bytes --]

At Thu, 15 Aug 2002 16:04:44 +0200,
Thierry Vignaud wrote:
> 
> Takashi Iwai <tiwai@suse.de> writes:
> 
> > OSS emulation
> > - Wine OSS (mmap) is not working. (A workaround already known.)
> 
> you would be very nice to tell me which woraround to use :-)

the problem is basically on wine, so the "right" way to fix wine.
but the short way is to apply the following patch.

wine tries to mmap with the 8bit mode first, and gives up the whole
sound when it doesn't work.
alsa oss emulation accepts 8bit mode as long as it's accessed via
read/write, because plugin can handle it.  but, mmap cannot.  so the
application can be confused.

the attached patch has an obvious drawback, that application can run
mmap even with the wrong parameter.


Takashi

[-- Attachment #2: oss-mmap-fix.dif --]
[-- Type: application/octet-stream, Size: 758 bytes --]

Index: alsa-kernel/core/oss/pcm_oss.c
===================================================================
RCS file: /suse/tiwai/cvs/alsa/alsa-kernel/core/oss/pcm_oss.c,v
retrieving revision 1.15
diff -u -r1.15 pcm_oss.c
--- alsa-kernel/core/oss/pcm_oss.c	13 Aug 2002 16:17:06 -0000	1.15
+++ alsa-kernel/core/oss/pcm_oss.c	15 Aug 2002 14:58:13 -0000
@@ -1912,8 +1912,10 @@
 		if ((err = snd_pcm_oss_change_params(substream)) < 0)
 			return err;
 	}
-	if (runtime->oss.plugin_first != NULL)
-		return -EIO;
+	if (runtime->oss.plugin_first != NULL) {
+		snd_printk(KERN_WARNING "pcm-oss: conversion is needed for this mmap, you might get only noises.\n");
+		// return -EIO;
+	}
 
 #if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 3, 25)
 	if (area->vm_pgoff != 0)