From: Takashi Iwai <tiwai-l3A5Bk7waGM@public.gmane.org>
To: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
"Konrad Rzeszutek Wilk"
<konrad.wilk-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Christian König" <christian.koenig-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [PATCH] swiotlb: Fix unexpected swiotlb_alloc_coherent() failures
Date: Wed, 11 Apr 2018 09:28:54 +0200 [thread overview]
Message-ID: <s5h4lkib3rd.wl-tiwai@suse.de> (raw)
In-Reply-To: <20180410181020.GA28565-jcswGhMUV9g@public.gmane.org>
On Tue, 10 Apr 2018 20:10:20 +0200,
Christoph Hellwig wrote:
>
> On Tue, Apr 10, 2018 at 06:50:04PM +0100, Robin Murphy wrote:
> > In the first one, the machine appears to have enough RAM that most of it is
> > beyond the device's 36-bit DMA mask, thus it's fairly likely for the
> > initial direct alloc to come back with something unsuitable.
>
> But we should try a GFP_DMA32 allocation first, so this is a bit
> surprising.
Hm, do we really try that?
Through a quick glance, dma_alloc_coherent_gfp_flags() gives GFP_DMA32
only when coherent mask <= DMA_BIT_MASK(32); in the case of iwlwifi,
it's 36bit, so GFP_DMA isn't set.
We had a fallback allocation with GFP_DMA32 in the past, but this
seems gone long time ago along with cleanups (commit c647c3bb2d16).
But I haven't followed about this topic for long time, so I might have
missed obviously...
thanks,
Takashi
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: "Robin Murphy" <robin.murphy@arm.com>,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
"Christian König" <christian.koenig@amd.com>,
"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>
Subject: Re: [PATCH] swiotlb: Fix unexpected swiotlb_alloc_coherent() failures
Date: Wed, 11 Apr 2018 09:28:54 +0200 [thread overview]
Message-ID: <s5h4lkib3rd.wl-tiwai@suse.de> (raw)
In-Reply-To: <20180410181020.GA28565@lst.de>
On Tue, 10 Apr 2018 20:10:20 +0200,
Christoph Hellwig wrote:
>
> On Tue, Apr 10, 2018 at 06:50:04PM +0100, Robin Murphy wrote:
> > In the first one, the machine appears to have enough RAM that most of it is
> > beyond the device's 36-bit DMA mask, thus it's fairly likely for the
> > initial direct alloc to come back with something unsuitable.
>
> But we should try a GFP_DMA32 allocation first, so this is a bit
> surprising.
Hm, do we really try that?
Through a quick glance, dma_alloc_coherent_gfp_flags() gives GFP_DMA32
only when coherent mask <= DMA_BIT_MASK(32); in the case of iwlwifi,
it's 36bit, so GFP_DMA isn't set.
We had a fallback allocation with GFP_DMA32 in the past, but this
seems gone long time ago along with cleanups (commit c647c3bb2d16).
But I haven't followed about this topic for long time, so I might have
missed obviously...
thanks,
Takashi
next prev parent reply other threads:[~2018-04-11 7:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 17:05 [PATCH] swiotlb: Fix unexpected swiotlb_alloc_coherent() failures Takashi Iwai
2018-04-10 17:05 ` Takashi Iwai
2018-04-10 17:06 ` Christoph Hellwig
[not found] ` <20180410170615.GA27589-jcswGhMUV9g@public.gmane.org>
2018-04-10 17:07 ` Takashi Iwai
2018-04-10 17:07 ` Takashi Iwai
[not found] ` <s5hzi2bat25.wl-tiwai-l3A5Bk7waGM@public.gmane.org>
2018-04-10 17:50 ` Robin Murphy
2018-04-10 17:50 ` Robin Murphy
[not found] ` <40618b9c-786d-7f5f-3f5b-fc1dd8375846-5wv7dgnIgG8@public.gmane.org>
2018-04-10 18:10 ` Christoph Hellwig
2018-04-10 18:10 ` Christoph Hellwig
[not found] ` <20180410181020.GA28565-jcswGhMUV9g@public.gmane.org>
2018-04-11 7:28 ` Takashi Iwai [this message]
2018-04-11 7:28 ` Takashi Iwai
[not found] ` <s5h4lkib3rd.wl-tiwai-l3A5Bk7waGM@public.gmane.org>
2018-04-12 6:02 ` Christoph Hellwig
2018-04-12 6:02 ` Christoph Hellwig
[not found] ` <20180412060227.GA30248-jcswGhMUV9g@public.gmane.org>
2018-04-12 8:03 ` Takashi Iwai
2018-04-12 8:03 ` Takashi Iwai
[not found] ` <s5h3700am1f.wl-tiwai-l3A5Bk7waGM@public.gmane.org>
2018-04-12 8:19 ` Takashi Iwai
2018-04-12 8:19 ` Takashi Iwai
[not found] ` <s5hy3hs96rq.wl-tiwai-l3A5Bk7waGM@public.gmane.org>
2018-04-12 8:27 ` Takashi Iwai
2018-04-12 8:27 ` Takashi Iwai
[not found] ` <s5hwoxc96d5.wl-tiwai-l3A5Bk7waGM@public.gmane.org>
2018-04-12 10:32 ` Robin Murphy
2018-04-12 10:32 ` Robin Murphy
[not found] ` <81b9eae2-11d4-162d-9d3a-12e06eff9fea-5wv7dgnIgG8@public.gmane.org>
2018-04-15 8:43 ` Takashi Iwai
2018-04-15 8:43 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h4lkib3rd.wl-tiwai@suse.de \
--to=tiwai-l3a5bk7wagm@public.gmane.org \
--cc=christian.koenig-5C7GfCeVMHo@public.gmane.org \
--cc=hch-jcswGhMUV9g@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=konrad.wilk-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.