From: Takashi Iwai <tiwai@suse.de>
To: Adrian Knoth <adi@drcomp.erfurt.thur.de>
Cc: alsa-devel@alsa-project.org, patch@alsa-project.org
Subject: Re: [PATCH 1/3] ALSA: hdspm - Fix MADI channel format in the status ioctl
Date: Mon, 31 Oct 2011 10:05:20 +0100 [thread overview]
Message-ID: <s5h4nypa5v3.wl%tiwai@suse.de> (raw)
In-Reply-To: <1319745474-31542-1-git-send-email-adi@drcomp.erfurt.thur.de>
At Thu, 27 Oct 2011 21:57:52 +0200,
Adrian Knoth wrote:
>
> SNDRV_HDSPM_IOCTL_GET_STATUS is supposed to query the current card
> status, so we have to return what we receive on the MADI wire (RX), not
> what we transmit (TX) to others. The latter is a config item to be
> queried via SNDRV_HDSPM_IOCTL_GET_CONFIG.
>
> Signed-off-by: Adrian Knoth <adi@drcomp.erfurt.thur.de>
Applied all three patches now. Thanks.
Takashi
> diff --git a/sound/pci/rme9652/hdspm.c b/sound/pci/rme9652/hdspm.c
> index 6e2f7ef..60a0b7d 100644
> --- a/sound/pci/rme9652/hdspm.c
> +++ b/sound/pci/rme9652/hdspm.c
> @@ -6253,7 +6253,7 @@ static int snd_hdspm_hwdep_ioctl(struct snd_hwdep *hw, struct file *file,
> status.card_specific.madi.madi_input =
> (statusregister & HDSPM_AB_int) ? 1 : 0;
> status.card_specific.madi.channel_format =
> - (statusregister & HDSPM_TX_64ch) ? 1 : 0;
> + (statusregister & HDSPM_RX_64ch) ? 1 : 0;
> /* TODO: Mac driver sets it when f_s>48kHz */
> status.card_specific.madi.frame_format = 0;
>
> --
> 1.7.7.1
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
prev parent reply other threads:[~2011-10-31 9:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-27 19:57 [PATCH 1/3] ALSA: hdspm - Fix MADI channel format in the status ioctl Adrian Knoth
2011-10-27 19:57 ` [PATCH 2/3] ALSA: hdsp - Correct HDSP_VERSION_BIT constant, thus partly fixing RPM detection Adrian Knoth
2011-10-27 19:57 ` [PATCH 3/3] ALSA: hdspm - Enable all firmware ranges for PCI MADI/AES cards Adrian Knoth
2011-10-31 9:05 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h4nypa5v3.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=adi@drcomp.erfurt.thur.de \
--cc=alsa-devel@alsa-project.org \
--cc=patch@alsa-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.