dummy driver and Makefile inconsistency

dummy driver and Makefile inconsistency

[Andrei Boros]

 alsa-kernel/core/seq/Makefile contains the following:

obj-$(CONFIG_SND_SEQ_DUMMY) += snd-seq-dummy.o

However, there is no definition of CONFIG_SND_SEQ_DUMMY anywhere !!!

I believe CONFIG_SND_SEQ_DUMMY should be set to "m" if dummy driver and
sequencer support are enabled.

---------------------------------------------------------------
I made several changes so that ./configure sets this properly and the
module gets built properly, but I am having some trouble integrating it
with autoconf in the cvs tree before running cvscompile.

Here are the modifications I made in my alsa-driver/ : 

Makefile line 50:
-----------------------------------------------------------------
CONFIG_PCMCIA           = @CONFIG_PCMCIA@
CONFIG_SND_SEQUENCER    = @CONFIG_SND_SEQUENCER@
+CONFIG_SND_SEQ_DUMMY    = @CONFIG_SND_SEQ_DUMMY@
CONFIG_SND_OSSEMUL      = @CONFIG_SND_OSSEMUL@
ifeq (y,$(CONFIG_SND_OSSEMUL))
  CONFIG_SND_MIXER_OSS  = m
  CONFIG_SND_PCM_OSS    = m
-----------------------------------------------------------------
configure.in line 792 :
-----------------------------------------------------------------
fi
AC_SUBST(CONFIG_SND_SEQUENCER)
+dnl if test "$CONFIG_SND_DUMMY" = "m"; then
+  CONFIG_SND_SEQ_DUMMY="m"
+  AC_SUBST(CONFIG_SND_SEQ_DUMMY)
+  AC_DEFINE_CONFIG_SND_SEQ_DUMMY)
+dnl fi
if test "$CONFIG_SND_SEQUENCER" = "m"; then
  AC_DEFINE(CONFIG_SND_SEQUENCER)
-----------------------------------------------------------------
configure line 2930 : (I don't know how to integrate this with autoconf
and cvscompile)
-----------------------------------------------------------------
#define CONFIG_SND_DUMMY_MODULE 1
EOF
+        if test "$CONFIG_SND_SEQUENCER" = "m"; then
+            CONFIG_SND_SEQ_DUMMY="m"
+        fi

        CONFIG_SND_VIRMIDI="m"
        cat >> confdefs.h <<\EOF
-----------------------------------------------------------------
configure line 3408 : (I don't know how to integrate this with autoconf
and cvscompile)
-----------------------------------------------------------------
#define CONFIG_SND_DUMMY_MODULE 1
EOF
+                if test "$CONFIG_SND_SEQUENCER" = "m"; then
+                    CONFIG_SND_SEQ_DUMMY="m"
+                fi

                ;;
-----------------------------------------------------------------

-- 
ing. Andrei Boros
mailto:andrei@srr.ro / +40-21-303-1870
Centrul pt. Tehnologia Informatiei
Societatea Romana de Radiodifuziune


-------------------------------------------------------
This SF.net email is sponsored by: Does your code think in ink? 
You could win a Tablet PC. Get a free Tablet PC hat just for playing. 
What are you waiting for?
http://ads.sourceforge.net/cgi-bin/redirect.pl?micr5043en

Re: dummy driver and Makefile inconsistency

[Takashi Iwai]

At Wed, 19 Mar 2003 10:48:09 +0200,
Andrei Boros wrote:
> 
> 
>  alsa-kernel/core/seq/Makefile contains the following:
> 
> obj-$(CONFIG_SND_SEQ_DUMMY) += snd-seq-dummy.o
> 
> However, there is no definition of CONFIG_SND_SEQ_DUMMY anywhere !!!

thanks for finding this.
fixed on cvs now.


Takashi


-------------------------------------------------------
This SF.net email is sponsored by: Does your code think in ink? 
You could win a Tablet PC. Get a free Tablet PC hat just for playing. 
What are you waiting for?
http://ads.sourceforge.net/cgi-bin/redirect.pl?micr5043en